From patchwork Thu Jul 4 09:52:25 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 11031333 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4108013A4 for ; Thu, 4 Jul 2019 09:46:22 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3062F28A17 for ; Thu, 4 Jul 2019 09:46:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2400628A1B; Thu, 4 Jul 2019 09:46:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 9D2E628A17 for ; Thu, 4 Jul 2019 09:46:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=fjl8g1JX7M0BVL2h0lMTANtdE7S66JTSENk+q1EhVrI=; b=fyKrRGqjkSBOS8 6PPN16e5DegYBTncclBO7JJzzGu8az5IdFbgZQHG0mCkJts/qSoX/F98pkjCfEgswCyH4UYVYYRy1 zIlMEgNC1/M6eQgTYWjGZKw3xlmU/2VKOzTNKQCDXO1O9EuG+QPSVczGr4MIyZj3bSF8JfppZZHBL V15TfDDJUTSSNMDHlTlHPWg8c15e+Pa1ZjEE5XPv/bqN3D0Xk5O+7rRbIkm60siB3bl1H9VlkNRxV S4N4ogxWmtAeVibhUSBXzkl3PFJkQapt+gpZcKG09c4RvXInvCpLqXW22WwdT18iCpjJFaIqeQH0M aUktd9Qtm1VxmFRRu1iw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hiyJp-0002Tg-BD; Thu, 04 Jul 2019 09:46:21 +0000 Received: from szxga07-in.huawei.com ([45.249.212.35] helo=huawei.com) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hiyJk-0002Si-Rf for linux-arm-kernel@lists.infradead.org; Thu, 04 Jul 2019 09:46:18 +0000 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 89A0C282A6D9B3730D51; Thu, 4 Jul 2019 17:46:03 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.439.0; Thu, 4 Jul 2019 17:45:57 +0800 From: Wei Yongjun To: Sascha Hauer , Pengutronix Kernel Team , Bartlomiej Zolnierkiewicz , Shawn Guo , Fabio Estevam , NXP Linux Team Subject: [PATCH -next] video: fbdev: imxfb: fix a typo in imxfb_probe() Date: Thu, 4 Jul 2019 09:52:25 +0000 Message-ID: <20190704095225.143177-1-weiyongjun1@huawei.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190704_024617_124108_BC4DBF70 X-CRM114-Status: GOOD ( 10.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, linux-fbdev@vger.kernel.org, Wei Yongjun , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Fix the return value check which testing the wrong variable in imxfb_probe(). Fixes: 739a6439c2bf ("video: fbdev: imxfb: fix sparse warnings about using incorrect types") Signed-off-by: Wei Yongjun --- drivers/video/fbdev/imxfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/imxfb.c b/drivers/video/fbdev/imxfb.c index 8d1053e9ef9f..b3286d1fa543 100644 --- a/drivers/video/fbdev/imxfb.c +++ b/drivers/video/fbdev/imxfb.c @@ -976,7 +976,7 @@ static int imxfb_probe(struct platform_device *pdev) fbi->map_size = PAGE_ALIGN(info->fix.smem_len); info->screen_buffer = dma_alloc_wc(&pdev->dev, fbi->map_size, &fbi->map_dma, GFP_KERNEL); - if (!info->screen_base) { + if (!info->screen_buffer) { dev_err(&pdev->dev, "Failed to allocate video RAM: %d\n", ret); ret = -ENOMEM; goto failed_map;