| Message ID | 20190709182543.GA6611@hari-Inspiron-1545 (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 1d3dd532883be6167da5df6117efd6d4e8790456 |
| Headers | show |
| Series | sound: soc: codecs: mt6358: change return type of mt6358_codec_init_reg | expand |
On Wed, Jul 10, 2019 at 2:25 AM Hariprasad Kelam <hariprasad.kelam@gmail.com> wrote: > > As mt6358_codec_init_reg function always returns 0 , change return type > from int to void. > > fixes below issue reported by coccicheck > sound/soc/codecs/mt6358.c:2260:5-8: Unneeded variable: "ret". Return "0" > on line 2289 > > Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com> Acked-by: Tzung-Bi Shih <tzungbi@google.com> Thanks for cleaning this up.
On Tue, Jul 09, 2019 at 11:55:43PM +0530, Hariprasad Kelam wrote: > As mt6358_codec_init_reg function always returns 0 , change return type > from int to void. Please use subject lines matching the style for the subsystem. This makes it easier for people to identify relevant patches.
diff --git a/sound/soc/codecs/mt6358.c b/sound/soc/codecs/mt6358.c index 50b3fc5..c17250a 100644 --- a/sound/soc/codecs/mt6358.c +++ b/sound/soc/codecs/mt6358.c @@ -2255,10 +2255,8 @@ static struct snd_soc_dai_driver mt6358_dai_driver[] = { }, }; -static int mt6358_codec_init_reg(struct mt6358_priv *priv) +static void mt6358_codec_init_reg(struct mt6358_priv *priv) { - int ret = 0; - /* Disable HeadphoneL/HeadphoneR short circuit protection */ regmap_update_bits(priv->regmap, MT6358_AUDDEC_ANA_CON0, RG_AUDHPLSCDISABLE_VAUDP15_MASK_SFT, @@ -2285,8 +2283,6 @@ static int mt6358_codec_init_reg(struct mt6358_priv *priv) /* set gpio */ playback_gpio_reset(priv); capture_gpio_reset(priv); - - return ret; } static int mt6358_codec_probe(struct snd_soc_component *cmpnt)
As mt6358_codec_init_reg function always returns 0 , change return type from int to void. fixes below issue reported by coccicheck sound/soc/codecs/mt6358.c:2260:5-8: Unneeded variable: "ret". Return "0" on line 2289 Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com> --- sound/soc/codecs/mt6358.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)