| Message ID | 20190717142315.3119-1-nishkadg.linux@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | staging: media: sunxi: Add bool cast to value | expand |
Hi, On Wed 17 Jul 19, 19:53, Nishka Dasgupta wrote: > Typecast as bool the return value of cedrus_find_format in > cedrus_check_format as the return value of cedrus_check_format is always > treated like a boolean value. Thanks for the patch! Could we also add !! to the returned pointer so that we are sure that the function returns either false or true, but never a non-zero value that is not true? Cheers, Paul > Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com> > --- > drivers/staging/media/sunxi/cedrus/cedrus_video.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_video.c b/drivers/staging/media/sunxi/cedrus/cedrus_video.c > index e2b530b1a956..f00a048a0a01 100644 > --- a/drivers/staging/media/sunxi/cedrus/cedrus_video.c > +++ b/drivers/staging/media/sunxi/cedrus/cedrus_video.c > @@ -86,7 +86,7 @@ static struct cedrus_format *cedrus_find_format(u32 pixelformat, u32 directions, > static bool cedrus_check_format(u32 pixelformat, u32 directions, > unsigned int capabilities) > { > - return cedrus_find_format(pixelformat, directions, capabilities); > + return (bool)cedrus_find_format(pixelformat, directions, capabilities); > } > > static void cedrus_prepare_format(struct v4l2_pix_format *pix_fmt) > -- > 2.19.1 >
diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_video.c b/drivers/staging/media/sunxi/cedrus/cedrus_video.c index e2b530b1a956..f00a048a0a01 100644 --- a/drivers/staging/media/sunxi/cedrus/cedrus_video.c +++ b/drivers/staging/media/sunxi/cedrus/cedrus_video.c @@ -86,7 +86,7 @@ static struct cedrus_format *cedrus_find_format(u32 pixelformat, u32 directions, static bool cedrus_check_format(u32 pixelformat, u32 directions, unsigned int capabilities) { - return cedrus_find_format(pixelformat, directions, capabilities); + return (bool)cedrus_find_format(pixelformat, directions, capabilities); } static void cedrus_prepare_format(struct v4l2_pix_format *pix_fmt)
Typecast as bool the return value of cedrus_find_format in cedrus_check_format as the return value of cedrus_check_format is always treated like a boolean value. Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com> --- drivers/staging/media/sunxi/cedrus/cedrus_video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)