| Message ID | 20190723112811.44381-4-tony@atomide.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ti-sysc related warning fixes for v5.3-rc cycle | expand |
On 7/23/19 6:28 AM, Tony Lindgren wrote: > For some devices we can get the following warning on boot: > > ti-sysc 48485200.target-module: sysc_disable_module: invalid midlemode > > Fix this by treating SYSC_IDLE_FORCE like we do for the other bits > for idlemodes mask. > > Fixes: d59b60564cbf ("bus: ti-sysc: Add generic enable/disable functions") > Cc: Roger Quadros <rogerq@ti.com> > Signed-off-by: Tony Lindgren <tony@atomide.com> Reviewed-by: Suman Anna <s-anna@ti.com> regards Suman > --- > drivers/bus/ti-sysc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c > --- a/drivers/bus/ti-sysc.c > +++ b/drivers/bus/ti-sysc.c > @@ -949,7 +949,7 @@ static int sysc_best_idle_mode(u32 idlemodes, u32 *best_mode) > *best_mode = SYSC_IDLE_SMART_WKUP; > else if (idlemodes & BIT(SYSC_IDLE_SMART)) > *best_mode = SYSC_IDLE_SMART; > - else if (idlemodes & SYSC_IDLE_FORCE) > + else if (idlemodes & BIT(SYSC_IDLE_FORCE)) > *best_mode = SYSC_IDLE_FORCE; > else > return -EINVAL; >
diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c --- a/drivers/bus/ti-sysc.c +++ b/drivers/bus/ti-sysc.c @@ -949,7 +949,7 @@ static int sysc_best_idle_mode(u32 idlemodes, u32 *best_mode) *best_mode = SYSC_IDLE_SMART_WKUP; else if (idlemodes & BIT(SYSC_IDLE_SMART)) *best_mode = SYSC_IDLE_SMART; - else if (idlemodes & SYSC_IDLE_FORCE) + else if (idlemodes & BIT(SYSC_IDLE_FORCE)) *best_mode = SYSC_IDLE_FORCE; else return -EINVAL;
For some devices we can get the following warning on boot: ti-sysc 48485200.target-module: sysc_disable_module: invalid midlemode Fix this by treating SYSC_IDLE_FORCE like we do for the other bits for idlemodes mask. Fixes: d59b60564cbf ("bus: ti-sysc: Add generic enable/disable functions") Cc: Roger Quadros <rogerq@ti.com> Signed-off-by: Tony Lindgren <tony@atomide.com> --- drivers/bus/ti-sysc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)