| Message ID | 20190724114312.1024-3-suzuki.poulose@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | coresight: tmc error handling and misc fixes | expand |
On Wed, Jul 24, 2019 at 12:43:09PM +0100, Suzuki K Poulose wrote: > We warn the users of obsolete bindings in the DT for coresight funnel. > However we use pr_warn_once() which doesn't give a clue about which device > it is bound to. Let us use dev_warn_once() to give the context. > > Cc: Mathieu Poirier <mathieu.poirier@linaro.org> > Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com> > --- > drivers/hwtracing/coresight/coresight-funnel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hwtracing/coresight/coresight-funnel.c b/drivers/hwtracing/coresight/coresight-funnel.c > index fa97cb9ab4f9..84ca30f4e5ec 100644 > --- a/drivers/hwtracing/coresight/coresight-funnel.c > +++ b/drivers/hwtracing/coresight/coresight-funnel.c > @@ -192,7 +192,7 @@ static int funnel_probe(struct device *dev, struct resource *res) > > if (is_of_node(dev_fwnode(dev)) && > of_device_is_compatible(dev->of_node, "arm,coresight-funnel")) > - pr_warn_once("Uses OBSOLETE CoreSight funnel binding\n"); > + dev_warn_once(dev, "Uses OBSOLETE CoreSight funnel binding\n"); Please do the same for replicators. Thanks, Mathieu > > desc.name = coresight_alloc_device_name(&funnel_devs, dev); > if (!desc.name) > -- > 2.21.0 >
diff --git a/drivers/hwtracing/coresight/coresight-funnel.c b/drivers/hwtracing/coresight/coresight-funnel.c index fa97cb9ab4f9..84ca30f4e5ec 100644 --- a/drivers/hwtracing/coresight/coresight-funnel.c +++ b/drivers/hwtracing/coresight/coresight-funnel.c @@ -192,7 +192,7 @@ static int funnel_probe(struct device *dev, struct resource *res) if (is_of_node(dev_fwnode(dev)) && of_device_is_compatible(dev->of_node, "arm,coresight-funnel")) - pr_warn_once("Uses OBSOLETE CoreSight funnel binding\n"); + dev_warn_once(dev, "Uses OBSOLETE CoreSight funnel binding\n"); desc.name = coresight_alloc_device_name(&funnel_devs, dev); if (!desc.name)
We warn the users of obsolete bindings in the DT for coresight funnel. However we use pr_warn_once() which doesn't give a clue about which device it is bound to. Let us use dev_warn_once() to give the context. Cc: Mathieu Poirier <mathieu.poirier@linaro.org> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com> --- drivers/hwtracing/coresight/coresight-funnel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)