| Message ID | 20190726092621.27972-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | db0e6a573e9c54151cdc828e80ab82849802337f |
| Headers | show |
| Series | [v2,-next] staging: vc04_services: fix used-but-set-variable warning | expand |
Hi Yue, Am 26.07.19 um 11:26 schrieb YueHaibing: > Fix gcc used-but-set-variable warning: just a nit. It is call "unused-but-set-variable" Acked-by: Stefan Wahren <wahrenst@gmx.net> > > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c: In function vchiq_release_internal: > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:2827:16: warning: > variable local_entity_uc set but not used [-Wunused-but-set-variable] > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:2827:6: warning: > variable local_uc set but not used [-Wunused-but-set-variable] > > Remove the unused variables 'local_entity_uc' and 'local_uc' > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > ---
On 2019/7/26 23:57, Stefan Wahren wrote: > Hi Yue, > > Am 26.07.19 um 11:26 schrieb YueHaibing: >> Fix gcc used-but-set-variable warning: > > just a nit. It is call "unused-but-set-variable" Oh, yes, thanks! > > Acked-by: Stefan Wahren <wahrenst@gmx.net> > >> >> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c: In function vchiq_release_internal: >> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:2827:16: warning: >> variable local_entity_uc set but not used [-Wunused-but-set-variable] >> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:2827:6: warning: >> variable local_uc set but not used [-Wunused-but-set-variable] >> >> Remove the unused variables 'local_entity_uc' and 'local_uc' >> >> Reported-by: Hulk Robot <hulkci@huawei.com> >> Signed-off-by: YueHaibing <yuehaibing@huawei.com> >> --- > > . >
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c index cc4383d..b1595b1 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c @@ -2824,7 +2824,6 @@ vchiq_release_internal(struct vchiq_state *state, struct vchiq_service *service) VCHIQ_STATUS_T ret = VCHIQ_SUCCESS; char entity[16]; int *entity_uc; - int local_uc, local_entity_uc; if (!arm_state) goto out; @@ -2849,8 +2848,8 @@ vchiq_release_internal(struct vchiq_state *state, struct vchiq_service *service) ret = VCHIQ_ERROR; goto unlock; } - local_uc = --arm_state->videocore_use_count; - local_entity_uc = --(*entity_uc); + --arm_state->videocore_use_count; + --(*entity_uc); if (!vchiq_videocore_wanted(state)) { if (vchiq_platform_use_suspend_timer() &&
Fix gcc used-but-set-variable warning: drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c: In function vchiq_release_internal: drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:2827:16: warning: variable local_entity_uc set but not used [-Wunused-but-set-variable] drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:2827:6: warning: variable local_uc set but not used [-Wunused-but-set-variable] Remove the unused variables 'local_entity_uc' and 'local_uc' Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- v2: remove the unused variable --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)