From patchwork Mon Jul 29 15:21:30 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Code Kipper X-Patchwork-Id: 11064023 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4B22B912 for ; Mon, 29 Jul 2019 15:21:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 351A927F10 for ; Mon, 29 Jul 2019 15:21:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 260A12864E; Mon, 29 Jul 2019 15:21:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id CE67E27F10 for ; Mon, 29 Jul 2019 15:21:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=RYaSDHpFvnsxheT+d3REQUvTZTw9bSgLN++qpfsPUg0=; b=g08/SiuNJ8+BQd bASzgkr4lPQxJr/pWZl8o0jPjitaEeJ/1CbWv8besUDT9gZp4aebjjZlGnB2zACkh6W1fdcbMv8ZO 2om03ls7qyPxhf1S7jG1N5Tbc6hfNGHFcKbMIU2ncIIV2m4yK0H1kKtMXUNOxJsS6h131YoyIfW+s x8tJ5AD7WDZQYFn9Ot2A4KKJeCztNGfbk6nIGYGcP7fAoCtEMslJAuRqy0nIFgO9JSBAVGJU4PrWJ I2LGnsR73tWZBoXWyFMUAObBLFaN0jYSEWaVdnPyQeCIGPMFrJCnl1AS9XT1mDHMK/s3fzvPy9C3W SOucnMnEsh/u/fQYODjg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hs7Sz-0002xQ-8s; Mon, 29 Jul 2019 15:21:37 +0000 Received: from mail-lj1-x244.google.com ([2a00:1450:4864:20::244]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hs7Sw-0002wW-8A for linux-arm-kernel@lists.infradead.org; Mon, 29 Jul 2019 15:21:35 +0000 Received: by mail-lj1-x244.google.com with SMTP id m8so25379019lji.7 for ; Mon, 29 Jul 2019 08:21:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=PZSxc/hO0ZG18S/DOTA+r5gDlzN8/M+y4psJHtepWPo=; b=KRdDo7paGeKGOyp5Sp8o+S0wp9+qaiFYwmskrcsOpqOHQ0VKiKurLc4bRIfnDNC8VJ I/k30lJ8g/j8ifMq+tuZBWKGQe3XY64SgjXQHpplkw2GVsWFP646SlCIDyPZYtMmSN/2 Pskr3sNko8K0TTzGa2sgzm9V+xiK8Yjqpbie8WqVShZx9pUZ+BzVmhIzW6WvyGQgh1kC v6UY+s/8uCFvxx2UfjCDIZsXHmDV6x9yKx0JpMeur3epVhHm7LH0fam98RHl2eI9Swlu j0WZC6yPsyqB3+dDlK8v6s+Vt67lagm6o7xNlg6XyjkyQVmxa1GH9t8XVGBPrZXpsgHU fH/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=PZSxc/hO0ZG18S/DOTA+r5gDlzN8/M+y4psJHtepWPo=; b=qE7uNprgfIX8BXk+mutSO8b9eIB+qGa4UvVTGz3tHUnRl9T6E7idvrpku4HvQJQ3gg BqHOuNjwV6kpsS5dAk4X6TTCjgAvzGYlSBdTzdFJhsD9qbBx1o0t0SI8blWXVxE4wyFf g81gxSjJH1Ae55kLVRWx6AphfhBqrGqWMNs9BgyL3M9YVXBl2wOmBJi2WBAKEGrx9XFW lBPNv2kjayuetKgZamh3HaYJ3x5Au5ZjMqGhoy00P+tkjg9slHhPxtj10kXFFQcVdebT cLSgjpU6vB97Codly0jHYOPvB6vqTXpWFqfU/QlNc9+rObejeZEqABPnsmcM6Axrk2bv stUA== X-Gm-Message-State: APjAAAV4ATbWngD3TfvubXU11fZ79r7qwR3422puPikViegT/EpYpfmh cCRqvAJbTemG+gPvut7pxKU= X-Google-Smtp-Source: APXvYqy+4rx7le3o3En30ctJLBZYf+QGog310rctsNf7/vRm5Y7TokVJe6f2rAPQLbeYocwgHRElcA== X-Received: by 2002:a2e:9188:: with SMTP id f8mr12769716ljg.33.1564413692232; Mon, 29 Jul 2019 08:21:32 -0700 (PDT) Received: from localhost.localdomain (c213-102-74-69.bredband.comhem.se. [213.102.74.69]) by smtp.gmail.com with ESMTPSA id f16sm11887474lfc.81.2019.07.29.08.21.31 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 29 Jul 2019 08:21:31 -0700 (PDT) From: codekipper@gmail.com To: maxime.ripard@free-electrons.com, wens@csie.org, linux-sunxi@googlegroups.com Subject: [PATCH] ASoC: sun4i-i2s: Incorrect SR and WSS computation Date: Mon, 29 Jul 2019 17:21:30 +0200 Message-Id: <20190729152130.27955-1-codekipper@gmail.com> X-Mailer: git-send-email 2.22.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190729_082134_293686_B4602ECF X-CRM114-Status: GOOD ( 11.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marcus Cooper , broonie@kernel.org, lgirdwood@gmail.com, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP From: Marcus Cooper The A64 audio codec uses the original I2S block but the SR and WSS computation currently assigned is for the newer block. Fixes: 619c15f7fac9 (ASoC: sun4i-i2s: Change SR and WSS computation) Signed-off-by: Marcus Cooper Acked-by: Maxime Ripard Reviewed-by: Vasily Khoruzhick --- sound/soc/sunxi/sun4i-i2s.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c index 9b2232908b65..7fa5c61169db 100644 --- a/sound/soc/sunxi/sun4i-i2s.c +++ b/sound/soc/sunxi/sun4i-i2s.c @@ -1002,8 +1002,8 @@ static const struct sun4i_i2s_quirks sun50i_a64_codec_i2s_quirks = { .field_rxchanmap = REG_FIELD(SUN4I_I2S_RX_CHAN_MAP_REG, 0, 31), .field_txchansel = REG_FIELD(SUN4I_I2S_TX_CHAN_SEL_REG, 0, 2), .field_rxchansel = REG_FIELD(SUN4I_I2S_RX_CHAN_SEL_REG, 0, 2), - .get_sr = sun8i_i2s_get_sr_wss, - .get_wss = sun8i_i2s_get_sr_wss, + .get_sr = sun4i_i2s_get_sr, + .get_wss = sun4i_i2s_get_wss, }; static int sun4i_i2s_init_regmap_fields(struct device *dev,