| Message ID | 20190730150552.24927-1-lukma@denx.de (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | a5580eb394c8a48afc3e64aaad68db0d44662cc6 |
| Headers | show |
| Series | ARM: DTS: vybrid: Update qspi node description for VF610 BK4 board | expand |
Hi Lukasz, Subject line could be improved: ARM: dts: vf610-bk4: Fix qspi node description On Tue, Jul 30, 2019 at 12:06 PM Lukasz Majewski <lukma@denx.de> wrote: > > Before this change the device tree description of qspi node for > second memory on BK4 board was wrong (applicable to old, in-house > tunned fsl-quadspi.c driver). > > As a result this memory was not recognized correctly when used > with the new spi-fsl-qspi.c driver. > > From the dt-bindings: > > "Required SPI slave node properties: > - reg: There are two buses (A and B) with two chip selects each. > This encodes to which bus and CS the flash is connected: > <0>: Bus A, CS 0 > <1>: Bus A, CS 1 > <2>: Bus B, CS 0 > <3>: Bus B, CS 1" > > According to above with new driver the second SPI-NOR memory shall > have reg=<2> as it is connected to Bus B, CS 0. I am glad you got it working! This looks very familiar with the suggestion I sent yesterday: http://lists.infradead.org/pipermail/linux-mtd/2019-July/090655.html It is a good practice to give some credit to someone who has helped in finding the solution of your problem. Adding a Suggested-by: Fabio Estevam <festevam@gmail.com> would be nice here. This also needs a Fixes tag.
Hi Fabio, > Hi Lukasz, > > Subject line could be improved: > > ARM: dts: vf610-bk4: Fix qspi node description > > On Tue, Jul 30, 2019 at 12:06 PM Lukasz Majewski <lukma@denx.de> > wrote: > > > > Before this change the device tree description of qspi node for > > second memory on BK4 board was wrong (applicable to old, in-house > > tunned fsl-quadspi.c driver). > > > > As a result this memory was not recognized correctly when used > > with the new spi-fsl-qspi.c driver. > > > > From the dt-bindings: > > > > "Required SPI slave node properties: > > - reg: There are two buses (A and B) with two chip selects each. > > This encodes to which bus and CS the flash is connected: > > <0>: Bus A, CS 0 > > <1>: Bus A, CS 1 > > <2>: Bus B, CS 0 > > <3>: Bus B, CS 1" > > > > According to above with new driver the second SPI-NOR memory shall > > have reg=<2> as it is connected to Bus B, CS 0. > > I am glad you got it working! > > This looks very familiar with the suggestion I sent yesterday: > http://lists.infradead.org/pipermail/linux-mtd/2019-July/090655.html > Yes, indeed. Deepest apologizes for not adding credits. I will fix it in v2. > It is a good practice to give some credit to someone who has helped in > finding the solution of your problem. > > Adding a Suggested-by: Fabio Estevam <festevam@gmail.com> would be > nice here. > > This also needs a Fixes tag. Shall I refer to the original commit (which added this DTS)? Or the original issue posted to linux-mtd [1] ? Note: [1] - https://www.spinics.net/lists/linux-mtd/msg08114.html Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
Hi Lukasz, On Tue, Jul 30, 2019 at 12:53 PM Lukasz Majewski <lukma@denx.de> wrote: > Shall I refer to the original commit (which added this DTS)? Or the > original issue posted to linux-mtd [1] ? You can add a Fixes tag like this: Fixes: a67d2c52a82f ("ARM: dts: Add support for Liebherr's BK4 device (vf610 based)")
Hi Fabio, > Hi Lukasz, > > On Tue, Jul 30, 2019 at 12:53 PM Lukasz Majewski <lukma@denx.de> > wrote: > > > Shall I refer to the original commit (which added this DTS)? Or the > > original issue posted to linux-mtd [1] ? > > You can add a Fixes tag like this: > > Fixes: a67d2c52a82f ("ARM: dts: Add support for Liebherr's BK4 device > (vf610 based)") Yes, the above is correct (as indicated [1]), but I was not sure if I should also refer to the original post to linux-mtd ML. Now it is clear - thanks :-) Note: [1] - https://www.kernel.org/doc/html/v4.12/process/submitting-patches.html#reviewer-s-statement-of-oversight Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
diff --git a/arch/arm/boot/dts/vf610-bk4.dts b/arch/arm/boot/dts/vf610-bk4.dts index 3fa0cbe456db..0f3870d3b099 100644 --- a/arch/arm/boot/dts/vf610-bk4.dts +++ b/arch/arm/boot/dts/vf610-bk4.dts @@ -246,13 +246,13 @@ reg = <0>; }; - n25q128a13_2: flash@1 { + n25q128a13_2: flash@2 { compatible = "n25q128a13", "jedec,spi-nor"; #address-cells = <1>; #size-cells = <1>; spi-max-frequency = <66000000>; spi-rx-bus-width = <2>; - reg = <1>; + reg = <2>; }; };
Before this change the device tree description of qspi node for second memory on BK4 board was wrong (applicable to old, in-house tunned fsl-quadspi.c driver). As a result this memory was not recognized correctly when used with the new spi-fsl-qspi.c driver. From the dt-bindings: "Required SPI slave node properties: - reg: There are two buses (A and B) with two chip selects each. This encodes to which bus and CS the flash is connected: <0>: Bus A, CS 0 <1>: Bus A, CS 1 <2>: Bus B, CS 0 <3>: Bus B, CS 1" According to above with new driver the second SPI-NOR memory shall have reg=<2> as it is connected to Bus B, CS 0. Signed-off-by: Lukasz Majewski <lukma@denx.de> --- arch/arm/boot/dts/vf610-bk4.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)