| Message ID | 20190731222439.15704-1-uwe@kleine-koenig.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ARM: at91/dt: pinctrl: add helper define for MULTI_DRIVE + PULL_UP | expand |
On Thu, Aug 01, 2019 at 12:24:39AM +0200, Uwe Kleine-König wrote: > > Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org> > --- > > On Thu, Aug 01, 2019 at 12:14:48AM +0200, Uwe Kleine-König wrote: > > The define I added in include/dt-bindings/pinctrl/at91.h would be nice > > to have though to simplify overriding the SoC's default pinctrl. Would > > it be OK to add this? > > something like this ... > Nice, easier for the user. > The name is a bit inconsistent compared to > AT91_PINCTRL_PULL_UP_DEGLITCH, but on the pro side it is shorter. > Assuming you like this, what is your naming preference? I advocate consistency in this case. Regards Ludovic > > Best regards > Uwe > > include/dt-bindings/pinctrl/at91.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/dt-bindings/pinctrl/at91.h b/include/dt-bindings/pinctrl/at91.h > index 3831f91fb3ba..b8bb55a935f6 100644 > --- a/include/dt-bindings/pinctrl/at91.h > +++ b/include/dt-bindings/pinctrl/at91.h > @@ -21,6 +21,7 @@ > #define AT91_PINCTRL_DEBOUNCE_VAL(x) (x << 17) > > #define AT91_PINCTRL_PULL_UP_DEGLITCH (AT91_PINCTRL_PULL_UP | AT91_PINCTRL_DEGLITCH) > +#define AT91_PINCTRL_MULTI_DRIVE_PU (AT91_PINCTRL_MULTI_DRIVE | AT91_PINCTRL_PULL_UP) > > #define AT91_PINCTRL_DRIVE_STRENGTH_DEFAULT (0x0 << 5) > #define AT91_PINCTRL_DRIVE_STRENGTH_LOW (0x1 << 5) > -- > 2.20.1 >
diff --git a/include/dt-bindings/pinctrl/at91.h b/include/dt-bindings/pinctrl/at91.h index 3831f91fb3ba..b8bb55a935f6 100644 --- a/include/dt-bindings/pinctrl/at91.h +++ b/include/dt-bindings/pinctrl/at91.h @@ -21,6 +21,7 @@ #define AT91_PINCTRL_DEBOUNCE_VAL(x) (x << 17) #define AT91_PINCTRL_PULL_UP_DEGLITCH (AT91_PINCTRL_PULL_UP | AT91_PINCTRL_DEGLITCH) +#define AT91_PINCTRL_MULTI_DRIVE_PU (AT91_PINCTRL_MULTI_DRIVE | AT91_PINCTRL_PULL_UP) #define AT91_PINCTRL_DRIVE_STRENGTH_DEFAULT (0x0 << 5) #define AT91_PINCTRL_DRIVE_STRENGTH_LOW (0x1 << 5)