| Message ID | 20190814142918.11636-12-narmstrong@baylibre.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: meson: fixes following YAML bindings schemas conversion | expand |
On Wed, Aug 14, 2019 at 4:33 PM Neil Armstrong <narmstrong@baylibre.com> wrote: > > This fixes the following DT schemas check errors: > meson-g12a-x96-max.dt.yaml: /: compatible: ['amediatech,x96-max', 'amlogic,u200', 'amlogic,g12a'] is not valid under any of the given schemas > > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> [...] > - compatible = "amediatech,x96-max", "amlogic,u200", "amlogic,g12a"; > + compatible = "amediatech,x96-max", "amlogic,g12a"; only partially related: I wonder if we should add a s905x2 compatible string here and to the .dts filename (just like we separate the GXL variants s905x, s905d, s905w, ...)
On 20/08/2019 22:32, Martin Blumenstingl wrote: > On Wed, Aug 14, 2019 at 4:33 PM Neil Armstrong <narmstrong@baylibre.com> wrote: >> >> This fixes the following DT schemas check errors: >> meson-g12a-x96-max.dt.yaml: /: compatible: ['amediatech,x96-max', 'amlogic,u200', 'amlogic,g12a'] is not valid under any of the given schemas >> >> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> > Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > > [...] >> - compatible = "amediatech,x96-max", "amlogic,u200", "amlogic,g12a"; >> + compatible = "amediatech,x96-max", "amlogic,g12a"; > only partially related: I wonder if we should add a s905x2 compatible > string here and to the .dts filename (just like we separate the GXL > variants s905x, s905d, s905w, ...) > We could, but AFAIK no variants of G12A are planned yet... Neil
On Wed, Aug 21, 2019 at 4:08 PM Neil Armstrong <narmstrong@baylibre.com> wrote: > > On 20/08/2019 22:32, Martin Blumenstingl wrote: > > On Wed, Aug 14, 2019 at 4:33 PM Neil Armstrong <narmstrong@baylibre.com> wrote: > >> > >> This fixes the following DT schemas check errors: > >> meson-g12a-x96-max.dt.yaml: /: compatible: ['amediatech,x96-max', 'amlogic,u200', 'amlogic,g12a'] is not valid under any of the given schemas > >> > >> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> > > Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > > > > [...] > >> - compatible = "amediatech,x96-max", "amlogic,u200", "amlogic,g12a"; > >> + compatible = "amediatech,x96-max", "amlogic,g12a"; > > only partially related: I wonder if we should add a s905x2 compatible > > string here and to the .dts filename (just like we separate the GXL > > variants s905x, s905d, s905w, ...) > > > > We could, but AFAIK no variants of G12A are planned yet... we already support two variants: S905X2 and S905D2 (I'm assuming that these are similar to S905X and S905D meaning both are almost identical) but I guess we can stay with what we have until there's a reason to have separate compatible strings (for example if we discover that there is a difference that matters - like the OPP table on S922X vs A311D)
diff --git a/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts b/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts index fe4013cca876..acb931cf3e7c 100644 --- a/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts +++ b/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts @@ -11,7 +11,7 @@ #include <dt-bindings/sound/meson-g12a-tohdmitx.h> / { - compatible = "amediatech,x96-max", "amlogic,u200", "amlogic,g12a"; + compatible = "amediatech,x96-max", "amlogic,g12a"; model = "Shenzhen Amediatech Technology Co., Ltd X96 Max"; aliases {
This fixes the following DT schemas check errors: meson-g12a-x96-max.dt.yaml: /: compatible: ['amediatech,x96-max', 'amlogic,u200', 'amlogic,g12a'] is not valid under any of the given schemas Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> --- arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)