@@ -528,16 +528,19 @@ static int dwc3_qcom_of_register_core(struct platform_device *pdev)
ret = of_platform_populate(np, NULL, NULL, dev);
if (ret) {
dev_err(dev, "failed to register dwc3 core - %d\n", ret);
- return ret;
+ goto err_node_put;
}
qcom->dwc3 = of_find_device_by_node(dwc3_np);
if (!qcom->dwc3) {
dev_err(dev, "failed to get dwc3 platform device\n");
- return -ENODEV;
+ ret = -ENODEV;
+ goto err_node_put;
}
- return 0;
+err_node_put:
+ of_node_put(dwc3_np);
+ return ret;
}
static const struct dwc3_acpi_pdata sdm845_acpi_pdata = {
The variable dwc3_np in the function dwc3_qcom_of_register_core takes the value returned by of_get_child_by_name, which gets a node but does not put it. This may cause a memory leak. Hence create a new label, err_node_put, that puts dwc3_np and returns the required value, and modify two return statements to instead save the required return value in existing variable ret and then point to this label. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com> --- drivers/usb/dwc3/dwc3-qcom.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)