From patchwork Fri Aug 23 11:07:36 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Anders Roxell X-Patchwork-Id: 11111473 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B8FD1112C for ; Fri, 23 Aug 2019 11:07:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 959BD2166E for ; Fri, 23 Aug 2019 11:07:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AGUPfDay"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cPSKEtJO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 959BD2166E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=p5UEghnqHDeNxbNnTTXO401ux9dsR2crz0QGL8vwQa8=; b=AGUPfDayPzLs2W XJmx72gWzNDvdgVThZKkwsOPnsDm0W6UpejASo3tqDG42HW2CutReRAMZuH6aAH8yi1G1aFleDLmK eapERu4K/DGuuB/dkOBl5PUbaQzChWRwyfe9lW7UV9eR1XjvdeK2d28ey9ziuekDrl2kKoUfpSsC6 VZAyle6VuknCWI91LIqVhC36S9k2Of0lvh4B47Hw0vVsfcHFlffxxO09lMw/IjD+U0FFqD4AEqBAa WEeNPZUsLBunwwUsup3/niK02sdc0X6VlxFle4IfldMzpMN8s48ezKTgdyKh1U3p3jCM8I3QHsnrg ODbaTPU4JaRB7lN92p2g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i17QC-00069d-PM; Fri, 23 Aug 2019 11:07:56 +0000 Received: from mail-lf1-x141.google.com ([2a00:1450:4864:20::141]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i17Q9-00068R-NB for linux-arm-kernel@lists.infradead.org; Fri, 23 Aug 2019 11:07:55 +0000 Received: by mail-lf1-x141.google.com with SMTP id b17so6851546lff.7 for ; Fri, 23 Aug 2019 04:07:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ZHcoLOCEDvNdiKJSIaGU9TMbH+mXTX9zteaN4YnDK00=; b=cPSKEtJOjYq9WsIijVXnZyKIbicP5PMiaPAcAAyh8mxF2fDAkuuFN3FcjHGy6xOiA8 dg3q+8r842lRJFe52waZ1pWOP1wKwsDLDgKLqIpRczfz3K1GCezlxU2eAw9eIZbMKxrf mrn4ekEkBMNN05Alm52osCbJSaG9T3p08S1uk/Etvu7P/iU5q1BQZIwSb0LvUTNiRtvb cYFDDf3S1vHAgguA6kMPY4lnFgRTA7hrkOSRgVLfAkUQYbXFTy9PUohmSf4W+STJYWLK 3ZPZzlh8ATubZ3jKVG+Q0Xc8NiATpTsN2VCfjDHzuS4R6vwvK+BZ87tC4ou5Z6faQS3u BXhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ZHcoLOCEDvNdiKJSIaGU9TMbH+mXTX9zteaN4YnDK00=; b=h/kQ35RITzIocZ72ABOA2TAXdjwJVfvul713pzeJijVJ6yP8RACLvje5XophgVazg1 317UXcFLyn2Z4MtVWfuO0faVguLOkoB7KXDLwvZmHA1W2QLaQUdY030m4QsXdBLNoXKk y5NDmU5FWRC/4Q2DmoUGAgRAYIrOzh5WCIII333N07f6zZ+K/LBMHbNkifh6XfQg9pUV bbMJyI41BNmXxoWw43XlU80JoMjVF5Sj/Zb3kjKRIVhU3gII0vL9xJBTudZkIH86ybGE x6cCv01Qz7WLAHtFkDzQedPuWC1RUP4fEsDOaTkRROZ5ext9Utk3Qp55NTTkBkB6/9qt dD+g== X-Gm-Message-State: APjAAAVcJweeHHLP8mbm465mQmjvdzwwao9WvJMAZ3cRd12RfOWpvZ4f slva2wyZXRdAb626XjmjvKlKjg== X-Google-Smtp-Source: APXvYqzi3fwiyJBZWIDhJNnGDLtbqn6NPY5vwE/i10iohempQV8GMBpKT39wg3/8zN79Mnf6fd6bZA== X-Received: by 2002:a19:2314:: with SMTP id j20mr1185222lfj.22.1566558471447; Fri, 23 Aug 2019 04:07:51 -0700 (PDT) Received: from localhost (c-243c70d5.07-21-73746f28.bbcust.telenor.se. [213.112.60.36]) by smtp.gmail.com with ESMTPSA id r23sm596312ljm.59.2019.08.23.04.07.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Aug 2019 04:07:50 -0700 (PDT) From: Anders Roxell To: ck.hu@mediatek.com, p.zabel@pengutronix.de, airlied@linux.ie, daniel@ffwll.ch, matthias.bgg@gmail.com Subject: [PATCH] drm/mediatek: fix implicit function declaration Date: Fri, 23 Aug 2019 13:07:36 +0200 Message-Id: <20190823110736.26117-1-anders.roxell@linaro.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190823_040753_769553_F80CC54F X-CRM114-Status: UNSURE ( 9.09 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:141 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Anders Roxell , linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org When building mtk_drm_drv.o the following build error is seen: ../drivers/gpu/drm/mediatek/mtk_drm_drv.c: In function ‘mtk_drm_kms_init’: ../drivers/gpu/drm/mediatek/mtk_drm_drv.c:291:8: error: implicit declaration of function ‘dma_set_max_seg_size’; did you mean ‘drm_rect_adjust_size’? [-Werror=implicit-function-declaration] ret = dma_set_max_seg_size(dma_dev, (unsigned int)DMA_BIT_MASK(32)); ^~~~~~~~~~~~~~~~~~~~ drm_rect_adjust_size ../drivers/gpu/drm/mediatek/mtk_drm_drv.c:291:52: error: implicit declaration of function ‘DMA_BIT_MASK’; did you mean ‘BIT_MASK’? [-Werror=implicit-function-declaration] ret = dma_set_max_seg_size(dma_dev, (unsigned int)DMA_BIT_MASK(32)); ^~~~~~~~~~~~ BIT_MASK Rework to add a missing include file 'linux/dma-mapping.h', because that is the (only) header file containing that declaration. Fixes: 070955558e82 ("drm/mediatek: set DMA max segment size") Signed-off-by: Anders Roxell --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c index 54536176bcbb..352b81a7a670 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c @@ -10,6 +10,7 @@ #include #include #include +#include #include #include