diff mbox series

[3/3] USB: host: ohci-at91: resume: balance the clock start call

Message ID 20190911064154.28633-4-nicolas.ferre@microchip.com (mailing list archive)
State Mainlined
Commit 87e8dfa6f7ebdb3e2802a606bda44d26054f92a8
Headers show
Series USB: host: ohci-at91: tailor power consumption | expand

Commit Message

Nicolas Ferre Sept. 11, 2019, 6:41 a.m. UTC
From: Boris Krasnovskiy <Boris.Krasnovskiy@lairdconnect.com>

There is a clock enable counter run away problem in resume ohci_at91. Code
enables clock that was never disabled in case of non wakeup interface. That
would make clock unstoppable in future.
Use proper alternative to start clocks only if they were stopped before.

Signed-off-by: Boris Krasnovskiy <Boris.Krasnovskiy@lairdconnect.com>
Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com>
 drivers/usb/host/ohci-at91.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff mbox series


diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91.c
index 85d67fe42d59..513e48397743 100644
--- a/drivers/usb/host/ohci-at91.c
+++ b/drivers/usb/host/ohci-at91.c
@@ -643,8 +643,8 @@  ohci_hcd_at91_drv_resume(struct device *dev)
 	if (ohci_at91->wakeup)
-	at91_start_clock(ohci_at91);
+	else
+		at91_start_clock(ohci_at91);
 	ohci_resume(hcd, false);