From patchwork Tue Sep 24 07:46:44 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 11158185 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0B11613B1 for ; Tue, 24 Sep 2019 07:58:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DBA26207FD for ; Tue, 24 Sep 2019 07:58:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="iNa6oQeq"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=microchiptechnology.onmicrosoft.com header.i=@microchiptechnology.onmicrosoft.com header.b="RDD3Hgm7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DBA26207FD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ibgkg+KS1+u0+pjt2hKj8TiCcxE1Xl8luOHKHIzcxsg=; b=iNa6oQeqc2pVB1 Eq5t+s4xmcTLv1xfVh9hP/1h5naX0YRtPdi7kBiSTcYPMIFxNJMVfzES7rXyOBm7614ai0k+VFTU3 4PNr719zGibjQdd0Mvl+jspXlcSK0P37ZiJFPNGuJeUDdllpHBUO2S1zU0Vnj+i5zQQzjHOtE9W6K R3nhtrp0MXqh8uRvNMo01AJWAuCOXsSKCVGAqvOVeTNmMXIfPdZVWHEkaeQc+Y2jdlbydX0U4fn8Y 7cWgUHGCT5JHf/myOtsuc71xX2XGK/ybg3mVvH5i5QMGeZJjxDLRobjG5i1Rz2AEU5hgho5mdrvgX QTv7FzyeyIUHy4/MrBSQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iCfiJ-0007Qm-DL; Tue, 24 Sep 2019 07:58:23 +0000 Received: from esa4.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iCfX6-0004HC-Oa; Tue, 24 Sep 2019 07:46:52 +0000 Received-SPF: Pass (esa4.microchip.iphmx.com: domain of Tudor.Ambarus@microchip.com designates 198.175.253.82 as permitted sender) identity=mailfrom; client-ip=198.175.253.82; receiver=esa4.microchip.iphmx.com; envelope-from="Tudor.Ambarus@microchip.com"; x-sender="Tudor.Ambarus@microchip.com"; x-conformance=spf_only; x-record-type="v=spf1"; x-record-text="v=spf1 mx a:ushub1.microchip.com a:smtpout.microchip.com a:mx1.microchip.iphmx.com a:mx2.microchip.iphmx.com include:servers.mcsv.net include:mktomail.com include:spf.protection.outlook.com ~all" Received-SPF: None (esa4.microchip.iphmx.com: no sender authenticity information available from domain of postmaster@email.microchip.com) identity=helo; client-ip=198.175.253.82; receiver=esa4.microchip.iphmx.com; envelope-from="Tudor.Ambarus@microchip.com"; x-sender="postmaster@email.microchip.com"; x-conformance=spf_only Authentication-Results: esa4.microchip.iphmx.com; spf=Pass smtp.mailfrom=Tudor.Ambarus@microchip.com; spf=None smtp.helo=postmaster@email.microchip.com; dkim=pass (signature verified) header.i=@microchiptechnology.onmicrosoft.com; dmarc=pass (p=none dis=none) d=microchip.com IronPort-SDR: bdjAl3UPD8OsWsGvbIErvqPj3UQKN2Jut3auqZp65CBKSm+Fap7oWb61Qy4JJb5HuONVJLwbkG 3+rjErLb7J8/DIjwnqkMlOQrzG15N5RYWXXOZ8AlbyYtbdyGa4mI1x5p0JPVIKKYFbga2dnsm4 DjASstyw72ILSkJqtiGTGB0rd8hNoF00LjBcSquzCOuWpJosDXDbvht8nd/F+pSiiB+DVLDpl4 gLFIP5nXxMuDAUq6G9Xj59ZyQpysFcTO4oBS5Cp0MlXFhNyUND9/vARR8TrPER3j/7xP48s3qi HLY= X-IronPort-AV: E=Sophos;i="5.64,543,1559545200"; d="scan'208";a="49066195" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa4.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 24 Sep 2019 00:46:48 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.85.144) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 24 Sep 2019 00:46:46 -0700 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 24 Sep 2019 00:46:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cOqMBTbbekoHXm7GjWJ+FTwLtiqEqMZDJxFdHY1/ErcYs1NmjuC0XUAXMNmMmQ++h3vd5zI/9S5NFit8Z5gZIx8B55ERojtu31VweAI1D/QwA3M1pHSpBO+b0asv4L4coZcljoOylBPzaStr7QdzaaR+PBdJAA2eTm4L31GYe6kthHSBapeKCfKNGAdmhGgM7THuG85Y+Z2A1tnOT5FdPcFY0p7nl4kOQDBGZ82QLno/4nb5OZ9apZzlqhKXax7/12q9JHXlZWVQyQafCj3TeBsI77eoUGjypq/8y9/i4fmjTw5dJnYw25ArR/xl1OcpAnwpjmLDxf/BrFjtsNyUCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3/JQqCwKWHa+thZi6BbGu87sx9883Lw02e8xwZUj3VU=; b=fpPZmB2OrwXCj8mYH+kgaptbCtCo6878Mjii/gYxCDab/dxBnHGEJ7Oiz8k7J/J2ruZL74idOaBbRJWGLLnfiRt8AtiItL0bB/LantlSa6Rdjg2O2ljks2u3moQ37Geu9Xma5SkLEKp3nD3Sb7VfIQLfocU7FhfEPwhYaqnqnFzynEREnO5CeVDHsgQzU+cswBhZgZuJ9NnDLuQNzO9uNzDmlHBvoXswPjbKsFR2oBX9FgXJ3wW/KqYOYayBzVeemMkrKUWl61IU3uX/yI7JCpLHGq2Nu15WLn75nEyoIcqAk22F6OGNy95IKkeHsBlEScL9MfnlHTHhVeok+Lq37Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3/JQqCwKWHa+thZi6BbGu87sx9883Lw02e8xwZUj3VU=; b=RDD3Hgm7CMGrsnkGIn7QjReGPwkL6O5RO2B7vmYeXqB1LYf8eIUAKtudAiAR/J0qD/jpGCcAk7RobpXOREWeyNhR0I347IBjGxI8qQI8Qt2RzjAFldgq8WGQWubPB2UmA8sobvkX8qZWbxWyaJxColWRMtx8lqVUFdBT5BukuyQ= Received: from MN2PR11MB4448.namprd11.prod.outlook.com (52.135.39.157) by MN2PR11MB4319.namprd11.prod.outlook.com (52.135.39.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2284.26; Tue, 24 Sep 2019 07:46:44 +0000 Received: from MN2PR11MB4448.namprd11.prod.outlook.com ([fe80::c951:b15a:e4b3:30f7]) by MN2PR11MB4448.namprd11.prod.outlook.com ([fe80::c951:b15a:e4b3:30f7%7]) with mapi id 15.20.2284.023; Tue, 24 Sep 2019 07:46:44 +0000 From: To: , , , , , Subject: [PATCH v2 16/22] mtd: spi-nor: Fix errno on quad_enable methods Thread-Topic: [PATCH v2 16/22] mtd: spi-nor: Fix errno on quad_enable methods Thread-Index: AQHVcqw22gGmk60ca0uOGGwWABc8zA== Date: Tue, 24 Sep 2019 07:46:44 +0000 Message-ID: <20190924074533.6618-17-tudor.ambarus@microchip.com> References: <20190924074533.6618-1-tudor.ambarus@microchip.com> In-Reply-To: <20190924074533.6618-1-tudor.ambarus@microchip.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: VI1PR0101CA0082.eurprd01.prod.exchangelabs.com (2603:10a6:800:1f::50) To MN2PR11MB4448.namprd11.prod.outlook.com (2603:10b6:208:193::29) x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.9.5 x-originating-ip: [94.177.32.156] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f65d399c-0f4b-4457-022b-08d740c3586a x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600167)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:MN2PR11MB4319; x-ms-traffictypediagnostic: MN2PR11MB4319: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2000; x-forefront-prvs: 0170DAF08C x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(1496009)(366004)(396003)(136003)(346002)(39860400002)(376002)(189003)(199004)(5660300002)(2201001)(6436002)(256004)(86362001)(11346002)(14454004)(476003)(2501003)(305945005)(186003)(2616005)(26005)(386003)(102836004)(6506007)(25786009)(6486002)(8936002)(81156014)(2906002)(3846002)(81166006)(107886003)(7736002)(8676002)(6512007)(486006)(36756003)(52116002)(71200400001)(71190400001)(50226002)(446003)(66446008)(76176011)(99286004)(66946007)(4326008)(66476007)(64756008)(66556008)(6116002)(54906003)(110136005)(66066001)(316002)(1076003)(7416002)(478600001); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR11MB4319; H:MN2PR11MB4448.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: microchip.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: TJo3zOHxezPKwmKSa06kWfh6ul1mfNkCq8ztipZRj7syO2SLx/V4JfXLXoxX45ALOiq2ern1hsc5zKqUMREDeg2thLQvqKElXufXOhBSH5TJ2zsQvBr6cJJzC/iv3DuP7rvBgVWTCimLN3wd1yM7cGiAdv9aRSYXmLFmZAlAoKnsTFqztmAc/hyBQrSIso578TNTac13P0oysBFKqezL8SUtCbBGWZJl8wgdoIAgopRQran8qYFbmmzbTjAC2sR9QaOnmJJKQpsBCFTbYZzx8ZNJUgE8rqB1MbAyU1spKGrCX0A+azVS2UaAbvXeJwlu72I+mRqIzg9r8kJGmA52BsT9L3rHUO40KWiR4rIHlerjESkdNcc/y6VM1NshGPx6yAXam3SkqEt3ALaB/Yq/Cnqj0GnG2ElSwN/7CHnVCHw= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: f65d399c-0f4b-4457-022b-08d740c3586a X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Sep 2019 07:46:44.4815 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ScJrBNdNnjzIXvp/8TkYL9dRgeh2xsR4bw18mqVtTv6Ywm9lfMl8xy4P/sT90f66mvjNllZjf4wyweDLzyNgdUEOYLgRMzfQbTkfy56/9NU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4319 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190924_004649_000764_228CB063 X-CRM114-Status: GOOD ( 10.25 ) X-Spam-Score: -2.3 (--) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-2.3 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [68.232.154.123 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-aspeed@lists.ozlabs.org, Tudor.Ambarus@microchip.com, andrew@aj.id.au, richard@nod.at, linux-kernel@vger.kernel.org, vz@mleia.com, linux-mediatek@lists.infradead.org, joel@jms.id.au, miquel.raynal@bootlin.com, matthias.bgg@gmail.com, computersforpeace@gmail.com, dwmw2@infradead.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org From: Tudor Ambarus When the Read-Modify-Write-Read-Back Quad Enable methods failed on the Read-Back, they returned -EINVAL. Since this is an I/O error, return -EIO. Signed-off-by: Tudor Ambarus --- drivers/mtd/spi-nor/spi-nor.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c index 668afa9a8c87..6429c855547e 100644 --- a/drivers/mtd/spi-nor/spi-nor.c +++ b/drivers/mtd/spi-nor/spi-nor.c @@ -1862,7 +1862,7 @@ static int macronix_quad_enable(struct spi_nor *nor) if (!(nor->bouncebuf[0] & SR_QUAD_EN_MX)) { dev_err(nor->dev, "Macronix Quad bit not set\n"); - return -EINVAL; + return -EIO; } return 0; @@ -1940,7 +1940,7 @@ static int spansion_read_cr_quad_enable(struct spi_nor *nor) if (!(sr_cr[1] & CR_QUAD_EN_SPAN)) { dev_err(nor->dev, "Spansion Quad bit not set\n"); - return -EINVAL; + return -EIO; } return 0; @@ -1985,7 +1985,7 @@ static int sr2_bit7_quad_enable(struct spi_nor *nor) if (!(*sr2 & SR2_QUAD_EN_BIT7)) { dev_err(nor->dev, "SR2 Quad bit not set\n"); - return -EINVAL; + return -EIO; } return 0;