| Message ID | 20191003064527.15128-5-jagan@amarulasolutions.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/sun4i: dsi: Fixes/updates (A33 reworked!) | expand |
On Thu, Oct 03, 2019 at 12:15:24PM +0530, Jagan Teki wrote: > Allwinner MIPI DSI controllers are supplied with SoC DSI > power rails via VCC-DSI pin. > > Some board still work without supplying this but give more > faith on datasheet and hardware schematics and document this > supply property in required property list. > > Reviewed-by: Rob Herring <robh@kernel.org> > Tested-by: Merlijn Wajer <merlijn@wizzup.org> > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > --- > .../bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml b/Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml > index 47950fced28d..9d4c25b104f6 100644 > --- a/Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml > +++ b/Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml > @@ -36,6 +36,9 @@ properties: > resets: > maxItems: 1 > > + vcc-dsi-supply: > + description: VCC-DSI power supply of the DSI encoder > + The driver treats it as mandatory, so I've added it to the binding, as suggested by the commit log. Maxime
于 2019年10月3日 GMT+08:00 下午7:47:33, Maxime Ripard <mripard@kernel.org> 写到: >On Thu, Oct 03, 2019 at 12:15:24PM +0530, Jagan Teki wrote: >> Allwinner MIPI DSI controllers are supplied with SoC DSI >> power rails via VCC-DSI pin. >> >> Some board still work without supplying this but give more >> faith on datasheet and hardware schematics and document this >> supply property in required property list. >> >> Reviewed-by: Rob Herring <robh@kernel.org> >> Tested-by: Merlijn Wajer <merlijn@wizzup.org> >> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> >> --- >> .../bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml | 3 >+++ >> 1 file changed, 3 insertions(+) >> >> diff --git >a/Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml >b/Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml >> index 47950fced28d..9d4c25b104f6 100644 >> --- >a/Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml >> +++ >b/Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml >> @@ -36,6 +36,9 @@ properties: >> resets: >> maxItems: 1 >> >> + vcc-dsi-supply: >> + description: VCC-DSI power supply of the DSI encoder >> + > >The driver treats it as mandatory, so I've added it to the binding, as >suggested by the commit log. No. The regulator_get function will return dummy regulator, rather than fail, if the regulator is not specified. > >Maxime
On Thu, Oct 03, 2019 at 09:04:03PM +0800, Icenowy Zheng wrote: > 于 2019年10月3日 GMT+08:00 下午7:47:33, Maxime Ripard <mripard@kernel.org> 写到: > >On Thu, Oct 03, 2019 at 12:15:24PM +0530, Jagan Teki wrote: > >> Allwinner MIPI DSI controllers are supplied with SoC DSI > >> power rails via VCC-DSI pin. > >> > >> Some board still work without supplying this but give more > >> faith on datasheet and hardware schematics and document this > >> supply property in required property list. > >> > >> Reviewed-by: Rob Herring <robh@kernel.org> > >> Tested-by: Merlijn Wajer <merlijn@wizzup.org> > >> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > >> --- > >> .../bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml | 3 > >+++ > >> 1 file changed, 3 insertions(+) > >> > >> diff --git > >a/Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml > >b/Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml > >> index 47950fced28d..9d4c25b104f6 100644 > >> --- > >a/Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml > >> +++ > >b/Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml > >> @@ -36,6 +36,9 @@ properties: > >> resets: > >> maxItems: 1 > >> > >> + vcc-dsi-supply: > >> + description: VCC-DSI power supply of the DSI encoder > >> + > > > >The driver treats it as mandatory, so I've added it to the binding, as > >suggested by the commit log. > > No. The regulator_get function will return dummy regulator, rather than > fail, if the regulator is not specified. Yes. And this deals nicely with the backward compatibility case. The regulator is there on all the SoCs, so there's no reason to leave it out. Maxime
diff --git a/Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml b/Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml index 47950fced28d..9d4c25b104f6 100644 --- a/Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml +++ b/Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml @@ -36,6 +36,9 @@ properties: resets: maxItems: 1 + vcc-dsi-supply: + description: VCC-DSI power supply of the DSI encoder + phys: maxItems: 1