| Message ID | 20191004134452.6493-1-nsaenzjulienne@suse.de (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 19ec6bb80290e496021488084944b77f03a87dd7 |
| Headers | show |
| Series | [v2] mmc: sdhci-iproc: fix spurious interrupts on Multiblock reads with bcm2711 | expand |
On Fri, 4 Oct 2019 at 15:45, Nicolas Saenz Julienne <nsaenzjulienne@suse.de> wrote: > > The Raspberry Pi 4 SDHCI hardware seems to automatically issue CMD12 > after multiblock reads even when ACMD12 is disabled. This triggers > spurious interrupts after the data transfer is done with the following > message: > > mmc1: Got data interrupt 0x00000002 even though no data operation was in progress. > mmc1: sdhci: ============ SDHCI REGISTER DUMP =========== > mmc1: sdhci: Sys addr: 0x00000000 | Version: 0x00001002 > mmc1: sdhci: Blk size: 0x00007200 | Blk cnt: 0x00000000 > mmc1: sdhci: Argument: 0x00000000 | Trn mode: 0x00000033 > mmc1: sdhci: Present: 0x1fff0000 | Host ctl: 0x00000017 > mmc1: sdhci: Power: 0x0000000f | Blk gap: 0x00000080 > mmc1: sdhci: Wake-up: 0x00000000 | Clock: 0x00000107 > mmc1: sdhci: Timeout: 0x00000000 | Int stat: 0x00000000 > mmc1: sdhci: Int enab: 0x03ff100b | Sig enab: 0x03ff100b > mmc1: sdhci: ACmd stat: 0x00000000 | Slot int: 0x00000000 > mmc1: sdhci: Caps: 0x45ee6432 | Caps_1: 0x0000a525 > mmc1: sdhci: Cmd: 0x00000c1a | Max curr: 0x00080008 > mmc1: sdhci: Resp[0]: 0x00000b00 | Resp[1]: 0x00edc87f > mmc1: sdhci: Resp[2]: 0x325b5900 | Resp[3]: 0x00400e00 > mmc1: sdhci: Host ctl2: 0x00000001 > mmc1: sdhci: ADMA Err: 0x00000000 | ADMA Ptr: 0xf3025208 > mmc1: sdhci: ============================================ > > Enable SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 to enable ACMD12 on multiblock > reads and suppress the spurious interrupts. > > Fixes: f84e411c85be ("mmc: sdhci-iproc: Add support for emmc2 of the BCM2711") > Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> > Tested-by: Matthias Brugger <mbrugger@suse.com> > Acked-by: Stefan Wahren <wahrenst@gmx.net> Applied for fixes, thanks! Kind regards Uffe > --- > > Changes since v1: > - Add Fixes tag and Acked-by > > drivers/mmc/host/sdhci-iproc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c > index 2b9cdcd1dd9d..f4f5f0a70cda 100644 > --- a/drivers/mmc/host/sdhci-iproc.c > +++ b/drivers/mmc/host/sdhci-iproc.c > @@ -262,6 +262,7 @@ static const struct sdhci_iproc_data bcm2835_data = { > }; > > static const struct sdhci_pltfm_data sdhci_bcm2711_pltfm_data = { > + .quirks = SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12, > .ops = &sdhci_iproc_32only_ops, > }; > > -- > 2.23.0 >
diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c index 2b9cdcd1dd9d..f4f5f0a70cda 100644 --- a/drivers/mmc/host/sdhci-iproc.c +++ b/drivers/mmc/host/sdhci-iproc.c @@ -262,6 +262,7 @@ static const struct sdhci_iproc_data bcm2835_data = { }; static const struct sdhci_pltfm_data sdhci_bcm2711_pltfm_data = { + .quirks = SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12, .ops = &sdhci_iproc_32only_ops, };
The Raspberry Pi 4 SDHCI hardware seems to automatically issue CMD12 after multiblock reads even when ACMD12 is disabled. This triggers spurious interrupts after the data transfer is done with the following message: mmc1: Got data interrupt 0x00000002 even though no data operation was in progress. mmc1: sdhci: ============ SDHCI REGISTER DUMP =========== mmc1: sdhci: Sys addr: 0x00000000 | Version: 0x00001002 mmc1: sdhci: Blk size: 0x00007200 | Blk cnt: 0x00000000 mmc1: sdhci: Argument: 0x00000000 | Trn mode: 0x00000033 mmc1: sdhci: Present: 0x1fff0000 | Host ctl: 0x00000017 mmc1: sdhci: Power: 0x0000000f | Blk gap: 0x00000080 mmc1: sdhci: Wake-up: 0x00000000 | Clock: 0x00000107 mmc1: sdhci: Timeout: 0x00000000 | Int stat: 0x00000000 mmc1: sdhci: Int enab: 0x03ff100b | Sig enab: 0x03ff100b mmc1: sdhci: ACmd stat: 0x00000000 | Slot int: 0x00000000 mmc1: sdhci: Caps: 0x45ee6432 | Caps_1: 0x0000a525 mmc1: sdhci: Cmd: 0x00000c1a | Max curr: 0x00080008 mmc1: sdhci: Resp[0]: 0x00000b00 | Resp[1]: 0x00edc87f mmc1: sdhci: Resp[2]: 0x325b5900 | Resp[3]: 0x00400e00 mmc1: sdhci: Host ctl2: 0x00000001 mmc1: sdhci: ADMA Err: 0x00000000 | ADMA Ptr: 0xf3025208 mmc1: sdhci: ============================================ Enable SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 to enable ACMD12 on multiblock reads and suppress the spurious interrupts. Fixes: f84e411c85be ("mmc: sdhci-iproc: Add support for emmc2 of the BCM2711") Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> Tested-by: Matthias Brugger <mbrugger@suse.com> Acked-by: Stefan Wahren <wahrenst@gmx.net> --- Changes since v1: - Add Fixes tag and Acked-by drivers/mmc/host/sdhci-iproc.c | 1 + 1 file changed, 1 insertion(+)