diff mbox series

[PATCHv8,1/9] dt-bindings: omap: add new binding for PRM instances

Message ID 20191008125544.20679-2-t-kristo@ti.com (mailing list archive)
State New, archived
Headers show
Series soc: ti: add OMAP PRM driver (for reset) | expand

Commit Message

Tero Kristo Oct. 8, 2019, 12:55 p.m. UTC 
Add new binding for OMAP PRM (Power and Reset Manager) instances. Each
of these will act as a power domain controller and potentially as a reset
provider.

Signed-off-by: Tero Kristo <t-kristo@ti.com>
Reviewed-by: Rob Herring <robh@kernel.org>
Reviewed-by: Tony Lindgren <tony@atomide.com>
---
v7:
  - dropped clocks property from example

 .../devicetree/bindings/arm/omap/prm-inst.txt | 29 +++++++++++++++++++
 1 file changed, 29 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/arm/omap/prm-inst.txt

Comments

Sebastian Reichel Oct. 8, 2019, 3:46 p.m. UTC | #1 
Hi,

On Tue, Oct 08, 2019 at 03:55:36PM +0300, Tero Kristo wrote:
> +Example:
> +
> +prm_dsp2: prm@1b00 {
> +	compatible = "ti,omap-prm-inst", "ti,dra7-prm-inst";

Nit: compatible values are sorted the other way around (most
specific first).

-- Sebastian
Tero Kristo Oct. 9, 2019, 6:52 a.m. UTC | #2 
On 08/10/2019 18:46, Sebastian Reichel wrote:
> Hi,
> 
> On Tue, Oct 08, 2019 at 03:55:36PM +0300, Tero Kristo wrote:
>> +Example:
>> +
>> +prm_dsp2: prm@1b00 {
>> +	compatible = "ti,omap-prm-inst", "ti,dra7-prm-inst";
> 
> Nit: compatible values are sorted the other way around (most
> specific first).

Hmm right, I would not like to re-post the whole series just for this 
seeing all the acks are in place already.

Santosh, do you want to fix this locally or shall we post a separate 
patch later on to fix this?

-Tero
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
Santosh Shilimkar Oct. 9, 2019, 3:59 p.m. UTC | #3 
On 10/8/19 11:52 PM, Tero Kristo wrote:
> On 08/10/2019 18:46, Sebastian Reichel wrote:
>> Hi,
>>
>> On Tue, Oct 08, 2019 at 03:55:36PM +0300, Tero Kristo wrote:
>>> +Example:
>>> +
>>> +prm_dsp2: prm@1b00 {
>>> +    compatible = "ti,omap-prm-inst", "ti,dra7-prm-inst";
>>
>> Nit: compatible values are sorted the other way around (most
>> specific first).
> 
> Hmm right, I would not like to re-post the whole series just for this 
> seeing all the acks are in place already.
> 
> Santosh, do you want to fix this locally or shall we post a separate 
> patch later on to fix this?
> 
No need. I fixed it up. Pls check.

git://git.kernel.org/pub/scm/linux/kernel/git/ssantosh/linux-keystone.git 
for_5.5/driver-soc

Regards,
Santosh
Tero Kristo Oct. 10, 2019, 7:13 a.m. UTC | #4 
On 09/10/2019 18:59, santosh.shilimkar@oracle.com wrote:
> 
> 
> On 10/8/19 11:52 PM, Tero Kristo wrote:
>> On 08/10/2019 18:46, Sebastian Reichel wrote:
>>> Hi,
>>>
>>> On Tue, Oct 08, 2019 at 03:55:36PM +0300, Tero Kristo wrote:
>>>> +Example:
>>>> +
>>>> +prm_dsp2: prm@1b00 {
>>>> +    compatible = "ti,omap-prm-inst", "ti,dra7-prm-inst";
>>>
>>> Nit: compatible values are sorted the other way around (most
>>> specific first).
>>
>> Hmm right, I would not like to re-post the whole series just for this 
>> seeing all the acks are in place already.
>>
>> Santosh, do you want to fix this locally or shall we post a separate 
>> patch later on to fix this?
>>
> No need. I fixed it up. Pls check.
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/ssantosh/linux-keystone.git for_5.5/driver-soc 

Yeah, looks fine to me.

Thanks,
Tero
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/omap/prm-inst.txt b/Documentation/devicetree/bindings/arm/omap/prm-inst.txt
new file mode 100644
index 000000000000..dfe7c7789ca7
--- /dev/null
+++ b/Documentation/devicetree/bindings/arm/omap/prm-inst.txt
@@ -0,0 +1,29 @@ 
+OMAP PRM instance bindings
+
+Power and Reset Manager is an IP block on OMAP family of devices which
+handle the power domains and their current state, and provide reset
+handling for the domains and/or separate IP blocks under the power domain
+hierarchy.
+
+Required properties:
+- compatible:	Must contain one of the following:
+		"ti,am3-prm-inst"
+		"ti,am4-prm-inst"
+		"ti,omap4-prm-inst"
+		"ti,omap5-prm-inst"
+		"ti,dra7-prm-inst"
+		and additionally must contain:
+		"ti,omap-prm-inst"
+- reg:		Contains PRM instance register address range
+		(base address and length)
+
+Optional properties:
+- #reset-cells:	Should be 1 if the PRM instance in question supports resets.
+
+Example:
+
+prm_dsp2: prm@1b00 {
+	compatible = "ti,omap-prm-inst", "ti,dra7-prm-inst";
+	reg = <0x1b00 0x40>;
+	#reset-cells = <1>;
+};