diff mbox series

[v3] dt-bindings: media: Convert stm32 cec bindings to json-schema

Message ID 20191014092021.24020-1-benjamin.gaignard@st.com (mailing list archive)
State Mainlined
Commit 1c86b23db0f0940d37eb391196c34cf228590e7f
Headers show
Series [v3] dt-bindings: media: Convert stm32 cec bindings to json-schema | expand

Commit Message

Benjamin GAIGNARD Oct. 14, 2019, 9:20 a.m. UTC 
Convert the STM32 cec binding to DT schema format using json-schema

Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
---
changes in v3:
- use (GPL-2.0-only OR BSD-2-Clause) license

changes in v2:
- use BSD-2-Clause license
- add additionalProperties: false
- remove pinctrl-names and pinctrl-[0-9]

 .../devicetree/bindings/media/st,stm32-cec.txt     | 19 --------
 .../devicetree/bindings/media/st,stm32-cec.yaml    | 54 ++++++++++++++++++++++
 2 files changed, 54 insertions(+), 19 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/media/st,stm32-cec.txt
 create mode 100644 Documentation/devicetree/bindings/media/st,stm32-cec.yaml

Comments

Rob Herring Oct. 14, 2019, 5:17 p.m. UTC | #1 
On Mon, 14 Oct 2019 11:20:20 +0200, Benjamin Gaignard wrote:
> Convert the STM32 cec binding to DT schema format using json-schema
> 
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
> ---
> changes in v3:
> - use (GPL-2.0-only OR BSD-2-Clause) license
> 
> changes in v2:
> - use BSD-2-Clause license
> - add additionalProperties: false
> - remove pinctrl-names and pinctrl-[0-9]
> 
>  .../devicetree/bindings/media/st,stm32-cec.txt     | 19 --------
>  .../devicetree/bindings/media/st,stm32-cec.yaml    | 54 ++++++++++++++++++++++
>  2 files changed, 54 insertions(+), 19 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/media/st,stm32-cec.txt
>  create mode 100644 Documentation/devicetree/bindings/media/st,stm32-cec.yaml
> 

Applied, thanks.

Rob
Hans Verkuil Oct. 30, 2019, 10:40 a.m. UTC | #2 
On 10/14/19 11:20 AM, Benjamin Gaignard wrote:
> Convert the STM32 cec binding to DT schema format using json-schema
> 
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>

There doesn't seem to be a MAINTAINERS entry for this driver. Can you add
one?

	Hans

> ---
> changes in v3:
> - use (GPL-2.0-only OR BSD-2-Clause) license
> 
> changes in v2:
> - use BSD-2-Clause license
> - add additionalProperties: false
> - remove pinctrl-names and pinctrl-[0-9]
> 
>   .../devicetree/bindings/media/st,stm32-cec.txt     | 19 --------
>   .../devicetree/bindings/media/st,stm32-cec.yaml    | 54 ++++++++++++++++++++++
>   2 files changed, 54 insertions(+), 19 deletions(-)
>   delete mode 100644 Documentation/devicetree/bindings/media/st,stm32-cec.txt
>   create mode 100644 Documentation/devicetree/bindings/media/st,stm32-cec.yaml
> 
> diff --git a/Documentation/devicetree/bindings/media/st,stm32-cec.txt b/Documentation/devicetree/bindings/media/st,stm32-cec.txt
> deleted file mode 100644
> index 6be2381c180d..000000000000
> --- a/Documentation/devicetree/bindings/media/st,stm32-cec.txt
> +++ /dev/null
> @@ -1,19 +0,0 @@
> -STMicroelectronics STM32 CEC driver
> -
> -Required properties:
> - - compatible : value should be "st,stm32-cec"
> - - reg : Physical base address of the IP registers and length of memory
> -	 mapped region.
> - - clocks : from common clock binding: handle to CEC clocks
> - - clock-names : from common clock binding: must be "cec" and "hdmi-cec".
> - - interrupts : CEC interrupt number to the CPU.
> -
> -Example for stm32f746:
> -
> -cec: cec@40006c00 {
> -	compatible = "st,stm32-cec";
> -	reg = <0x40006C00 0x400>;
> -	interrupts = <94>;
> -	clocks = <&rcc 0 STM32F7_APB1_CLOCK(CEC)>, <&rcc 1 CLK_HDMI_CEC>;
> -	clock-names = "cec", "hdmi-cec";
> -};
> diff --git a/Documentation/devicetree/bindings/media/st,stm32-cec.yaml b/Documentation/devicetree/bindings/media/st,stm32-cec.yaml
> new file mode 100644
> index 000000000000..d75019c093a4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/st,stm32-cec.yaml
> @@ -0,0 +1,54 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/st,stm32-cec.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: STMicroelectronics STM32 CEC bindings
> +
> +maintainers:
> +  - Benjamin Gaignard <benjamin.gaignard@st.com>
> +  - Yannick Fertre <yannick.fertre@st.com>
> +
> +properties:
> +  compatible:
> +    const: st,stm32-cec
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  clocks:
> +    items:
> +      - description: Module Clock
> +      - description: Bus Clock
> +
> +  clock-names:
> +    items:
> +      - const: cec
> +      - const: hdmi-cec
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - clocks
> +  - clock-names
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +    #include <dt-bindings/clock/stm32mp1-clks.h>
> +    cec: cec@40006c00 {
> +        compatible = "st,stm32-cec";
> +        reg = <0x40006c00 0x400>;
> +        interrupts = <GIC_SPI 94 IRQ_TYPE_LEVEL_HIGH>;
> +        clocks = <&rcc CEC_K>, <&clk_lse>;
> +        clock-names = "cec", "hdmi-cec";
> +    };
> +
> +...
>
Benjamin GAIGNARD Oct. 31, 2019, 10:36 a.m. UTC | #3 
On 10/30/19 11:40 AM, Hans Verkuil wrote:
> On 10/14/19 11:20 AM, Benjamin Gaignard wrote:
>> Convert the STM32 cec binding to DT schema format using json-schema
>>
>> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
>
> There doesn't seem to be a MAINTAINERS entry for this driver. Can you add
> one?
>
Hi Hans,

I haven't add a dedicated entry in MAINTAINERS file for these drivers 
because

get_maintainer script indicates to send mail to stm32's linux mailing list.

That sound enough for me but if you really want I can add entries in 
MAINTAINERS file.

Benjamin

>     Hans
>
>> ---
>> changes in v3:
>> - use (GPL-2.0-only OR BSD-2-Clause) license
>>
>> changes in v2:
>> - use BSD-2-Clause license
>> - add additionalProperties: false
>> - remove pinctrl-names and pinctrl-[0-9]
>>
>>   .../devicetree/bindings/media/st,stm32-cec.txt     | 19 --------
>>   .../devicetree/bindings/media/st,stm32-cec.yaml    | 54 
>> ++++++++++++++++++++++
>>   2 files changed, 54 insertions(+), 19 deletions(-)
>>   delete mode 100644 
>> Documentation/devicetree/bindings/media/st,stm32-cec.txt
>>   create mode 100644 
>> Documentation/devicetree/bindings/media/st,stm32-cec.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/media/st,stm32-cec.txt 
>> b/Documentation/devicetree/bindings/media/st,stm32-cec.txt
>> deleted file mode 100644
>> index 6be2381c180d..000000000000
>> --- a/Documentation/devicetree/bindings/media/st,stm32-cec.txt
>> +++ /dev/null
>> @@ -1,19 +0,0 @@
>> -STMicroelectronics STM32 CEC driver
>> -
>> -Required properties:
>> - - compatible : value should be "st,stm32-cec"
>> - - reg : Physical base address of the IP registers and length of memory
>> -     mapped region.
>> - - clocks : from common clock binding: handle to CEC clocks
>> - - clock-names : from common clock binding: must be "cec" and 
>> "hdmi-cec".
>> - - interrupts : CEC interrupt number to the CPU.
>> -
>> -Example for stm32f746:
>> -
>> -cec: cec@40006c00 {
>> -    compatible = "st,stm32-cec";
>> -    reg = <0x40006C00 0x400>;
>> -    interrupts = <94>;
>> -    clocks = <&rcc 0 STM32F7_APB1_CLOCK(CEC)>, <&rcc 1 CLK_HDMI_CEC>;
>> -    clock-names = "cec", "hdmi-cec";
>> -};
>> diff --git 
>> a/Documentation/devicetree/bindings/media/st,stm32-cec.yaml 
>> b/Documentation/devicetree/bindings/media/st,stm32-cec.yaml
>> new file mode 100644
>> index 000000000000..d75019c093a4
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/media/st,stm32-cec.yaml
>> @@ -0,0 +1,54 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/media/st,stm32-cec.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: STMicroelectronics STM32 CEC bindings
>> +
>> +maintainers:
>> +  - Benjamin Gaignard <benjamin.gaignard@st.com>
>> +  - Yannick Fertre <yannick.fertre@st.com>
>> +
>> +properties:
>> +  compatible:
>> +    const: st,stm32-cec
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  interrupts:
>> +    maxItems: 1
>> +
>> +  clocks:
>> +    items:
>> +      - description: Module Clock
>> +      - description: Bus Clock
>> +
>> +  clock-names:
>> +    items:
>> +      - const: cec
>> +      - const: hdmi-cec
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +  - interrupts
>> +  - clocks
>> +  - clock-names
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> +  - |
>> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
>> +    #include <dt-bindings/clock/stm32mp1-clks.h>
>> +    cec: cec@40006c00 {
>> +        compatible = "st,stm32-cec";
>> +        reg = <0x40006c00 0x400>;
>> +        interrupts = <GIC_SPI 94 IRQ_TYPE_LEVEL_HIGH>;
>> +        clocks = <&rcc CEC_K>, <&clk_lse>;
>> +        clock-names = "cec", "hdmi-cec";
>> +    };
>> +
>> +...
>>
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/media/st,stm32-cec.txt b/Documentation/devicetree/bindings/media/st,stm32-cec.txt
deleted file mode 100644
index 6be2381c180d..000000000000
--- a/Documentation/devicetree/bindings/media/st,stm32-cec.txt
+++ /dev/null
@@ -1,19 +0,0 @@ 
-STMicroelectronics STM32 CEC driver
-
-Required properties:
- - compatible : value should be "st,stm32-cec"
- - reg : Physical base address of the IP registers and length of memory
-	 mapped region.
- - clocks : from common clock binding: handle to CEC clocks
- - clock-names : from common clock binding: must be "cec" and "hdmi-cec".
- - interrupts : CEC interrupt number to the CPU.
-
-Example for stm32f746:
-
-cec: cec@40006c00 {
-	compatible = "st,stm32-cec";
-	reg = <0x40006C00 0x400>;
-	interrupts = <94>;
-	clocks = <&rcc 0 STM32F7_APB1_CLOCK(CEC)>, <&rcc 1 CLK_HDMI_CEC>;
-	clock-names = "cec", "hdmi-cec";
-};
diff --git a/Documentation/devicetree/bindings/media/st,stm32-cec.yaml b/Documentation/devicetree/bindings/media/st,stm32-cec.yaml
new file mode 100644
index 000000000000..d75019c093a4
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/st,stm32-cec.yaml
@@ -0,0 +1,54 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/st,stm32-cec.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: STMicroelectronics STM32 CEC bindings
+
+maintainers:
+  - Benjamin Gaignard <benjamin.gaignard@st.com>
+  - Yannick Fertre <yannick.fertre@st.com>
+
+properties:
+  compatible:
+    const: st,stm32-cec
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  clocks:
+    items:
+      - description: Module Clock
+      - description: Bus Clock
+
+  clock-names:
+    items:
+      - const: cec
+      - const: hdmi-cec
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - clocks
+  - clock-names
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+    #include <dt-bindings/clock/stm32mp1-clks.h>
+    cec: cec@40006c00 {
+        compatible = "st,stm32-cec";
+        reg = <0x40006c00 0x400>;
+        interrupts = <GIC_SPI 94 IRQ_TYPE_LEVEL_HIGH>;
+        clocks = <&rcc CEC_K>, <&clk_lse>;
+        clock-names = "cec", "hdmi-cec";
+    };
+
+...