| Message ID | 20191023063103.44941-1-maowenan@huawei.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | ef5dee551e3e6568fb203ea57fa24f55cb64d451 |
| Headers | show |
| Series | ASoC: mediatek: Check SND_SOC_CROS_EC_CODEC dependency | expand |
On Wed, Oct 23, 2019 at 2:31 PM Mao Wenan <maowenan@huawei.com> wrote: > > If SND_SOC_MT8183_MT6358_TS3A227E_MAX98357A=y, > below errors can be seen: > sound/soc/codecs/cros_ec_codec.o: In function `send_ec_host_command': > cros_ec_codec.c:(.text+0x534): undefined reference to `cros_ec_cmd_xfer_status' > cros_ec_codec.c:(.text+0x101c): undefined reference to `cros_ec_get_host_event' > > This is because it will select SND_SOC_CROS_EC_CODEC > after commit 2cc3cd5fdc8b ("ASoC: mediatek: mt8183: support WoV"), > but SND_SOC_CROS_EC_CODEC depends on CROS_EC. > > Fixes: 2cc3cd5fdc8b ("ASoC: mediatek: mt8183: support WoV") > Signed-off-by: Mao Wenan <maowenan@huawei.com> Acked-by: Tzung-Bi Shih <tzungbi@google.com> Thanks for the catching.
On Wed, Oct 23, 2019 at 2:31 PM Mao Wenan <maowenan@huawei.com> wrote: > > If SND_SOC_MT8183_MT6358_TS3A227E_MAX98357A=y, > below errors can be seen: > sound/soc/codecs/cros_ec_codec.o: In function `send_ec_host_command': > cros_ec_codec.c:(.text+0x534): undefined reference to `cros_ec_cmd_xfer_status' > cros_ec_codec.c:(.text+0x101c): undefined reference to `cros_ec_get_host_event' > > This is because it will select SND_SOC_CROS_EC_CODEC > after commit 2cc3cd5fdc8b ("ASoC: mediatek: mt8183: support WoV"), > but SND_SOC_CROS_EC_CODEC depends on CROS_EC. > > Fixes: 2cc3cd5fdc8b ("ASoC: mediatek: mt8183: support WoV") > Signed-off-by: Mao Wenan <maowenan@huawei.com> > --- > sound/soc/mediatek/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/mediatek/Kconfig b/sound/soc/mediatek/Kconfig > index 8b29f39..a656d20 100644 > --- a/sound/soc/mediatek/Kconfig > +++ b/sound/soc/mediatek/Kconfig > @@ -125,7 +125,7 @@ config SND_SOC_MT8183_MT6358_TS3A227E_MAX98357A > select SND_SOC_MAX98357A > select SND_SOC_BT_SCO > select SND_SOC_TS3A227E > - select SND_SOC_CROS_EC_CODEC > + select SND_SOC_CROS_EC_CODEC if CROS_EC > help > This adds ASoC driver for Mediatek MT8183 boards > with the MT6358 TS3A227E MAX98357A audio codec. > -- > 2.7.4 > Just realized your patch seems not showing in the list (https://mailman.alsa-project.org/pipermail/alsa-devel/2019-October/thread.html). I have no idea why.
On 2019/10/23 16:32, Tzung-Bi Shih wrote: > On Wed, Oct 23, 2019 at 2:31 PM Mao Wenan <maowenan@huawei.com> wrote: >> >> If SND_SOC_MT8183_MT6358_TS3A227E_MAX98357A=y, >> below errors can be seen: >> sound/soc/codecs/cros_ec_codec.o: In function `send_ec_host_command': >> cros_ec_codec.c:(.text+0x534): undefined reference to `cros_ec_cmd_xfer_status' >> cros_ec_codec.c:(.text+0x101c): undefined reference to `cros_ec_get_host_event' >> >> This is because it will select SND_SOC_CROS_EC_CODEC >> after commit 2cc3cd5fdc8b ("ASoC: mediatek: mt8183: support WoV"), >> but SND_SOC_CROS_EC_CODEC depends on CROS_EC. >> >> Fixes: 2cc3cd5fdc8b ("ASoC: mediatek: mt8183: support WoV") >> Signed-off-by: Mao Wenan <maowenan@huawei.com> >> --- >> sound/soc/mediatek/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/sound/soc/mediatek/Kconfig b/sound/soc/mediatek/Kconfig >> index 8b29f39..a656d20 100644 >> --- a/sound/soc/mediatek/Kconfig >> +++ b/sound/soc/mediatek/Kconfig >> @@ -125,7 +125,7 @@ config SND_SOC_MT8183_MT6358_TS3A227E_MAX98357A >> select SND_SOC_MAX98357A >> select SND_SOC_BT_SCO >> select SND_SOC_TS3A227E >> - select SND_SOC_CROS_EC_CODEC >> + select SND_SOC_CROS_EC_CODEC if CROS_EC >> help >> This adds ASoC driver for Mediatek MT8183 boards >> with the MT6358 TS3A227E MAX98357A audio codec. >> -- >> 2.7.4 >> > > Just realized your patch seems not showing in the list > (https://mailman.alsa-project.org/pipermail/alsa-devel/2019-October/thread.html). > I have no idea why. > I receive below message after I post, do you know why? ''' Your mail to 'Alsa-devel' with the subject [PATCH] ASoC: mediatek: Check SND_SOC_CROS_EC_CODEC dependency Is being held until the list moderator can review it for approval. The reason it is being held: Post by non-member to a members-only list Either the message will get posted to the list, or you will receive notification of the moderator's decision. If you would like to cancel this posting, please visit the following URL: https://mailman.alsa-project.org/mailman/confirm/alsa-devel/574c24ad00f4d1aefc802a8a4b2c5fbda710e4e9 ''' > . >
On Wed, Oct 23, 2019 at 4:38 PM maowenan <maowenan@huawei.com> wrote: > I receive below message after I post, do you know why? > ''' > Your mail to 'Alsa-devel' with the subject > > [PATCH] ASoC: mediatek: Check SND_SOC_CROS_EC_CODEC dependency > > Is being held until the list moderator can review it for approval. > > The reason it is being held: > > Post by non-member to a members-only list I don't exactly know. But I got similar messages when I first time sent mail to the alsa-devel. Have you subscribed to alsa-devel mailing list? I guess it is fine to wait maintainers to proceed your patch.
On 2019/10/23 16:49, Tzung-Bi Shih wrote: > On Wed, Oct 23, 2019 at 4:38 PM maowenan <maowenan@huawei.com> wrote: >> I receive below message after I post, do you know why? >> ''' >> Your mail to 'Alsa-devel' with the subject >> >> [PATCH] ASoC: mediatek: Check SND_SOC_CROS_EC_CODEC dependency >> >> Is being held until the list moderator can review it for approval. >> >> The reason it is being held: >> >> Post by non-member to a members-only list > > I don't exactly know. But I got similar messages when I first time > sent mail to the alsa-devel. > > Have you subscribed to alsa-devel mailing list? I guess it is fine to > wait maintainers to proceed your patch. > OK. Thanks. > . >
diff --git a/sound/soc/mediatek/Kconfig b/sound/soc/mediatek/Kconfig index 8b29f39..a656d20 100644 --- a/sound/soc/mediatek/Kconfig +++ b/sound/soc/mediatek/Kconfig @@ -125,7 +125,7 @@ config SND_SOC_MT8183_MT6358_TS3A227E_MAX98357A select SND_SOC_MAX98357A select SND_SOC_BT_SCO select SND_SOC_TS3A227E - select SND_SOC_CROS_EC_CODEC + select SND_SOC_CROS_EC_CODEC if CROS_EC help This adds ASoC driver for Mediatek MT8183 boards with the MT6358 TS3A227E MAX98357A audio codec.
If SND_SOC_MT8183_MT6358_TS3A227E_MAX98357A=y, below errors can be seen: sound/soc/codecs/cros_ec_codec.o: In function `send_ec_host_command': cros_ec_codec.c:(.text+0x534): undefined reference to `cros_ec_cmd_xfer_status' cros_ec_codec.c:(.text+0x101c): undefined reference to `cros_ec_get_host_event' This is because it will select SND_SOC_CROS_EC_CODEC after commit 2cc3cd5fdc8b ("ASoC: mediatek: mt8183: support WoV"), but SND_SOC_CROS_EC_CODEC depends on CROS_EC. Fixes: 2cc3cd5fdc8b ("ASoC: mediatek: mt8183: support WoV") Signed-off-by: Mao Wenan <maowenan@huawei.com> --- sound/soc/mediatek/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)