| Message ID | 20191031142112.12431-8-frieder.schrempf@kontron.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add support for more Kontron i.MX6UL/ULL SoMs and boards | expand |
On Thu, Oct 31, 2019 at 02:24:21PM +0000, Schrempf Frieder wrote: > From: Frieder Schrempf <frieder.schrempf@kontron.de> > > To silence the warnings shown by the driver at boot time, we add a > fixed regulator for the 5V supply of usbotg2 and specify the polarity > of the overcurrent signal for usbotg1. > > Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de> > Fixes: 1ea4b76cdfde ("ARM: dts: imx6ul-kontron-n6310: Add Kontron i.MX6UL N6310 SoM and boards") I do not think it's a bug fix, so the Fixes tag doesn't really apply. Shawn > --- > arch/arm/boot/dts/imx6ul-kontron-n6x1x-s.dtsi | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6ul-kontron-n6x1x-s.dtsi b/arch/arm/boot/dts/imx6ul-kontron-n6x1x-s.dtsi > index 2299cad900af..d3eb21aa9014 100644 > --- a/arch/arm/boot/dts/imx6ul-kontron-n6x1x-s.dtsi > +++ b/arch/arm/boot/dts/imx6ul-kontron-n6x1x-s.dtsi > @@ -45,6 +45,13 @@ > regulator-max-microvolt = <3300000>; > }; > > + reg_5v: regulator-5v { > + compatible = "regulator-fixed"; > + regulator-name = "5v"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + }; > + > reg_usb_otg1_vbus: regulator-usb-otg1-vbus { > compatible = "regulator-fixed"; > regulator-name = "usb_otg1_vbus"; > @@ -191,6 +198,7 @@ > srp-disable; > hnp-disable; > adp-disable; > + over-current-active-low; > vbus-supply = <®_usb_otg1_vbus>; > status = "okay"; > }; > @@ -198,6 +206,7 @@ > &usbotg2 { > dr_mode = "host"; > disable-over-current; > + vbus-supply = <®_5v>; > status = "okay"; > }; > > -- > 2.17.1
On 04.11.19 08:31, Shawn Guo wrote: > On Thu, Oct 31, 2019 at 02:24:21PM +0000, Schrempf Frieder wrote: >> From: Frieder Schrempf <frieder.schrempf@kontron.de> >> >> To silence the warnings shown by the driver at boot time, we add a >> fixed regulator for the 5V supply of usbotg2 and specify the polarity >> of the overcurrent signal for usbotg1. >> >> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de> >> Fixes: 1ea4b76cdfde ("ARM: dts: imx6ul-kontron-n6310: Add Kontron i.MX6UL N6310 SoM and boards") > > I do not think it's a bug fix, so the Fixes tag doesn't really apply. I guess you're right. It only prevents warnings at boot time and functionality is not broken. I think I had a wrong understanding of the Fixes tag and need to reread the docs... > > Shawn > >> --- >> arch/arm/boot/dts/imx6ul-kontron-n6x1x-s.dtsi | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/arch/arm/boot/dts/imx6ul-kontron-n6x1x-s.dtsi b/arch/arm/boot/dts/imx6ul-kontron-n6x1x-s.dtsi >> index 2299cad900af..d3eb21aa9014 100644 >> --- a/arch/arm/boot/dts/imx6ul-kontron-n6x1x-s.dtsi >> +++ b/arch/arm/boot/dts/imx6ul-kontron-n6x1x-s.dtsi >> @@ -45,6 +45,13 @@ >> regulator-max-microvolt = <3300000>; >> }; >> >> + reg_5v: regulator-5v { >> + compatible = "regulator-fixed"; >> + regulator-name = "5v"; >> + regulator-min-microvolt = <5000000>; >> + regulator-max-microvolt = <5000000>; >> + }; >> + >> reg_usb_otg1_vbus: regulator-usb-otg1-vbus { >> compatible = "regulator-fixed"; >> regulator-name = "usb_otg1_vbus"; >> @@ -191,6 +198,7 @@ >> srp-disable; >> hnp-disable; >> adp-disable; >> + over-current-active-low; >> vbus-supply = <®_usb_otg1_vbus>; >> status = "okay"; >> }; >> @@ -198,6 +206,7 @@ >> &usbotg2 { >> dr_mode = "host"; >> disable-over-current; >> + vbus-supply = <®_5v>; >> status = "okay"; >> }; >> >> -- >> 2.17.1 > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >
diff --git a/arch/arm/boot/dts/imx6ul-kontron-n6x1x-s.dtsi b/arch/arm/boot/dts/imx6ul-kontron-n6x1x-s.dtsi index 2299cad900af..d3eb21aa9014 100644 --- a/arch/arm/boot/dts/imx6ul-kontron-n6x1x-s.dtsi +++ b/arch/arm/boot/dts/imx6ul-kontron-n6x1x-s.dtsi @@ -45,6 +45,13 @@ regulator-max-microvolt = <3300000>; }; + reg_5v: regulator-5v { + compatible = "regulator-fixed"; + regulator-name = "5v"; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + }; + reg_usb_otg1_vbus: regulator-usb-otg1-vbus { compatible = "regulator-fixed"; regulator-name = "usb_otg1_vbus"; @@ -191,6 +198,7 @@ srp-disable; hnp-disable; adp-disable; + over-current-active-low; vbus-supply = <®_usb_otg1_vbus>; status = "okay"; }; @@ -198,6 +206,7 @@ &usbotg2 { dr_mode = "host"; disable-over-current; + vbus-supply = <®_5v>; status = "okay"; };