Message ID | 20191105073413.23129-1-sr@denx.de (mailing list archive) |
---|---|
State | Mainlined |
Commit | 0aeb1f2b74f3402e9cdb7c0b8e2c369c9767301e |
Headers | show |
Series | ARM: dts: imx6ul: imx6ul-14x14-evk.dtsi: Fix SPI NOR probing | expand |
On 05.11.19 08:34, Stefan Roese wrote: > Without this "jedec,spi-nor" compatible property, probing of the SPI NOR > does not work on the NXP i.MX6ULL EVK. Fix this by adding this > compatible property to the DT. > > Signed-off-by: Stefan Roese <sr@denx.de> > Cc: Fabio Estevam <festevam@gmail.com> > Cc: Frieder Schrempf <frieder.schrempf@kontron.de> > Cc: Shawn Guo <shawnguo@kernel.org> Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de> > --- > arch/arm/boot/dts/imx6ul-14x14-evk.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi b/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi > index c2a9dd57e56a..aa86341adaaa 100644 > --- a/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi > +++ b/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi > @@ -215,7 +215,7 @@ > flash0: n25q256a@0 { > #address-cells = <1>; > #size-cells = <1>; > - compatible = "micron,n25q256a"; > + compatible = "micron,n25q256a", "jedec,spi-nor"; > spi-max-frequency = <29000000>; > spi-rx-bus-width = <4>; > spi-tx-bus-width = <4>; >
Hi Stefan, On Tue, Nov 5, 2019 at 4:34 AM Stefan Roese <sr@denx.de> wrote: > > Without this "jedec,spi-nor" compatible property, probing of the SPI NOR > does not work on the NXP i.MX6ULL EVK. Fix this by adding this > compatible property to the DT. > > Signed-off-by: Stefan Roese <sr@denx.de> > Cc: Fabio Estevam <festevam@gmail.com> > Cc: Frieder Schrempf <frieder.schrempf@kontron.de> > Cc: Shawn Guo <shawnguo@kernel.org> Thanks for the fix. Please add a Fixes tag so that it can be backported to older kernels. Then you can also add: Reviewed-by: Fabio Estevam <festevam@gmail.com>
diff --git a/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi b/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi index c2a9dd57e56a..aa86341adaaa 100644 --- a/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi +++ b/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi @@ -215,7 +215,7 @@ flash0: n25q256a@0 { #address-cells = <1>; #size-cells = <1>; - compatible = "micron,n25q256a"; + compatible = "micron,n25q256a", "jedec,spi-nor"; spi-max-frequency = <29000000>; spi-rx-bus-width = <4>; spi-tx-bus-width = <4>;
Without this "jedec,spi-nor" compatible property, probing of the SPI NOR does not work on the NXP i.MX6ULL EVK. Fix this by adding this compatible property to the DT. Signed-off-by: Stefan Roese <sr@denx.de> Cc: Fabio Estevam <festevam@gmail.com> Cc: Frieder Schrempf <frieder.schrempf@kontron.de> Cc: Shawn Guo <shawnguo@kernel.org> --- arch/arm/boot/dts/imx6ul-14x14-evk.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)