| Message ID | 20191106212120.27983-11-wsa+renesas@sang-engineering.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | media: use new API for creating client devices | expand |
Hi On 11/6/19 10:21 PM, Wolfram Sang wrote: > Use the newer API returning an ERRPTR and use the new helper to bail > out. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > --- > drivers/media/platform/sti/c8sectpfe/c8sectpfe-dvb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-dvb.c b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-dvb.c > index a79250a7f812..103872266565 100644 > --- a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-dvb.c > +++ b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-dvb.c > @@ -170,8 +170,8 @@ int c8sectpfe_frontend_attach(struct dvb_frontend **fe, > > /* attach tuner */ > request_module("tda18212"); > - client = i2c_new_device(tsin->i2c_adapter, &tda18212_info); > - if (!client || !client->dev.driver) { > + client = i2c_new_client_device(tsin->i2c_adapter, &tda18212_info); > + if (!i2c_client_has_driver(client)) { > dvb_frontend_detach(*fe); > return -ENODEV; > } Reviewed-by: Patrice Chotard <patrice.chotard@st.com> Thanks
diff --git a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-dvb.c b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-dvb.c index a79250a7f812..103872266565 100644 --- a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-dvb.c +++ b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-dvb.c @@ -170,8 +170,8 @@ int c8sectpfe_frontend_attach(struct dvb_frontend **fe, /* attach tuner */ request_module("tda18212"); - client = i2c_new_device(tsin->i2c_adapter, &tda18212_info); - if (!client || !client->dev.driver) { + client = i2c_new_client_device(tsin->i2c_adapter, &tda18212_info); + if (!i2c_client_has_driver(client)) { dvb_frontend_detach(*fe); return -ENODEV; }
Use the newer API returning an ERRPTR and use the new helper to bail out. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- drivers/media/platform/sti/c8sectpfe/c8sectpfe-dvb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)