diff mbox series

[1/4] arm64: dts: ls1028a: fix typo in TMU calibration data

Message ID 20191123201317.25861-2-michael@walle.cc (mailing list archive)
State New, archived
Headers show
Series ls1028a: dts fixes and new board support | expand

Commit Message

Michael Walle Nov. 23, 2019, 8:13 p.m. UTC
This was tested on a custom board.

Signed-off-by: Michael Walle <michael@walle.cc>
---
 arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Shawn Guo Dec. 9, 2019, 6:24 a.m. UTC | #1
+ Yuantian Tang, who is the author of existing code.

On Sat, Nov 23, 2019 at 09:13:14PM +0100, Michael Walle wrote:
> This was tested on a custom board.

Can you add more info about why this is an error and how it is being
identified?

Shawn

> 
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> index dc75534a4754..f2e71fd57b20 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> @@ -573,7 +573,7 @@
>  					       0x00010004 0x0000003d
>  					       0x00010005 0x00000045
>  					       0x00010006 0x0000004d
> -					       0x00010007 0x00000045
> +					       0x00010007 0x00000055
>  					       0x00010008 0x0000005e
>  					       0x00010009 0x00000066
>  					       0x0001000a 0x0000006e
> -- 
> 2.20.1
>
Andy Tang Dec. 9, 2019, 6:39 a.m. UTC | #2
Hi Shawn,

> -----Original Message-----
> From: Shawn Guo <shawnguo@kernel.org>
> Sent: 2019年12月9日 14:25
> To: Michael Walle <michael@walle.cc>; Andy Tang <andy.tang@nxp.com>
> Cc: linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org;
> linux-kernel@vger.kernel.org; Leo Li <leoyang.li@nxp.com>; Rob Herring
> <robh+dt@kernel.org>; Mark Rutland <mark.rutland@arm.com>
> Subject: [EXT] Re: [PATCH 1/4] arm64: dts: ls1028a: fix typo in TMU
> calibration data
> 
> Caution: EXT Email
> 
> + Yuantian Tang, who is the author of existing code.
> 
> On Sat, Nov 23, 2019 at 09:13:14PM +0100, Michael Walle wrote:
> > This was tested on a custom board.
> 
> Can you add more info about why this is an error and how it is being
> identified?

I am not sure how Michael figured out this error but he/she is correct.
I must have made a mistake when sending these data out.

Thanks Shawn and Michael.

Acked-by: Tang Yuantian <andy.tang@nxp.com>

BR,
Andy
> 
> Shawn
> 
> >
> > Signed-off-by: Michael Walle <michael@walle.cc>
> > ---
> >  arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > index dc75534a4754..f2e71fd57b20 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > @@ -573,7 +573,7 @@
> >                                              0x00010004
> 0x0000003d
> >                                              0x00010005
> 0x00000045
> >                                              0x00010006
> 0x0000004d
> > -                                            0x00010007
> 0x00000045
> > +                                            0x00010007
> 0x00000055
> >                                              0x00010008
> 0x0000005e
> >                                              0x00010009
> 0x00000066
> >                                              0x0001000a
> 0x0000006e
> > --
> > 2.20.1
> >
Michael Walle Dec. 9, 2019, 8:41 a.m. UTC | #3
Am 2019-12-09 07:24, schrieb Shawn Guo:
> + Yuantian Tang, who is the author of existing code.
> 
> On Sat, Nov 23, 2019 at 09:13:14PM +0100, Michael Walle wrote:
>> This was tested on a custom board.
> 
> Can you add more info about why this is an error and how it is being
> identified?

sorry. there was a more elaborate commit message. something went wrong 
here.

-michael

> 
> Shawn
> 
>> 
>> Signed-off-by: Michael Walle <michael@walle.cc>
>> ---
>>  arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi 
>> b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
>> index dc75534a4754..f2e71fd57b20 100644
>> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
>> @@ -573,7 +573,7 @@
>>  					       0x00010004 0x0000003d
>>  					       0x00010005 0x00000045
>>  					       0x00010006 0x0000004d
>> -					       0x00010007 0x00000045
>> +					       0x00010007 0x00000055
>>  					       0x00010008 0x0000005e
>>  					       0x00010009 0x00000066
>>  					       0x0001000a 0x0000006e
>> --
>> 2.20.1
>>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
index dc75534a4754..f2e71fd57b20 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
@@ -573,7 +573,7 @@ 
 					       0x00010004 0x0000003d
 					       0x00010005 0x00000045
 					       0x00010006 0x0000004d
-					       0x00010007 0x00000045
+					       0x00010007 0x00000055
 					       0x00010008 0x0000005e
 					       0x00010009 0x00000066
 					       0x0001000a 0x0000006e