From patchwork Mon Dec 2 17:00:28 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miquel Raynal X-Patchwork-Id: 11269405 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5FB2513A4 for ; Mon, 2 Dec 2019 17:01:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3A62520718 for ; Mon, 2 Dec 2019 17:01:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="U8xthPfs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3A62520718 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=COnwQ3OMo6zf/vKyGwGaTj0mffSsNVPFxP2wFCPAI1I=; b=U8xthPfsR2j412 JYQAxStSVr+4nI6gcIO011uMwFynQfZR54zBUj5cbZIdl4ZtZlP+/xoems3onr0/WyTwEwFwa7IxL IQlqpuh/0pfK/dBpEG84S37XVEdqi6UfCU5ulvqtwiL4JJ6ggioWIoTUTFfD7roUvnkuPe6T7g2gs Eq8qp2xB9ieP2C8kHP4z7A6tINL7wJU6YnwDzhJfWgN9bw1DACAwmHMgwrIhulN5UWV3WcRjQcFQN euMCaZyME+xE7jpyOm/krbNa/JwACzFAS26syRRmVERj6USiq99/WiwrMsIHZF+u6cb0bA6ShxXk5 SrARco8ZzdlyL/De8uYA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ibp4C-0000mj-JK; Mon, 02 Dec 2019 17:00:56 +0000 Received: from relay7-d.mail.gandi.net ([217.70.183.200]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ibp49-0000m8-3R; Mon, 02 Dec 2019 17:00:55 +0000 X-Originating-IP: 91.224.148.103 Received: from localhost.localdomain (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id B7E822001F; Mon, 2 Dec 2019 17:00:38 +0000 (UTC) From: Miquel Raynal To: Rob Herring , Mark Rutland , Heiko Stuebner Subject: [PATCH] arm64: dts: rockchip: Fix IOMMU second clock name Date: Mon, 2 Dec 2019 18:00:28 +0100 Message-Id: <20191202170028.26169-1-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191202_090053_282939_1B71F261 X-CRM114-Status: GOOD ( 12.36 ) X-Spam-Score: -0.7 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-0.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [217.70.183.200 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Maxime Chevallier , Paul Kocialkowski , linux-rockchip@lists.infradead.org, Thomas Petazzoni , Miquel Raynal , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org By precedence, both the IOMMU driver and the bindings in the doc impose two clocks to be filled in Rockchip device trees featuring an IOMMU: * The AXI clock called 'aclk'. * The main peripheral bus clock (PCLK/HCL) called 'iface'. Currently, the second clock in px30.dtsi is called 'hclk' and this produces the following errors at boot: rk_iommu ff460f00.iommu: Failed to get clk 'iface': -2 rk_iommu ff470f00.iommu: Failed to get clk 'iface': -2 Fix the PX30 device tree by renaming the second misnamed clock. The issue has not been reported before probably because the clk_get() call is optional for backward DT compatibility reasons. Fixes: 7053e06b1422 ("arm64: dts: rockchip: add core dtsi file for PX30 SoCs") Signed-off-by: Miquel Raynal --- arch/arm64/boot/dts/rockchip/px30.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/px30.dtsi b/arch/arm64/boot/dts/rockchip/px30.dtsi index eb992d60e6ba..1fd12bd09e83 100644 --- a/arch/arm64/boot/dts/rockchip/px30.dtsi +++ b/arch/arm64/boot/dts/rockchip/px30.dtsi @@ -831,7 +831,7 @@ interrupts = ; interrupt-names = "vopb_mmu"; clocks = <&cru ACLK_VOPB>, <&cru HCLK_VOPB>; - clock-names = "aclk", "hclk"; + clock-names = "aclk", "iface"; power-domains = <&power PX30_PD_VO>; #iommu-cells = <0>; status = "disabled"; @@ -863,7 +863,7 @@ interrupts = ; interrupt-names = "vopl_mmu"; clocks = <&cru ACLK_VOPL>, <&cru HCLK_VOPL>; - clock-names = "aclk", "hclk"; + clock-names = "aclk", "iface"; power-domains = <&power PX30_PD_VO>; #iommu-cells = <0>; status = "disabled";