Message ID | 20191230231953.29646-2-rjones@gateworks.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | ARM: dts: imx: Add GW59xx Gateworks specials | expand |
On Mon, Dec 30, 2019 at 03:19:49PM -0800, Robert Jones wrote: > Add the compatible enum entries for Gateworks Ventana boards. > > Signed-off-by: Robert Jones <rjones@gateworks.com> > --- > Documentation/devicetree/bindings/arm/fsl.yaml | 31 ++++++++++++++++++++++++++ > 1 file changed, 31 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml > index f79683a..8ed4c85 100644 > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > @@ -126,6 +126,22 @@ properties: > - toradex,apalis_imx6q-ixora # Apalis iMX6 Module on Ixora > - toradex,apalis_imx6q-ixora-v1.1 # Apalis iMX6 Module on Ixora V1.1 > - variscite,dt6customboard > + - gw,ventana # Gateworks i.MX6DL or i.MX6Q Ventana > + - gw,imx6q-gw51xx This doesn't match what you have in dts files. Please check with: make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/fsl.yaml You'll need a separate entry with 3 compatibles and 'gw,ventana' or drop it. > + - gw,imx6q-gw52xx > + - gw,imx6q-gw53xx > + - gw,imx6q-gw5400-a > + - gw,imx6q-gw54xx > + - gw,imx6q-gw551x > + - gw,imx6q-gw552x > + - gw,imx6q-gw553x > + - gw,imx6q-gw560x > + - gw,imx6q-gw5903 > + - gw,imx6q-gw5904 > + - gw,imx6q-gw5907 > + - gw,imx6q-gw5910 > + - gw,imx6q-gw5912 > + - gw,imx6q-gw5913 > - const: fsl,imx6q > > - description: i.MX6QP based Boards > @@ -152,6 +168,21 @@ properties: > - ysoft,imx6dl-yapp4-draco # i.MX6 DualLite Y Soft IOTA Draco board > - ysoft,imx6dl-yapp4-hydra # i.MX6 DualLite Y Soft IOTA Hydra board > - ysoft,imx6dl-yapp4-ursa # i.MX6 Solo Y Soft IOTA Ursa board > + - gw,ventana # Gateworks i.MX6DL or i.MX6Q Ventana > + - gw,imx6dl-gw51xx > + - gw,imx6dl-gw52xx > + - gw,imx6dl-gw53xx > + - gw,imx6dl-gw54xx > + - gw,imx6dl-gw551x > + - gw,imx6dl-gw552x > + - gw,imx6dl-gw553x > + - gw,imx6dl-gw560x > + - gw,imx6dl-gw5903 > + - gw,imx6dl-gw5904 > + - gw,imx6dl-gw5907 > + - gw,imx6dl-gw5910 > + - gw,imx6dl-gw5912 > + - gw,imx6dl-gw5913 > - const: fsl,imx6dl > > - description: i.MX6SL based Boards > -- > 2.9.2 >
On Fri, Jan 3, 2020 at 2:32 PM Rob Herring <robh@kernel.org> wrote: > > On Mon, Dec 30, 2019 at 03:19:49PM -0800, Robert Jones wrote: > > Add the compatible enum entries for Gateworks Ventana boards. > > > > Signed-off-by: Robert Jones <rjones@gateworks.com> > > --- > > Documentation/devicetree/bindings/arm/fsl.yaml | 31 ++++++++++++++++++++++++++ > > 1 file changed, 31 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml > > index f79683a..8ed4c85 100644 > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > > @@ -126,6 +126,22 @@ properties: > > - toradex,apalis_imx6q-ixora # Apalis iMX6 Module on Ixora > > - toradex,apalis_imx6q-ixora-v1.1 # Apalis iMX6 Module on Ixora V1.1 > > - variscite,dt6customboard > > + - gw,ventana # Gateworks i.MX6DL or i.MX6Q Ventana > > + - gw,imx6q-gw51xx > > This doesn't match what you have in dts files. Please check with: > > make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/fsl.yaml > > You'll need a separate entry with 3 compatibles and 'gw,ventana' or drop > it. Hi Rob, Sorry, I'm still getting used to the whole schema format and a bit confused. Can you be more specific in how it doesn't match? I looked at the imx6q-gw51xx.dts file where I got the entry from and it has the following line: compatible = "gw,imx6q-gw51xx", "gw,ventana", "fsl,imx6q"; Obviously I'm only submitting the gw59xx board device trees but a previous version of this submission was asked to add all of the compatible strings for the Gateworks boards. Are you asking me to only post the gw59xx lines? > > > + - gw,imx6q-gw52xx > > + - gw,imx6q-gw53xx > > + - gw,imx6q-gw5400-a > > + - gw,imx6q-gw54xx > > + - gw,imx6q-gw551x > > + - gw,imx6q-gw552x > > + - gw,imx6q-gw553x > > + - gw,imx6q-gw560x > > + - gw,imx6q-gw5903 > > + - gw,imx6q-gw5904 > > + - gw,imx6q-gw5907 > > + - gw,imx6q-gw5910 > > + - gw,imx6q-gw5912 > > + - gw,imx6q-gw5913 > > - const: fsl,imx6q > > > > - description: i.MX6QP based Boards > > @@ -152,6 +168,21 @@ properties: > > - ysoft,imx6dl-yapp4-draco # i.MX6 DualLite Y Soft IOTA Draco board > > - ysoft,imx6dl-yapp4-hydra # i.MX6 DualLite Y Soft IOTA Hydra board > > - ysoft,imx6dl-yapp4-ursa # i.MX6 Solo Y Soft IOTA Ursa board > > + - gw,ventana # Gateworks i.MX6DL or i.MX6Q Ventana > > + - gw,imx6dl-gw51xx > > + - gw,imx6dl-gw52xx > > + - gw,imx6dl-gw53xx > > + - gw,imx6dl-gw54xx > > + - gw,imx6dl-gw551x > > + - gw,imx6dl-gw552x > > + - gw,imx6dl-gw553x > > + - gw,imx6dl-gw560x > > + - gw,imx6dl-gw5903 > > + - gw,imx6dl-gw5904 > > + - gw,imx6dl-gw5907 > > + - gw,imx6dl-gw5910 > > + - gw,imx6dl-gw5912 > > + - gw,imx6dl-gw5913 > > - const: fsl,imx6dl > > > > - description: i.MX6SL based Boards > > -- > > 2.9.2 > >
On Mon, Jan 6, 2020 at 3:25 PM Bobby Jones <rjones@gateworks.com> wrote: > > On Fri, Jan 3, 2020 at 2:32 PM Rob Herring <robh@kernel.org> wrote: > > > > On Mon, Dec 30, 2019 at 03:19:49PM -0800, Robert Jones wrote: > > > Add the compatible enum entries for Gateworks Ventana boards. > > > > > > Signed-off-by: Robert Jones <rjones@gateworks.com> > > > --- > > > Documentation/devicetree/bindings/arm/fsl.yaml | 31 ++++++++++++++++++++++++++ > > > 1 file changed, 31 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml > > > index f79683a..8ed4c85 100644 > > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > > > @@ -126,6 +126,22 @@ properties: > > > - toradex,apalis_imx6q-ixora # Apalis iMX6 Module on Ixora > > > - toradex,apalis_imx6q-ixora-v1.1 # Apalis iMX6 Module on Ixora V1.1 > > > - variscite,dt6customboard > > > + - gw,ventana # Gateworks i.MX6DL or i.MX6Q Ventana > > > + - gw,imx6q-gw51xx > > > > This doesn't match what you have in dts files. Please check with: > > > > make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/fsl.yaml > > > > You'll need a separate entry with 3 compatibles and 'gw,ventana' or drop > > it. > > Hi Rob, > > Sorry, I'm still getting used to the whole schema format and a bit > confused. Can you be more specific in how it doesn't match? I looked > at the imx6q-gw51xx.dts file where I got the entry from and it has the > following line: > > compatible = "gw,imx6q-gw51xx", "gw,ventana", "fsl,imx6q"; As written, the schema would not allow this, but would allow one of these: "gw,imx6q-gw51xx", "fsl,imx6q" "gw,ventana", "fsl,imx6q" The 'items' schema allows for 2 entries. So if you want/need to support 3 entries for compatible, you need a new 'items' schema with 3 entries: items: - enum: - gw,imx6q-gw51xx - ... all the other boards listed below - const: gw,ventana - enum: - fsl,imx6dl - fsl,imx6q > Obviously I'm only submitting the gw59xx board device trees but a > previous version of this submission was asked to add all of the > compatible strings for the Gateworks boards. Are you asking me to only > post the gw59xx lines? That's an orthogonal issue which I'll leave to the i.MX maintainers. > > > > > + - gw,imx6q-gw52xx > > > + - gw,imx6q-gw53xx > > > + - gw,imx6q-gw5400-a > > > + - gw,imx6q-gw54xx > > > + - gw,imx6q-gw551x > > > + - gw,imx6q-gw552x > > > + - gw,imx6q-gw553x > > > + - gw,imx6q-gw560x > > > + - gw,imx6q-gw5903 > > > + - gw,imx6q-gw5904 > > > + - gw,imx6q-gw5907 > > > + - gw,imx6q-gw5910 > > > + - gw,imx6q-gw5912 > > > + - gw,imx6q-gw5913 > > > - const: fsl,imx6q > > > > > > - description: i.MX6QP based Boards > > > @@ -152,6 +168,21 @@ properties: > > > - ysoft,imx6dl-yapp4-draco # i.MX6 DualLite Y Soft IOTA Draco board > > > - ysoft,imx6dl-yapp4-hydra # i.MX6 DualLite Y Soft IOTA Hydra board > > > - ysoft,imx6dl-yapp4-ursa # i.MX6 Solo Y Soft IOTA Ursa board > > > + - gw,ventana # Gateworks i.MX6DL or i.MX6Q Ventana > > > + - gw,imx6dl-gw51xx > > > + - gw,imx6dl-gw52xx > > > + - gw,imx6dl-gw53xx > > > + - gw,imx6dl-gw54xx > > > + - gw,imx6dl-gw551x > > > + - gw,imx6dl-gw552x > > > + - gw,imx6dl-gw553x > > > + - gw,imx6dl-gw560x > > > + - gw,imx6dl-gw5903 > > > + - gw,imx6dl-gw5904 > > > + - gw,imx6dl-gw5907 > > > + - gw,imx6dl-gw5910 > > > + - gw,imx6dl-gw5912 > > > + - gw,imx6dl-gw5913 > > > - const: fsl,imx6dl > > > > > > - description: i.MX6SL based Boards > > > -- > > > 2.9.2 > > >
diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml index f79683a..8ed4c85 100644 --- a/Documentation/devicetree/bindings/arm/fsl.yaml +++ b/Documentation/devicetree/bindings/arm/fsl.yaml @@ -126,6 +126,22 @@ properties: - toradex,apalis_imx6q-ixora # Apalis iMX6 Module on Ixora - toradex,apalis_imx6q-ixora-v1.1 # Apalis iMX6 Module on Ixora V1.1 - variscite,dt6customboard + - gw,ventana # Gateworks i.MX6DL or i.MX6Q Ventana + - gw,imx6q-gw51xx + - gw,imx6q-gw52xx + - gw,imx6q-gw53xx + - gw,imx6q-gw5400-a + - gw,imx6q-gw54xx + - gw,imx6q-gw551x + - gw,imx6q-gw552x + - gw,imx6q-gw553x + - gw,imx6q-gw560x + - gw,imx6q-gw5903 + - gw,imx6q-gw5904 + - gw,imx6q-gw5907 + - gw,imx6q-gw5910 + - gw,imx6q-gw5912 + - gw,imx6q-gw5913 - const: fsl,imx6q - description: i.MX6QP based Boards @@ -152,6 +168,21 @@ properties: - ysoft,imx6dl-yapp4-draco # i.MX6 DualLite Y Soft IOTA Draco board - ysoft,imx6dl-yapp4-hydra # i.MX6 DualLite Y Soft IOTA Hydra board - ysoft,imx6dl-yapp4-ursa # i.MX6 Solo Y Soft IOTA Ursa board + - gw,ventana # Gateworks i.MX6DL or i.MX6Q Ventana + - gw,imx6dl-gw51xx + - gw,imx6dl-gw52xx + - gw,imx6dl-gw53xx + - gw,imx6dl-gw54xx + - gw,imx6dl-gw551x + - gw,imx6dl-gw552x + - gw,imx6dl-gw553x + - gw,imx6dl-gw560x + - gw,imx6dl-gw5903 + - gw,imx6dl-gw5904 + - gw,imx6dl-gw5907 + - gw,imx6dl-gw5910 + - gw,imx6dl-gw5912 + - gw,imx6dl-gw5913 - const: fsl,imx6dl - description: i.MX6SL based Boards
Add the compatible enum entries for Gateworks Ventana boards. Signed-off-by: Robert Jones <rjones@gateworks.com> --- Documentation/devicetree/bindings/arm/fsl.yaml | 31 ++++++++++++++++++++++++++ 1 file changed, 31 insertions(+)