| Message ID | 20200108072550.28613-3-zhengdejin5@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | net: stmmac: remove useless code of phy_mask | expand |
Hi Dejin,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on net-next/master]
[also build test ERROR on net/master linus/master v5.5-rc6]
[cannot apply to sparc-next/master next-20200117]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Dejin-Zheng/net-stmmac-remove-useless-code-of-phy_mask/20200110-011131
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git daea5b4dc16c3edc90392a512492dae504f1a37a
config: mips-randconfig-a001-20200118 (attached as .config)
compiler: mipsel-linux-gcc (GCC) 5.5.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=5.5.0 make.cross ARCH=mips
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> arch/mips//loongson32/common/platform.c:82:2: error: unknown field 'phy_mask' specified in initializer
.phy_mask = 0,
^
vim +/phy_mask +82 arch/mips//loongson32/common/platform.c
f29ad10de6c345 arch/mips/loongson1/common/platform.c Kelvin Cheung 2014-10-10 79
ca585cf9fb818b arch/mips/loongson1/common/platform.c Kelvin Cheung 2012-07-25 80 /* Synopsys Ethernet GMAC */
f29ad10de6c345 arch/mips/loongson1/common/platform.c Kelvin Cheung 2014-10-10 81 static struct stmmac_mdio_bus_data ls1x_mdio_bus_data = {
f29ad10de6c345 arch/mips/loongson1/common/platform.c Kelvin Cheung 2014-10-10 @82 .phy_mask = 0,
f29ad10de6c345 arch/mips/loongson1/common/platform.c Kelvin Cheung 2014-10-10 83 };
f29ad10de6c345 arch/mips/loongson1/common/platform.c Kelvin Cheung 2014-10-10 84
:::::: The code at line 82 was first introduced by commit
:::::: f29ad10de6c345c8ae4cb33a99ba8ff29bdcd751 MIPS: Loongson1B: Some fixes/updates for LS1B
:::::: TO: Kelvin Cheung <keguang.zhang@gmail.com>
:::::: CC: Ralf Baechle <ralf@linux-mips.org>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
On Sat, Jan 18, 2020 at 03:51:11PM +0800, kbuild test robot wrote: > Hi Dejin, > > Thank you for the patch! Yet something to improve: > Thanks for reminding, This patch has been dropped, the patch V3 that replaced it no longer contains this content, Please refer to https://patchwork.ozlabs.org/patch/1219694/ for details. It should be fine after giving up this commit. Finally, Thanks a lot for Jose's help (Jose.Abreu@synopsys.com), he told me that the phy_mask is useful and should be kept when I submit this commit. BR, Dejin > [auto build test ERROR on net-next/master] > [also build test ERROR on net/master linus/master v5.5-rc6] > [cannot apply to sparc-next/master next-20200117] > [if your patch is applied to the wrong git tree, please drop us a note to help > improve the system. BTW, we also suggest to use '--base' option to specify the > base tree in git format-patch, please see https://stackoverflow.com/a/37406982] > > url: https://github.com/0day-ci/linux/commits/Dejin-Zheng/net-stmmac-remove-useless-code-of-phy_mask/20200110-011131 > base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git daea5b4dc16c3edc90392a512492dae504f1a37a > config: mips-randconfig-a001-20200118 (attached as .config) > compiler: mipsel-linux-gcc (GCC) 5.5.0 > reproduce: > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # save the attached .config to linux build tree > GCC_VERSION=5.5.0 make.cross ARCH=mips > > If you fix the issue, kindly add following tag > Reported-by: kbuild test robot <lkp@intel.com> > > All errors (new ones prefixed by >>): > > >> arch/mips//loongson32/common/platform.c:82:2: error: unknown field 'phy_mask' specified in initializer > .phy_mask = 0, > ^ > > vim +/phy_mask +82 arch/mips//loongson32/common/platform.c > > f29ad10de6c345 arch/mips/loongson1/common/platform.c Kelvin Cheung 2014-10-10 79 > ca585cf9fb818b arch/mips/loongson1/common/platform.c Kelvin Cheung 2012-07-25 80 /* Synopsys Ethernet GMAC */ > f29ad10de6c345 arch/mips/loongson1/common/platform.c Kelvin Cheung 2014-10-10 81 static struct stmmac_mdio_bus_data ls1x_mdio_bus_data = { > f29ad10de6c345 arch/mips/loongson1/common/platform.c Kelvin Cheung 2014-10-10 @82 .phy_mask = 0, > f29ad10de6c345 arch/mips/loongson1/common/platform.c Kelvin Cheung 2014-10-10 83 }; > f29ad10de6c345 arch/mips/loongson1/common/platform.c Kelvin Cheung 2014-10-10 84 > > :::::: The code at line 82 was first introduced by commit > :::::: f29ad10de6c345c8ae4cb33a99ba8ff29bdcd751 MIPS: Loongson1B: Some fixes/updates for LS1B > > :::::: TO: Kelvin Cheung <keguang.zhang@gmail.com> > :::::: CC: Ralf Baechle <ralf@linux-mips.org> > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c index cfe5d8b73142..662b1cde51ae 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c @@ -388,7 +388,6 @@ int stmmac_mdio_register(struct net_device *ndev) snprintf(new_bus->id, MII_BUS_ID_SIZE, "%s-%x", new_bus->name, priv->plat->bus_id); new_bus->priv = ndev; - new_bus->phy_mask = mdio_bus_data->phy_mask; new_bus->parent = priv->device; err = of_mdiobus_register(new_bus, mdio_node); diff --git a/include/linux/stmmac.h b/include/linux/stmmac.h index d4bcd9387136..e9aaa9bfb304 100644 --- a/include/linux/stmmac.h +++ b/include/linux/stmmac.h @@ -79,7 +79,6 @@ /* Platfrom data for platform device structure's platform_data field */ struct stmmac_mdio_bus_data { - unsigned int phy_mask; int *irqs; int probed_phy_irq; bool needs_reset;
The value of phy_mask in struct stmmac_mdio_bus_data will be passed to phy_mask of struct mii_bus before register mdiobus, the mii_bus was obtained by mdiobus_alloc() and set mii_bus->phy_mask as zero by default. the stmmac_mdio_bus_data->phy_mask also set zero when got stmmac_mdio_bus_data by devm_kzalloc(), so doesn't need to pass the value and remove the useless member phy_mask in the struct stmmac_mdio_bus_data. Signed-off-by: Dejin Zheng <zhengdejin5@gmail.com> --- Changes since v1: add this new commit. drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 1 - include/linux/stmmac.h | 1 - 2 files changed, 2 deletions(-)