| Message ID | 20200108101057.29599-1-m.felsch@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,1/3] ARM: dts: imx6: phycore-som: fix arm and soc minimum voltage | expand |
On Wed, Jan 08, 2020 at 11:10:55AM +0100, Marco Felsch wrote: > The current set minimum voltage of 730000mV seems to be wrong. I don't mV = milli-volt, /1000th of a volt. So you just said 730V. µV or uV = micro-volt, which I think is what you mean here. > know the document which specifies that but the imx6qdl datasheets says > that the minimum voltage should be 0.925V for VDD_ARM (LDO bypassed, > lowest opp) and 1.15V for VDD_SOC (LDO bypassed, lowest opp). > > Fixes: ddec5d1c0047 ("ARM: dts: imx6: Add initial support for phyCORE-i.MX 6 SOM") > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> > --- > v2: > - use ldo bypassed values > - adapt commit message > > arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi > index 6486df3e2942..f23eef1e54e0 100644 > --- a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi > @@ -107,14 +107,14 @@ > regulators { > vdd_arm: buck1 { > regulator-name = "vdd_arm"; > - regulator-min-microvolt = <730000>; > + regulator-min-microvolt = <925000>; > regulator-max-microvolt = <1380000>; > regulator-always-on; > }; > > vdd_soc: buck2 { > regulator-name = "vdd_soc"; > - regulator-min-microvolt = <730000>; > + regulator-min-microvolt = <1150000>; > regulator-max-microvolt = <1380000>; > regulator-always-on; > }; > -- > 2.20.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >
On 20-01-08 10:34, Russell King - ARM Linux admin wrote: > On Wed, Jan 08, 2020 at 11:10:55AM +0100, Marco Felsch wrote: > > The current set minimum voltage of 730000mV seems to be wrong. I don't > > mV = milli-volt, /1000th of a volt. So you just said 730V. > µV or uV = micro-volt, which I think is what you mean here. Arg.. you are right thanks for covering that. > > know the document which specifies that but the imx6qdl datasheets says > > that the minimum voltage should be 0.925V for VDD_ARM (LDO bypassed, > > lowest opp) and 1.15V for VDD_SOC (LDO bypassed, lowest opp). > > > > Fixes: ddec5d1c0047 ("ARM: dts: imx6: Add initial support for phyCORE-i.MX 6 SOM") > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> > > --- > > v2: > > - use ldo bypassed values > > - adapt commit message > > > > arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi > > index 6486df3e2942..f23eef1e54e0 100644 > > --- a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi > > +++ b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi > > @@ -107,14 +107,14 @@ > > regulators { > > vdd_arm: buck1 { > > regulator-name = "vdd_arm"; > > - regulator-min-microvolt = <730000>; > > + regulator-min-microvolt = <925000>; > > regulator-max-microvolt = <1380000>; > > regulator-always-on; > > }; > > > > vdd_soc: buck2 { > > regulator-name = "vdd_soc"; > > - regulator-min-microvolt = <730000>; > > + regulator-min-microvolt = <1150000>; > > regulator-max-microvolt = <1380000>; > > regulator-always-on; > > }; > > -- > > 2.20.1 > > > > > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > > > > -- > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up > According to speedtest.net: 11.9Mbps down 500kbps up >
diff --git a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi index 6486df3e2942..f23eef1e54e0 100644 --- a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi +++ b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi @@ -107,14 +107,14 @@ regulators { vdd_arm: buck1 { regulator-name = "vdd_arm"; - regulator-min-microvolt = <730000>; + regulator-min-microvolt = <925000>; regulator-max-microvolt = <1380000>; regulator-always-on; }; vdd_soc: buck2 { regulator-name = "vdd_soc"; - regulator-min-microvolt = <730000>; + regulator-min-microvolt = <1150000>; regulator-max-microvolt = <1380000>; regulator-always-on; };
The current set minimum voltage of 730000mV seems to be wrong. I don't know the document which specifies that but the imx6qdl datasheets says that the minimum voltage should be 0.925V for VDD_ARM (LDO bypassed, lowest opp) and 1.15V for VDD_SOC (LDO bypassed, lowest opp). Fixes: ddec5d1c0047 ("ARM: dts: imx6: Add initial support for phyCORE-i.MX 6 SOM") Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> --- v2: - use ldo bypassed values - adapt commit message arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)