From patchwork Thu Jan 30 06:44:30 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Walter Wu X-Patchwork-Id: 11357553 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1648D14E3 for ; Thu, 30 Jan 2020 06:55:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 220F0206F0 for ; Thu, 30 Jan 2020 06:55:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="TFsIhJq8"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="bvCPjljz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 220F0206F0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=14pKGsFBg3COuwPH0mEnl48H+qJPiKAS9jwE4gIm4rE=; b=TFsIhJq84KQK37 ecvVeBSgGE6LQKpEed1M4Tps3VdmotD0wTq8eJ2/davtHz5cNKx8PZ2GuQ6JyosJAN9GNIL0M0mgD T7N4fshyEdKNCQFsnIx6pqBLR8aWfJa4tIVWP6kmodN1LzLnNwMIpP764SBl3763+CQ70fwHl40Lm cFsm6z/3y9UdECyWBIVzb/VSOfeTaUoS9CgFB48Ea3cCwH7oZthM0HMqIW6+jARJ8Eay7uTTD/9Qt 0CcMjegjQ5siwb2yq5wppN3FQBkp0l4ZAjzLhvOOkELTOyI3UlENEu4L2LKSs/y9pSVeFw/e239Dq WVtSSrkNESBf8sJ7ro+A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ix3je-0000RA-80; Thu, 30 Jan 2020 06:55:30 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ix3is-0006v2-13; Thu, 30 Jan 2020 06:54:43 +0000 X-UUID: a92aa108a944468384a247f7a86f6134-20200129 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:Date:Subject:CC:To:From; bh=nT9JMqdZL40d6DpIqTDz/AwubrwRPPy0W7SQItA5Q+w=; b=bvCPjljzGWgWhxaHBpAEAwLoBNL0M/XBXFDOuYs9dwX9R7Mzz27QgkmpWPa/ufJdtzi78/cHh2h5fCwFpMZ/Guwjgu1g3ONybeWWG7Iqi8YsNugJw9VCLvlGTdFmSU5L7OXFhmAva8lMJAxZOj/lY42RLOJyHvU+d91nqB/zfks=; X-UUID: a92aa108a944468384a247f7a86f6134-20200129 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 389337364; Wed, 29 Jan 2020 22:54:35 -0800 Received: from MTKMBS06N1.mediatek.inc (172.21.101.129) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 29 Jan 2020 22:44:57 -0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs06n1.mediatek.inc (172.21.101.129) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 30 Jan 2020 14:44:31 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 30 Jan 2020 14:43:35 +0800 From: Walter Wu To: Dmitry Vyukov , Matthias Brugger , Thomas Gleixner , "Alexander Potapenko" , Josh Poimboeuf , "Greg Kroah-Hartman" , Kate Stewart Subject: [PATCH v3] lib/stackdepot: Fix global out-of-bounds in stackdepot Date: Thu, 30 Jan 2020 14:44:30 +0800 Message-ID: <20200130064430.17198-1-walter-zh.wu@mediatek.com> X-Mailer: git-send-email 2.18.0 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200129_225442_241252_B0D10B67 X-CRM114-Status: GOOD ( 10.72 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.3 on bombadil.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [216.200.240.184 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 MIME_BASE64_TEXT RAW: Message text disguised using base64 encoding -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Walter Wu , linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, wsd_upstream Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org If the depot_index = STACK_ALLOC_MAX_SLABS - 2 and next_slab_inited = 0, then it will cause array out-of-bounds access, so that we should modify the detection to avoid this array out-of-bounds bug. Assume depot_index = STACK_ALLOC_MAX_SLABS - 3 Consider following call flow sequence: stack_depot_save() depot_alloc_stack() if (unlikely(depot_index + 1 >= STACK_ALLOC_MAX_SLABS)) //pass depot_index++ //depot_index = STACK_ALLOC_MAX_SLABS - 2 if (depot_index + 1 < STACK_ALLOC_MAX_SLABS) //enter smp_store_release(&next_slab_inited, 0); //next_slab_inited = 0 init_stack_slab() if (stack_slabs[depot_index] == NULL) //enter and exit stack_depot_save() depot_alloc_stack() if (unlikely(depot_index + 1 >= STACK_ALLOC_MAX_SLABS)) //pass depot_index++ //depot_index = STACK_ALLOC_MAX_SLABS - 1 init_stack_slab(&prealloc) stack_slabs[depot_index + 1] //here get global out-of-bounds Cc: Dmitry Vyukov Cc: Matthias Brugger Cc: Thomas Gleixner Cc: Alexander Potapenko Cc: Josh Poimboeuf Cc: Kate Stewart Cc: Greg Kroah-Hartman Cc: Kate Stewart Signed-off-by: Walter Wu --- changes in v2: modify call flow sequence and preconditon changes in v3: add some reviewers --- lib/stackdepot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/stackdepot.c b/lib/stackdepot.c index ed717dd08ff3..7e8a15e41600 100644 --- a/lib/stackdepot.c +++ b/lib/stackdepot.c @@ -106,7 +106,7 @@ static struct stack_record *depot_alloc_stack(unsigned long *entries, int size, required_size = ALIGN(required_size, 1 << STACK_ALLOC_ALIGN); if (unlikely(depot_offset + required_size > STACK_ALLOC_SIZE)) { - if (unlikely(depot_index + 1 >= STACK_ALLOC_MAX_SLABS)) { + if (unlikely(depot_index + 2 >= STACK_ALLOC_MAX_SLABS)) { WARN_ONCE(1, "Stack depot reached limit capacity"); return NULL; }