diff mbox series

crypto: arm64/poly1305: ignore build files

Message ID 20200203233933.19577-1-mcroce@redhat.com (mailing list archive)
State Mainlined
Commit 4fb3d8ba2824db0b8553602daef82fe27f50bba2
Headers show
Series crypto: arm64/poly1305: ignore build files | expand

Commit Message

Matteo Croce Feb. 3, 2020, 11:39 p.m. UTC
Add arch/arm64/crypto/poly1305-core.S to .gitignore
as it's built from poly1305-core.S_shipped

Fixes: f569ca164751 ("crypto: arm64/poly1305 - incorporate OpenSSL/CRYPTOGAMS NEON implementation")
Signed-off-by: Matteo Croce <mcroce@redhat.com>
---
 arch/arm64/crypto/.gitignore | 1 +
 1 file changed, 1 insertion(+)

Comments

Herbert Xu Feb. 13, 2020, 9:23 a.m. UTC | #1
On Tue, Feb 04, 2020 at 12:39:33AM +0100, Matteo Croce wrote:
> Add arch/arm64/crypto/poly1305-core.S to .gitignore
> as it's built from poly1305-core.S_shipped
> 
> Fixes: f569ca164751 ("crypto: arm64/poly1305 - incorporate OpenSSL/CRYPTOGAMS NEON implementation")
> Signed-off-by: Matteo Croce <mcroce@redhat.com>
> ---
>  arch/arm64/crypto/.gitignore | 1 +
>  1 file changed, 1 insertion(+)

Patch applied.  Thanks.
Jason A. Donenfeld Feb. 13, 2020, 10:34 a.m. UTC | #2
On Thu, Feb 13, 2020 at 05:23:55PM +0800, Herbert Xu wrote:
> On Tue, Feb 04, 2020 at 12:39:33AM +0100, Matteo Croce wrote:
> > Add arch/arm64/crypto/poly1305-core.S to .gitignore
> > as it's built from poly1305-core.S_shipped
> > 
> > Fixes: f569ca164751 ("crypto: arm64/poly1305 - incorporate OpenSSL/CRYPTOGAMS NEON implementation")
> > Signed-off-by: Matteo Croce <mcroce@redhat.com>
> > ---
> >  arch/arm64/crypto/.gitignore | 1 +
> >  1 file changed, 1 insertion(+)
> 
> Patch applied.  Thanks.

Probably makes sense for 5.6, no?
Herbert Xu Feb. 13, 2020, 10:38 a.m. UTC | #3
On Thu, Feb 13, 2020 at 11:34:44AM +0100, Jason A. Donenfeld wrote:
> On Thu, Feb 13, 2020 at 05:23:55PM +0800, Herbert Xu wrote:
> > On Tue, Feb 04, 2020 at 12:39:33AM +0100, Matteo Croce wrote:
> > > Add arch/arm64/crypto/poly1305-core.S to .gitignore
> > > as it's built from poly1305-core.S_shipped
> > > 
> > > Fixes: f569ca164751 ("crypto: arm64/poly1305 - incorporate OpenSSL/CRYPTOGAMS NEON implementation")
> > > Signed-off-by: Matteo Croce <mcroce@redhat.com>
> > > ---
> > >  arch/arm64/crypto/.gitignore | 1 +
> > >  1 file changed, 1 insertion(+)
> > 
> > Patch applied.  Thanks.
> 
> Probably makes sense for 5.6, no?

No this is too minor.  Only critical bug fixes (e.g., user
triggerable crashes) or build issues are routinely accepted.

Cheers,
Ard Biesheuvel Feb. 13, 2020, 10:44 a.m. UTC | #4
On Thu, 13 Feb 2020 at 11:39, Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> On Thu, Feb 13, 2020 at 11:34:44AM +0100, Jason A. Donenfeld wrote:
> > On Thu, Feb 13, 2020 at 05:23:55PM +0800, Herbert Xu wrote:
> > > On Tue, Feb 04, 2020 at 12:39:33AM +0100, Matteo Croce wrote:
> > > > Add arch/arm64/crypto/poly1305-core.S to .gitignore
> > > > as it's built from poly1305-core.S_shipped
> > > >
> > > > Fixes: f569ca164751 ("crypto: arm64/poly1305 - incorporate OpenSSL/CRYPTOGAMS NEON implementation")
> > > > Signed-off-by: Matteo Croce <mcroce@redhat.com>
> > > > ---
> > > >  arch/arm64/crypto/.gitignore | 1 +
> > > >  1 file changed, 1 insertion(+)
> > >
> > > Patch applied.  Thanks.
> >
> > Probably makes sense for 5.6, no?
>
> No this is too minor.  Only critical bug fixes (e.g., user
> triggerable crashes) or build issues are routinely accepted.
>

Sasha Levin's 'AI' bot finds everything with a 'fixes' tag and
proposes to backport it if it applies cleanly and doesn't break the
build, so this patch is going to end up in v5.6 anyway.
diff mbox series

Patch

diff --git a/arch/arm64/crypto/.gitignore b/arch/arm64/crypto/.gitignore
index 879df8781ed5..e403b1343328 100644
--- a/arch/arm64/crypto/.gitignore
+++ b/arch/arm64/crypto/.gitignore
@@ -1,2 +1,3 @@ 
 sha256-core.S
 sha512-core.S
+poly1305-core.S