| Message ID | 20200206141811.24862-1-zhengdejin5@gmail.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 7d10f0774f9e32aa2f2e012f7fcb312a2ce422b9 |
| Headers | show |
| Series | [v2] net: stmmac: fix a possible endless loop | expand |
From: Dejin Zheng <zhengdejin5@gmail.com> Date: Thu, 6 Feb 2020 22:18:11 +0800 > It forgot to reduce the value of the variable retry in a while loop > in the ethqos_configure() function. It may cause an endless loop and > without timeout. > > Fixes: a7c30e62d4b8 ("net: stmmac: Add driver for Qualcomm ethqos") > > Signed-off-by: Dejin Zheng <zhengdejin5@gmail.com> > Acked-by: Vinod Koul <vkoul@kernel.org> > --- > > Vinod Koul and David Miller, Thanks for your comments! > > V2: > add an appropriate Fixes tag. Please do not put an empty line between Fixes and other tags. I have no idea why people often do this. Anyways, Fixes and other tags are all tags and thus belong together as an uninterrupted group of text. Thank you.
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c index 7ec895407d23..e0a5fe83d8e0 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c @@ -413,6 +413,7 @@ static int ethqos_configure(struct qcom_ethqos *ethqos) dll_lock = rgmii_readl(ethqos, SDC4_STATUS); if (dll_lock & SDC4_STATUS_DLL_LOCK) break; + retry--; } while (retry > 0); if (!retry) dev_err(ðqos->pdev->dev,
It forgot to reduce the value of the variable retry in a while loop in the ethqos_configure() function. It may cause an endless loop and without timeout. Fixes: a7c30e62d4b8 ("net: stmmac: Add driver for Qualcomm ethqos") Signed-off-by: Dejin Zheng <zhengdejin5@gmail.com> Acked-by: Vinod Koul <vkoul@kernel.org> --- Vinod Koul and David Miller, Thanks for your comments! V2: add an appropriate Fixes tag. drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 1 + 1 file changed, 1 insertion(+)