From patchwork Fri Feb 7 14:13:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Enric Balletbo i Serra X-Patchwork-Id: 11370483 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1009413A4 for ; Fri, 7 Feb 2020 14:13:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E1EA820838 for ; Fri, 7 Feb 2020 14:13:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qLPO6p68" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E1EA820838 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=BjNuJ2pUl4p8j1Z7tJlkx5osUrGWEMF1Bjd0bHAvm3U=; b=qLPO6p68jz/q5y fEDKC492Ab21WxtZFTZU3eLjooEiNf/VTqNg81LfQyNlY/6zXoTDDm5uOD/5QqzMQB/eBOUbeb05w qaVlnHUdCdmd9l5zIv96BjBsl3Aj4gg7Jo24gOH8MQnW4YHK4XU6hsafKt8npybfzieaaUY8K0xhd 1GTe1i43Wg8LmcA/UKEOZBSC4haWe+unDlZsFxiDjIbXGXoNPf8P+YRBQPcoiHKw+zFf+B3kTqCM6 ZeO0sK7/Nsy9XH9BcK1dTYfYum1OCxBDwT4yhzHtQhNjjtUq+KmNVQK8/u/YyXruOeI5esCJrqeJW k1K9AqqxslxEEWOFd3Dg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j04O7-0007Va-9r; Fri, 07 Feb 2020 14:13:43 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j04O4-0007UX-0e; Fri, 07 Feb 2020 14:13:41 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: eballetbo) with ESMTPSA id B13AD2958AC From: Enric Balletbo i Serra To: linux-kernel@vger.kernel.org Subject: [PATCH] arm64: dts: rk3399: Remove extcon unit address and extcon-cells from Gru Date: Fri, 7 Feb 2020 15:13:24 +0100 Message-Id: <20200207141324.3188898-1-enric.balletbo@collabora.com> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200207_061340_185545_CE69C648 X-CRM114-Status: GOOD ( 10.31 ) X-Spam-Score: -0.0 (/) X-Spam-Report: SpamAssassin version 3.4.3 on bombadil.infradead.org summary: Content analysis details: (-0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, dafna.hirschfeld@collabora.com, heiko@sntech.de, Marcel Holtmann , Brian Norris , Rob Herring , linux-rockchip@lists.infradead.org, Matthias Kaehlcke , Collabora Kernel ML , Robin Murphy , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org The cros-ec-extcon has no reg property so remove the unit address from the DT node to make DT compiler happy. While here, remove the inexistent extcon-cells property from the extcon nodes. Signed-off-by: Enric Balletbo i Serra --- Thanks to the Dafna's work and Rob's review I got noticed that the old txt binding was wrong, and also, that the current cros-ec-extcon node in Gru is wrong, so sending this patch now that is fresh in our minds and update the node accordingly. There is an extcon-cells property that seems to not exist and is not documented, so remove it. For reference, see https://lkml.org/lkml/2020/2/5/176. arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi | 4 +--- arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi index 7cd6d470c1cb..1384dabbdf40 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi @@ -291,11 +291,9 @@ cros_ec_pwm: ec-pwm { #pwm-cells = <1>; }; - usbc_extcon1: extcon@1 { + usbc_extcon1: extcon1 { compatible = "google,extcon-usbc-cros-ec"; google,usb-port-id = <1>; - - #extcon-cells = <0>; }; }; diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi index dd5624975c9b..2f3997740068 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi @@ -570,11 +570,9 @@ i2c_tunnel: i2c-tunnel { #size-cells = <0>; }; - usbc_extcon0: extcon@0 { + usbc_extcon0: extcon0 { compatible = "google,extcon-usbc-cros-ec"; google,usb-port-id = <0>; - - #extcon-cells = <0>; }; }; };