| Message ID | 20200211134356.59904-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next] staging: vc04_services: remove set but unused variable 'local_entity_uc' | expand |
On Tue, Feb 11, 2020 at 09:43:56PM +0800, YueHaibing wrote: > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c: In function vchiq_use_internal: > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:2346:16: > warning: variable local_entity_uc set but not used [-Wunused-but-set-variable] > > commit bd8aa2850f00 ("staging: vc04_services: Get of even more suspend/resume states") > left behind this unused variable. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > index c456ced..d30d24d 100644 > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > @@ -2343,7 +2343,7 @@ vchiq_use_internal(struct vchiq_state *state, struct vchiq_service *service, > enum vchiq_status ret = VCHIQ_SUCCESS; > char entity[16]; > int *entity_uc; > - int local_uc, local_entity_uc; > + int local_uc; > > if (!arm_state) > goto out; > @@ -2367,7 +2367,6 @@ vchiq_use_internal(struct vchiq_state *state, struct vchiq_service *service, > > write_lock_bh(&arm_state->susp_res_lock); > local_uc = ++arm_state->videocore_use_count; > - local_entity_uc = ++(*entity_uc); ^^ This ++ is required. regards, dan carpenter
On 2020/2/11 22:24, Dan Carpenter wrote: > On Tue, Feb 11, 2020 at 09:43:56PM +0800, YueHaibing wrote: >> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c: In function vchiq_use_internal: >> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:2346:16: >> warning: variable local_entity_uc set but not used [-Wunused-but-set-variable] >> >> commit bd8aa2850f00 ("staging: vc04_services: Get of even more suspend/resume states") >> left behind this unused variable. >> >> Reported-by: Hulk Robot <hulkci@huawei.com> >> Signed-off-by: YueHaibing <yuehaibing@huawei.com> >> --- >> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c >> index c456ced..d30d24d 100644 >> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c >> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c >> @@ -2343,7 +2343,7 @@ vchiq_use_internal(struct vchiq_state *state, struct vchiq_service *service, >> enum vchiq_status ret = VCHIQ_SUCCESS; >> char entity[16]; >> int *entity_uc; >> - int local_uc, local_entity_uc; >> + int local_uc; >> >> if (!arm_state) >> goto out; >> @@ -2367,7 +2367,6 @@ vchiq_use_internal(struct vchiq_state *state, struct vchiq_service *service, >> >> write_lock_bh(&arm_state->susp_res_lock); >> local_uc = ++arm_state->videocore_use_count; >> - local_entity_uc = ++(*entity_uc); > ^^ > This ++ is required. oops..., Thanks! > > regards, > dan carpenter > > > . >
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c index c456ced..d30d24d 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c @@ -2343,7 +2343,7 @@ vchiq_use_internal(struct vchiq_state *state, struct vchiq_service *service, enum vchiq_status ret = VCHIQ_SUCCESS; char entity[16]; int *entity_uc; - int local_uc, local_entity_uc; + int local_uc; if (!arm_state) goto out; @@ -2367,7 +2367,6 @@ vchiq_use_internal(struct vchiq_state *state, struct vchiq_service *service, write_lock_bh(&arm_state->susp_res_lock); local_uc = ++arm_state->videocore_use_count; - local_entity_uc = ++(*entity_uc); vchiq_log_trace(vchiq_susp_log_level, "%s %s count %d, state count %d",
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c: In function vchiq_use_internal: drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:2346:16: warning: variable local_entity_uc set but not used [-Wunused-but-set-variable] commit bd8aa2850f00 ("staging: vc04_services: Get of even more suspend/resume states") left behind this unused variable. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)