From patchwork Wed Feb 19 02:18:11 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leo Yan X-Patchwork-Id: 11390255 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 91ADE139A for ; Wed, 19 Feb 2020 02:20:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 10F282176D for ; Wed, 19 Feb 2020 02:20:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="THGIBBGT"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ElOwfH5O" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 10F282176D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=V4YOlJvmr6w6D0/k2NCPMQ0MAULv74k/CrYWQsUZw7k=; b=THGIBBGTZYe2fEhyrtlCg0qwhQ qNS6Nq/ijyNaSvZaXC9IJAWPlsIMCA0FfzecIMBahavdbmF8LX2cRW1De+cjqNluYrfii4MFmL+9S n13DSIUk1AZS/t15c4ebTfWa5kDT4NDu9sHnSLToM/wXQUQrwKtc0p2vzAlhiVOTTGEUKHHfX7v0o uNxIO+xUPvLQR/sriL05v4AUvtGXmffxhD1u91v6WZ8ljhhqTdd8W6/e0wwl8v0sowyO8+qdPdOIQ 7FaSsHHXX8gNX5spGOXo4lQXO43Z3YRagTc7RJfBYPJDw9sQf01ohHrLfR99UI4M8cYmtdgMXNbDX +06AESCA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j4Exx-0001Uj-BS; Wed, 19 Feb 2020 02:19:57 +0000 Received: from mail-pl1-x642.google.com ([2607:f8b0:4864:20::642]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j4ExZ-00016x-7A for linux-arm-kernel@lists.infradead.org; Wed, 19 Feb 2020 02:19:36 +0000 Received: by mail-pl1-x642.google.com with SMTP id t6so8885100plj.5 for ; Tue, 18 Feb 2020 18:19:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=0n3bCMKVPcTL7ZDSsdKbGiesjZL6H1rMCnqz/XkRXJ8=; b=ElOwfH5Onz8U8ol8oSfjBK0bPmP3l325hdSQjzWnNQhHXcDjV+SFvxlvtt43NbNSrA pnulaAvng4VefC9rILZVbu07OUdV3qhymebe732MKgx0KDzbfmEr0BuUPzUrl+fXIYvC BeNe1n02qOg9lDzkYOOG/YHngHJ0Fxy/Ygh37b9nGeCYQeB0GIFoGz2ZZlzMZAkmBdA1 rnJ1pomZ0ZIwz3YO+3jD1U30mAJS3x5cxCyDeG5UBMEW6YIvHEdD76zBbBYbaNxjPAKM LN3Mx//kt9u/kY52UjTqc+crWNmD0u7IV0ppDu4OsmovP15N6MNmTK/2BXmSyaF+VH54 UEnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=0n3bCMKVPcTL7ZDSsdKbGiesjZL6H1rMCnqz/XkRXJ8=; b=IZX9Cs8weCXWbbzeuE/oOMDyv/Rt+jqQdgt/20VMd7K4+/9oG5ycvkBaNWfp6RYtLh crOSvuocAe04rCk8bHQMwIfnd4VKrTZnnv15k7b19gr/a3i7NxnEyUs3SSVwhOXh3q5E QmchL52mPMKpEfj79v4PfwSqTHlQIgsiqNSrqC1lZKbJZ9Hb8tjZtOrc+E+9BdhtCCMW 0K7VEZCL+VRXyj+UQI8L6+ILBCPGUBnpOuOm8rlKc1P/3cFfKKoqGa5+sfLDyXucnHma P4uN4F2ORO3IZXQnmqkBp9Exyq6a33d8wHE29eJzyF5/7/alhtZeCps6UOm13k/7OoL+ L50g== X-Gm-Message-State: APjAAAUobQxK2phCL7AdXXCtLb31WMmuRcsbBCDQ+sPSPKkMeFxBA/6x ShtZwMNQxccOxn8ZaHORNRU90A== X-Google-Smtp-Source: APXvYqwD9w+iDoltztRVgp/7slI+JKpGxGX4xI+qC2WnbgD6u5THByB9GOxIQT/5SsrJOkj/cck0dA== X-Received: by 2002:a17:902:820b:: with SMTP id x11mr23692815pln.196.1582078772192; Tue, 18 Feb 2020 18:19:32 -0800 (PST) Received: from localhost.localdomain (li1441-214.members.linode.com. [45.118.134.214]) by smtp.gmail.com with ESMTPSA id q11sm322698pff.111.2020.02.18.18.19.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Feb 2020 18:19:31 -0800 (PST) From: Leo Yan To: Arnaldo Carvalho de Melo , Mathieu Poirier , Suzuki K Poulose , Mike Leach , Robert Walker , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Coresight ML Subject: [PATCH v5 5/5] perf cs-etm: Fix unsigned variable comparison to zero Date: Wed, 19 Feb 2020 10:18:11 +0800 Message-Id: <20200219021811.20067-6-leo.yan@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200219021811.20067-1-leo.yan@linaro.org> References: <20200219021811.20067-1-leo.yan@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200218_181933_288501_DBCDE89E X-CRM114-Status: GOOD ( 13.78 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.3 on bombadil.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:642 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Leo Yan MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org The variable 'offset' in function cs_etm__sample() is u64 type, it's not appropriate to check it with 'while (offset > 0)'; this patch changes to 'while (offset)'. Signed-off-by: Leo Yan Reviewed-by: Mike Leach Reviewed-by: Mathieu Poirier --- tools/perf/util/cs-etm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c index aa4b6d060ebb..bba969d48076 100644 --- a/tools/perf/util/cs-etm.c +++ b/tools/perf/util/cs-etm.c @@ -962,7 +962,7 @@ static inline u64 cs_etm__instr_addr(struct cs_etm_queue *etmq, if (packet->isa == CS_ETM_ISA_T32) { u64 addr = packet->start_addr; - while (offset > 0) { + while (offset) { addr += cs_etm__t32_instr_size(etmq, trace_chan_id, addr); offset--;