diff mbox series

[2/4] ARM: dts: sun8i-a83t-tbs-a711: HM5065 doesn't like such a high voltage

Message ID 20200222223154.221632-3-megous@megous.com (mailing list archive)
State New, archived
Headers show
Series Assortment of fixes for TBS A711 Tablet | expand

Commit Message

Ondřej Jirman Feb. 22, 2020, 10:31 p.m. UTC
Lowering the voltage solves the quick image degradation over time
(minutes), that was probably caused by overheating.

Signed-off-by: Ondrej Jirman <megous@megous.com>
---
 arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Chen-Yu Tsai Feb. 23, 2020, 3:39 a.m. UTC | #1
On Sun, Feb 23, 2020 at 6:32 AM Ondrej Jirman <megous@megous.com> wrote:
>
> Lowering the voltage solves the quick image degradation over time
> (minutes), that was probably caused by overheating.
>
> Signed-off-by: Ondrej Jirman <megous@megous.com>

Makes sense. A lot of camera sensors run their digital parts off 1.8V.
This one is no different.

Acked-by: Chen-Yu Tsai <wens@csie.org>

The whole CSI stuff isn't enabled in the device tree yet though, and
there are a lot of regulators with CSI in their names. Will this get
worked on?

ChenYu

> ---
>  arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
> index ee5ce3556b2ad..ae1fd2ee3bcce 100644
> --- a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
> +++ b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
> @@ -371,8 +371,8 @@ &reg_dldo2 {
>  };
>
>  &reg_dldo3 {
> -       regulator-min-microvolt = <2800000>;
> -       regulator-max-microvolt = <2800000>;
> +       regulator-min-microvolt = <1800000>;
> +       regulator-max-microvolt = <1800000>;
>         regulator-name = "vdd-csi";
>  };
>
> --
> 2.25.1
>
> --
> You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe@googlegroups.com.
> To view this discussion on the web, visit https://groups.google.com/d/msgid/linux-sunxi/20200222223154.221632-3-megous%40megous.com.
Ondřej Jirman Feb. 23, 2020, 9:57 a.m. UTC | #2
Hello,

On Sun, Feb 23, 2020 at 11:39:17AM +0800, Chen-Yu Tsai wrote:
> On Sun, Feb 23, 2020 at 6:32 AM Ondrej Jirman <megous@megous.com> wrote:
> >
> > Lowering the voltage solves the quick image degradation over time
> > (minutes), that was probably caused by overheating.
> >
> > Signed-off-by: Ondrej Jirman <megous@megous.com>
> 
> Makes sense. A lot of camera sensors run their digital parts off 1.8V.
> This one is no different.
> 
> Acked-by: Chen-Yu Tsai <wens@csie.org>
> 
> The whole CSI stuff isn't enabled in the device tree yet though, and
> there are a lot of regulators with CSI in their names. Will this get
> worked on?

Yes, I'm preparing support for both cameras in this branch:

  https://megous.com/git/linux/log/?h=cam-5.6

Both already work quite well. I'm just sending some fixes early.

Both cameras work best at 1.8V for the digital part.

regards,
	o.

> ChenYu
> 
> > ---
> >  arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
> > index ee5ce3556b2ad..ae1fd2ee3bcce 100644
> > --- a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
> > +++ b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
> > @@ -371,8 +371,8 @@ &reg_dldo2 {
> >  };
> >
> >  &reg_dldo3 {
> > -       regulator-min-microvolt = <2800000>;
> > -       regulator-max-microvolt = <2800000>;
> > +       regulator-min-microvolt = <1800000>;
> > +       regulator-max-microvolt = <1800000>;
> >         regulator-name = "vdd-csi";
> >  };
> >
> > --
> > 2.25.1
> >
> > --
> > You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe@googlegroups.com.
> > To view this discussion on the web, visit https://groups.google.com/d/msgid/linux-sunxi/20200222223154.221632-3-megous%40megous.com.
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
index ee5ce3556b2ad..ae1fd2ee3bcce 100644
--- a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
+++ b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
@@ -371,8 +371,8 @@  &reg_dldo2 {
 };
 
 &reg_dldo3 {
-	regulator-min-microvolt = <2800000>;
-	regulator-max-microvolt = <2800000>;
+	regulator-min-microvolt = <1800000>;
+	regulator-max-microvolt = <1800000>;
 	regulator-name = "vdd-csi";
 };