diff mbox series

[1/3] arm64: dts: sun50i-a64: Add i2c2 pins

Message ID 20200223172916.843379-2-megous@megous.com (mailing list archive)
State New, archived
Headers show
Series Add support for Pine64 PinePhone Linux Smartphone | expand

Commit Message

Ondřej Jirman Feb. 23, 2020, 5:29 p.m. UTC 
PinePhone needs I2C2 pins description. Add it.

Signed-off-by: Ondrej Jirman <megous@megous.com>
---
 arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Maxime Ripard Feb. 24, 2020, 11:01 a.m. UTC | #1 
On Sun, Feb 23, 2020 at 06:29:14PM +0100, Ondrej Jirman wrote:
> PinePhone needs I2C2 pins description. Add it.
>
> Signed-off-by: Ondrej Jirman <megous@megous.com>
> ---
>  arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> index 862b47dc9dc90..0fdf5f400d743 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> @@ -671,6 +671,11 @@ i2c1_pins: i2c1-pins {
>  				function = "i2c1";
>  			};
>
> +			i2c2_pins: i2c2-pins {
> +				pins = "PE14", "PE15";
> +				function = "i2c2";
> +			};
> +

Setting it as the default muxing for i2c2 would be great

Maxime
Ondřej Jirman Feb. 24, 2020, 12:59 p.m. UTC | #2 
On Mon, Feb 24, 2020 at 12:01:00PM +0100, Maxime Ripard wrote:
> On Sun, Feb 23, 2020 at 06:29:14PM +0100, Ondrej Jirman wrote:
> > PinePhone needs I2C2 pins description. Add it.
> >
> > Signed-off-by: Ondrej Jirman <megous@megous.com>
> > ---
> >  arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> > index 862b47dc9dc90..0fdf5f400d743 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> > @@ -671,6 +671,11 @@ i2c1_pins: i2c1-pins {
> >  				function = "i2c1";
> >  			};
> >
> > +			i2c2_pins: i2c2-pins {
> > +				pins = "PE14", "PE15";
> > +				function = "i2c2";
> > +			};
> > +
> 
> Setting it as the default muxing for i2c2 would be great

Right, I checked the datasheet and it looks like this is the only pins where
i2c2 can be muxed to.

I will change it.

regards,
	o.

> Maxime
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
index 862b47dc9dc90..0fdf5f400d743 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
@@ -671,6 +671,11 @@  i2c1_pins: i2c1-pins {
 				function = "i2c1";
 			};
 
+			i2c2_pins: i2c2-pins {
+				pins = "PE14", "PE15";
+				function = "i2c2";
+			};
+
 			/omit-if-no-ref/
 			lcd_rgb666_pins: lcd-rgb666-pins {
 				pins = "PD0", "PD1", "PD2", "PD3", "PD4",