diff mbox series

arm64: add blank after 'if'

Message ID 20200313145403.6395-1-wei.zheng@vivo.com (mailing list archive)
State Mainlined
Commit 62b9562a1c46913349e7897c4a39c544f176b3da
Headers show
Series arm64: add blank after 'if' | expand

Commit Message

Zheng Wei March 13, 2020, 2:54 p.m. UTC
add blank after 'if' for armv8_deprecated_init()
to make it comply with kernel coding style.

Signed-off-by: Zheng Wei <wei.zheng@vivo.com>
---
 arch/arm64/kernel/armv8_deprecated.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Will Deacon March 17, 2020, 10:28 p.m. UTC | #1
On Fri, Mar 13, 2020 at 10:54:02PM +0800, Zheng Wei wrote:
> add blank after 'if' for armv8_deprecated_init()
> to make it comply with kernel coding style.
> 
> Signed-off-by: Zheng Wei <wei.zheng@vivo.com>
> ---
>  arch/arm64/kernel/armv8_deprecated.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/kernel/armv8_deprecated.c b/arch/arm64/kernel/armv8_deprecated.c
> index 7832b3216370..4cc581af2d96 100644
> --- a/arch/arm64/kernel/armv8_deprecated.c
> +++ b/arch/arm64/kernel/armv8_deprecated.c
> @@ -630,7 +630,7 @@ static int __init armv8_deprecated_init(void)
>  		register_insn_emulation(&cp15_barrier_ops);
>  
>  	if (IS_ENABLED(CONFIG_SETEND_EMULATION)) {
> -		if(system_supports_mixed_endian_el0())
> +		if (system_supports_mixed_endian_el0())
>  			register_insn_emulation(&setend_ops);
>  		else
>  			pr_info("setend instruction emulation is not supported on this system\n");

(Catalin: I'm just acking these trivial typo/style fixes to get them out
of my inbox; do whatever you like with them ;)

Acked-by: Will Deacon <will@kernel.org>

Will
王文虎 March 18, 2020, 5:32 a.m. UTC | #2
From: Will Deacon <will@kernel.org>
Date: 2020-03-18 06:28:24
To:  Zheng Wei <wei.zheng@vivo.com>
Cc:  Catalin Marinas <catalin.marinas@arm.com>,Hanjun Guo <guohanjun@huawei.com>,Enrico Weigelt <info@metux.net>,Allison Randal <allison@lohutok.net>,Greg Kroah-Hartman <gregkh@linuxfoundation.org>,Thomas Gleixner <tglx@linutronix.de>,Yunfeng Ye <yeyunfeng@huawei.com>,linux-arm-kernel@lists.infradead.org,linux-kernel@vger.kernel.org,kernel@vivo.com,wenhu.wang@vivo.com
Subject: Re: [PATCH] arm64: add blank after 'if'>On Fri, Mar 13, 2020 at 10:54:02PM +0800, Zheng Wei wrote:
>> add blank after 'if' for armv8_deprecated_init()
>> to make it comply with kernel coding style.
>> 
>> Signed-off-by: Zheng Wei <wei.zheng@vivo.com>
>> ---
>>  arch/arm64/kernel/armv8_deprecated.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/arch/arm64/kernel/armv8_deprecated.c b/arch/arm64/kernel/armv8_deprecated.c
>> index 7832b3216370..4cc581af2d96 100644
>> --- a/arch/arm64/kernel/armv8_deprecated.c
>> +++ b/arch/arm64/kernel/armv8_deprecated.c
>> @@ -630,7 +630,7 @@ static int __init armv8_deprecated_init(void)
>>  		register_insn_emulation(&cp15_barrier_ops);
>>  
>>  	if (IS_ENABLED(CONFIG_SETEND_EMULATION)) {
>> -		if(system_supports_mixed_endian_el0())
>> +		if (system_supports_mixed_endian_el0())
>>  			register_insn_emulation(&setend_ops);
>>  		else
>>  			pr_info("setend instruction emulation is not supported on this system\n");
>
>(Catalin: I'm just acking these trivial typo/style fixes to get them out
>of my inbox; do whatever you like with them ;)
>
>Acked-by: Will Deacon <will@kernel.org>
>
>Will

Shouldn't you have Cc trivial<trivial@kernel.org>?
Asked-by: Wang Wenhu <wenhu.wang@vivo.com>

Wenhu
Catalin Marinas March 18, 2020, 9:30 a.m. UTC | #3
On Wed, Mar 18, 2020 at 01:32:28PM +0800, 王文虎 wrote:
> From: Will Deacon <will@kernel.org>
> Date: 2020-03-18 06:28:24
> To:  Zheng Wei <wei.zheng@vivo.com>
> Cc:  Catalin Marinas <catalin.marinas@arm.com>,Hanjun Guo <guohanjun@huawei.com>,Enrico Weigelt <info@metux.net>,Allison Randal <allison@lohutok.net>,Greg Kroah-Hartman <gregkh@linuxfoundation.org>,Thomas Gleixner <tglx@linutronix.de>,Yunfeng Ye <yeyunfeng@huawei.com>,linux-arm-kernel@lists.infradead.org,linux-kernel@vger.kernel.org,kernel@vivo.com,wenhu.wang@vivo.com
> Subject: Re: [PATCH] arm64: add blank after 'if'>On Fri, Mar 13, 2020 at 10:54:02PM +0800, Zheng Wei wrote:
> >> add blank after 'if' for armv8_deprecated_init()
> >> to make it comply with kernel coding style.
> >> 
> >> Signed-off-by: Zheng Wei <wei.zheng@vivo.com>
> >> ---
> >>  arch/arm64/kernel/armv8_deprecated.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >> 
> >> diff --git a/arch/arm64/kernel/armv8_deprecated.c b/arch/arm64/kernel/armv8_deprecated.c
> >> index 7832b3216370..4cc581af2d96 100644
> >> --- a/arch/arm64/kernel/armv8_deprecated.c
> >> +++ b/arch/arm64/kernel/armv8_deprecated.c
> >> @@ -630,7 +630,7 @@ static int __init armv8_deprecated_init(void)
> >>  		register_insn_emulation(&cp15_barrier_ops);
> >>  
> >>  	if (IS_ENABLED(CONFIG_SETEND_EMULATION)) {
> >> -		if(system_supports_mixed_endian_el0())
> >> +		if (system_supports_mixed_endian_el0())
> >>  			register_insn_emulation(&setend_ops);
> >>  		else
> >>  			pr_info("setend instruction emulation is not supported on this system\n");
> >
> >(Catalin: I'm just acking these trivial typo/style fixes to get them out
> >of my inbox; do whatever you like with them ;)
> >
> >Acked-by: Will Deacon <will@kernel.org>
> >
> >Will
> 
> Shouldn't you have Cc trivial<trivial@kernel.org>?
> Asked-by: Wang Wenhu <wenhu.wang@vivo.com>

I queued them already, they are in arm64 for-next/core. In the future,
it they could as well go in via trivial@kernel.org (as long as there are
no serious conflicts).
diff mbox series

Patch

diff --git a/arch/arm64/kernel/armv8_deprecated.c b/arch/arm64/kernel/armv8_deprecated.c
index 7832b3216370..4cc581af2d96 100644
--- a/arch/arm64/kernel/armv8_deprecated.c
+++ b/arch/arm64/kernel/armv8_deprecated.c
@@ -630,7 +630,7 @@  static int __init armv8_deprecated_init(void)
 		register_insn_emulation(&cp15_barrier_ops);
 
 	if (IS_ENABLED(CONFIG_SETEND_EMULATION)) {
-		if(system_supports_mixed_endian_el0())
+		if (system_supports_mixed_endian_el0())
 			register_insn_emulation(&setend_ops);
 		else
 			pr_info("setend instruction emulation is not supported on this system\n");