diff mbox series

ARM: dts: imx27-phytec-phycard-s-rdk: Fix the I2C1 pinctrl entries

Message ID 20200327133624.26160-1-festevam@gmail.com (mailing list archive)
State Mainlined
Commit 0caf34350a25907515d929a9c77b9b206aac6d1e
Headers show
Series ARM: dts: imx27-phytec-phycard-s-rdk: Fix the I2C1 pinctrl entries | expand

Commit Message

Fabio Estevam March 27, 2020, 1:36 p.m. UTC
The I2C2 pins are already used and the following errors are seen:

imx27-pinctrl 10015000.iomuxc: pin MX27_PAD_I2C2_SDA already requested by 10012000.i2c; cannot claim for 1001d000.i2c
imx27-pinctrl 10015000.iomuxc: pin-69 (1001d000.i2c) status -22
imx27-pinctrl 10015000.iomuxc: could not request pin 69 (MX27_PAD_I2C2_SDA) from group i2c2grp  on device 10015000.iomuxc
imx-i2c 1001d000.i2c: Error applying setting, reverse things back
imx-i2c: probe of 1001d000.i2c failed with error -22

Fix it by adding the correct I2C1 IOMUX entries for the pinctrl_i2c1 group.

Cc: <stable@vger.kernel.org> 
Fixes: 61664d0b432a ("ARM: dts: imx27 phyCARD-S pinctrl")
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
 arch/arm/boot/dts/imx27-phytec-phycard-s-rdk.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Stefan Riedmueller March 27, 2020, 1:55 p.m. UTC | #1
Hi Fabio,

-----Fabio Estevam <festevam@gmail.com> schrieb: -----

>An: shawnguo@kernel.org
>Von: Fabio Estevam <festevam@gmail.com>
>Datum: 27.03.2020 14:36
>Kopie: kernel@pengutronix.de, c.hemp@phytec.de,
>s.riedmueller@phytec.de, linux-arm-kernel@lists.infradead.org, Fabio
>Estevam <festevam@gmail.com>, stable@vger.kernel.org
>Betreff: [PATCH] ARM: dts: imx27-phytec-phycard-s-rdk: Fix the I2C1
>pinctrl entries
>
>The I2C2 pins are already used and the following errors are seen:
>
>imx27-pinctrl 10015000.iomuxc: pin MX27_PAD_I2C2_SDA already
>requested by 10012000.i2c; cannot claim for 1001d000.i2c
>imx27-pinctrl 10015000.iomuxc: pin-69 (1001d000.i2c) status -22
>imx27-pinctrl 10015000.iomuxc: could not request pin 69
>(MX27_PAD_I2C2_SDA) from group i2c2grp  on device 10015000.iomuxc
>imx-i2c 1001d000.i2c: Error applying setting, reverse things back
>imx-i2c: probe of 1001d000.i2c failed with error -22
>
>Fix it by adding the correct I2C1 IOMUX entries for the pinctrl_i2c1
>group.
>
>Cc: <stable@vger.kernel.org> 
>Fixes: 61664d0b432a ("ARM: dts: imx27 phyCARD-S pinctrl")
>Signed-off-by: Fabio Estevam <festevam@gmail.com>
>---
> arch/arm/boot/dts/imx27-phytec-phycard-s-rdk.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/arch/arm/boot/dts/imx27-phytec-phycard-s-rdk.dts
>b/arch/arm/boot/dts/imx27-phytec-phycard-s-rdk.dts
>index 0cd75dadf292..188639738dc3 100644
>--- a/arch/arm/boot/dts/imx27-phytec-phycard-s-rdk.dts
>+++ b/arch/arm/boot/dts/imx27-phytec-phycard-s-rdk.dts
>@@ -75,8 +75,8 @@
>  imx27-phycard-s-rdk {
> 		pinctrl_i2c1: i2c1grp {
> 			fsl,pins = <
>-				MX27_PAD_I2C2_SDA__I2C2_SDA 0x0
>-				MX27_PAD_I2C2_SCL__I2C2_SCL 0x0
>+				MX27_PAD_I2C_DATA__I2C_DATA 0x0
>+				MX27_PAD_I2C_CLK__I2C_CLK 0x0
> 			>;
> 		};
> 
>--

Reviewed-by: Stefan Riedmueller <s.riedmueller@phytec.de>
 
>2.17.1
>
>
Shawn Guo April 23, 2020, 2:49 p.m. UTC | #2
On Fri, Mar 27, 2020 at 10:36:24AM -0300, Fabio Estevam wrote:
> The I2C2 pins are already used and the following errors are seen:
> 
> imx27-pinctrl 10015000.iomuxc: pin MX27_PAD_I2C2_SDA already requested by 10012000.i2c; cannot claim for 1001d000.i2c
> imx27-pinctrl 10015000.iomuxc: pin-69 (1001d000.i2c) status -22
> imx27-pinctrl 10015000.iomuxc: could not request pin 69 (MX27_PAD_I2C2_SDA) from group i2c2grp  on device 10015000.iomuxc
> imx-i2c 1001d000.i2c: Error applying setting, reverse things back
> imx-i2c: probe of 1001d000.i2c failed with error -22
> 
> Fix it by adding the correct I2C1 IOMUX entries for the pinctrl_i2c1 group.
> 
> Cc: <stable@vger.kernel.org> 
> Fixes: 61664d0b432a ("ARM: dts: imx27 phyCARD-S pinctrl")
> Signed-off-by: Fabio Estevam <festevam@gmail.com>

Applied, thanks.
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/imx27-phytec-phycard-s-rdk.dts b/arch/arm/boot/dts/imx27-phytec-phycard-s-rdk.dts
index 0cd75dadf292..188639738dc3 100644
--- a/arch/arm/boot/dts/imx27-phytec-phycard-s-rdk.dts
+++ b/arch/arm/boot/dts/imx27-phytec-phycard-s-rdk.dts
@@ -75,8 +75,8 @@ 
 	imx27-phycard-s-rdk {
 		pinctrl_i2c1: i2c1grp {
 			fsl,pins = <
-				MX27_PAD_I2C2_SDA__I2C2_SDA 0x0
-				MX27_PAD_I2C2_SCL__I2C2_SCL 0x0
+				MX27_PAD_I2C_DATA__I2C_DATA 0x0
+				MX27_PAD_I2C_CLK__I2C_CLK 0x0
 			>;
 		};