diff mbox series

[RFC,v1,48/50] arch/arm/kernel/process.c: Use get_random_max32() for sigpage_addr()

Message ID 202003281643.02SGhPfO016133@sdf.org (mailing list archive)
State New, archived
Headers show
Series None | expand

Commit Message

George Spelvin Nov. 29, 2019, 11:57 p.m. UTC 
Which is faster and less biased than get_random_int() % range

Signed-off-by: George Spelvin <lkml@sdf.org>
Cc: Nathan Lynch <nathan_lynch@mentor.com>
Cc: Dmitry Safonov <0x7f454c46@gmail.com>
Cc: Russell King <linux@armlinux.org.uk>
Cc: linux-arm-kernel@lists.infradead.org
---
 arch/arm/kernel/process.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
index 46e478fb5ea20..9f2556be33505 100644
--- a/arch/arm/kernel/process.c
+++ b/arch/arm/kernel/process.c
@@ -391,7 +391,7 @@  static unsigned long sigpage_addr(const struct mm_struct *mm,
 
 	slots = ((last - first) >> PAGE_SHIFT) + 1;
 
-	offset = get_random_int() % slots;
+	offset = get_random_max32(slots);
 
 	addr = first + (offset << PAGE_SHIFT);