| Message ID | 20200413082224.23090-1-yanaijie@huawei.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | ebd9b6785099ffd029c7ec2ddb133dea53a65f2b |
| Headers | show |
| Series | coresight: cti: make some symbols static | expand |
On Mon, Apr 13, 2020 at 04:22:24PM +0800, Jason Yan wrote: > Fix the following sparse warning: > > drivers/hwtracing/coresight/coresight-cti.c:22:1: warning: symbol > 'ect_net' was not declared. Should it be static? > drivers/hwtracing/coresight/coresight-cti.c:625:32: warning: symbol > 'cti_ops_ect' was not declared. Should it be static? > drivers/hwtracing/coresight/coresight-cti.c:630:28: warning: symbol > 'cti_ops' was not declared. Should it be static? > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Jason Yan <yanaijie@huawei.com> > --- > drivers/hwtracing/coresight/coresight-cti.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-cti.c b/drivers/hwtracing/coresight/coresight-cti.c > index 9e262f5a85e3..7fc1fc8d7738 100644 > --- a/drivers/hwtracing/coresight/coresight-cti.c > +++ b/drivers/hwtracing/coresight/coresight-cti.c > @@ -19,7 +19,7 @@ > */ > > /* net of CTI devices connected via CTM */ > -LIST_HEAD(ect_net); > +static LIST_HEAD(ect_net); > > /* protect the list */ > static DEFINE_MUTEX(ect_mutex); > @@ -622,12 +622,12 @@ int cti_disable(struct coresight_device *csdev) > return cti_disable_hw(drvdata); > } > > -const struct coresight_ops_ect cti_ops_ect = { > +static const struct coresight_ops_ect cti_ops_ect = { > .enable = cti_enable, > .disable = cti_disable, > }; > > -const struct coresight_ops cti_ops = { > +static const struct coresight_ops cti_ops = { > .ect_ops = &cti_ops_ect, > }; Applied - thanks, Mathieu > > -- > 2.21.1 >
diff --git a/drivers/hwtracing/coresight/coresight-cti.c b/drivers/hwtracing/coresight/coresight-cti.c index 9e262f5a85e3..7fc1fc8d7738 100644 --- a/drivers/hwtracing/coresight/coresight-cti.c +++ b/drivers/hwtracing/coresight/coresight-cti.c @@ -19,7 +19,7 @@ */ /* net of CTI devices connected via CTM */ -LIST_HEAD(ect_net); +static LIST_HEAD(ect_net); /* protect the list */ static DEFINE_MUTEX(ect_mutex); @@ -622,12 +622,12 @@ int cti_disable(struct coresight_device *csdev) return cti_disable_hw(drvdata); } -const struct coresight_ops_ect cti_ops_ect = { +static const struct coresight_ops_ect cti_ops_ect = { .enable = cti_enable, .disable = cti_disable, }; -const struct coresight_ops cti_ops = { +static const struct coresight_ops cti_ops = { .ect_ops = &cti_ops_ect, };
Fix the following sparse warning: drivers/hwtracing/coresight/coresight-cti.c:22:1: warning: symbol 'ect_net' was not declared. Should it be static? drivers/hwtracing/coresight/coresight-cti.c:625:32: warning: symbol 'cti_ops_ect' was not declared. Should it be static? drivers/hwtracing/coresight/coresight-cti.c:630:28: warning: symbol 'cti_ops' was not declared. Should it be static? Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Jason Yan <yanaijie@huawei.com> --- drivers/hwtracing/coresight/coresight-cti.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)