| Message ID | 20200413082237.23177-1-yanaijie@huawei.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 1c33c65cfea76d3dd92730353aac20f876c45747 |
| Headers | show |
| Series | coresight: etb10: make coresight_etb_groups static | expand |
On Mon, Apr 13, 2020 at 04:22:37PM +0800, Jason Yan wrote: > Fix the following sparse warning: > > drivers/hwtracing/coresight/coresight-etb10.c:720:30: warning: symbol > 'coresight_etb_groups' was not declared. Should it be static? > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Jason Yan <yanaijie@huawei.com> > --- > drivers/hwtracing/coresight/coresight-etb10.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hwtracing/coresight/coresight-etb10.c b/drivers/hwtracing/coresight/coresight-etb10.c > index 3810290e6d07..03e3f2590191 100644 > --- a/drivers/hwtracing/coresight/coresight-etb10.c > +++ b/drivers/hwtracing/coresight/coresight-etb10.c > @@ -717,7 +717,7 @@ static const struct attribute_group coresight_etb_mgmt_group = { > .name = "mgmt", > }; > > -const struct attribute_group *coresight_etb_groups[] = { > +static const struct attribute_group *coresight_etb_groups[] = { > &coresight_etb_group, > &coresight_etb_mgmt_group, > NULL, Applied - thanks, Mathieu > -- > 2.21.1 >
diff --git a/drivers/hwtracing/coresight/coresight-etb10.c b/drivers/hwtracing/coresight/coresight-etb10.c index 3810290e6d07..03e3f2590191 100644 --- a/drivers/hwtracing/coresight/coresight-etb10.c +++ b/drivers/hwtracing/coresight/coresight-etb10.c @@ -717,7 +717,7 @@ static const struct attribute_group coresight_etb_mgmt_group = { .name = "mgmt", }; -const struct attribute_group *coresight_etb_groups[] = { +static const struct attribute_group *coresight_etb_groups[] = { &coresight_etb_group, &coresight_etb_mgmt_group, NULL,
Fix the following sparse warning: drivers/hwtracing/coresight/coresight-etb10.c:720:30: warning: symbol 'coresight_etb_groups' was not declared. Should it be static? Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Jason Yan <yanaijie@huawei.com> --- drivers/hwtracing/coresight/coresight-etb10.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)