diff mbox series

[v3,2/3] dt-bindings: counter: microchip-tcb-capture counter

Message ID 20200415130455.2222019-3-kamel.bouhara@bootlin.com (mailing list archive)
State New, archived
Headers show
Series Microchip TCB Capture driver | expand

Commit Message

Kamel BOUHARA April 15, 2020, 1:04 p.m. UTC
Describe the devicetree binding for the Microchip TCB module.
Each counter blocks exposes three independent counters.

However, when configured in quadrature decoder, both channel <0> and <1>
are required for speed/position and rotation capture (yet only the
position is captured).

Signed-off-by: Kamel Bouhara <kamel.bouhara@bootlin.com>
---
Changes from v3:
 - Updated the brand name: s/atmel/microchip/.

Changes from v2:
 - Fixed errors reported by dt_binding_check

 .../counter/microchip-tcb-capture.yaml        | 33 +++++++++++++++++++
 1 file changed, 33 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/counter/microchip-tcb-capture.yaml

Comments

William Breathitt Gray April 17, 2020, 1:58 p.m. UTC | #1
On Wed, Apr 15, 2020 at 03:04:54PM +0200, Kamel Bouhara wrote:
> Describe the devicetree binding for the Microchip TCB module.
> Each counter blocks exposes three independent counters.
> 
> However, when configured in quadrature decoder, both channel <0> and <1>
> are required for speed/position and rotation capture (yet only the
> position is captured).
> 
> Signed-off-by: Kamel Bouhara <kamel.bouhara@bootlin.com>

Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>

> ---
> Changes from v3:
>  - Updated the brand name: s/atmel/microchip/.
> 
> Changes from v2:
>  - Fixed errors reported by dt_binding_check
> 
>  .../counter/microchip-tcb-capture.yaml        | 33 +++++++++++++++++++
>  1 file changed, 33 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/counter/microchip-tcb-capture.yaml
> 
> diff --git a/Documentation/devicetree/bindings/counter/microchip-tcb-capture.yaml b/Documentation/devicetree/bindings/counter/microchip-tcb-capture.yaml
> new file mode 100644
> index 000000000000..183e9ee4c049
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/counter/microchip-tcb-capture.yaml
> @@ -0,0 +1,33 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/counter/microchip-tcb-capture.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Microchip TCB Counter
> +
> +maintainers:
> +  - Kamel Bouhara <kamel.bouhara@bootlin.com>
> +
> +properties:
> +  compatible:
> +    const: "microchip,tcb-capture"
> +
> +  reg:
> +    description: TCB capture channel to register as counter device.
> +      Each channel is independent therefore only one channel is
> +      registered by default execpt for the QDEC mode where both TCB0's
> +      channels <0> and  <1> are required.
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    tcb0: timer@f800c000 {
> +        compatible = "microchip,tcb-capture";
> +        reg = <0>, <1>;
> +    };
> -- 
> 2.25.0
>
Jonathan Cameron April 18, 2020, 6:24 p.m. UTC | #2
On Fri, 17 Apr 2020 09:58:20 -0400
William Breathitt Gray <vilhelm.gray@gmail.com> wrote:

> On Wed, Apr 15, 2020 at 03:04:54PM +0200, Kamel Bouhara wrote:
> > Describe the devicetree binding for the Microchip TCB module.
> > Each counter blocks exposes three independent counters.
> > 
> > However, when configured in quadrature decoder, both channel <0> and <1>
> > are required for speed/position and rotation capture (yet only the
> > position is captured).
> > 
> > Signed-off-by: Kamel Bouhara <kamel.bouhara@bootlin.com>  
> 
> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
Will let this sit a bit longer to let the DT maintainers have an opportunity
to take a look.

Thanks,

Jonathan

> 
> > ---
> > Changes from v3:
> >  - Updated the brand name: s/atmel/microchip/.
> > 
> > Changes from v2:
> >  - Fixed errors reported by dt_binding_check
> > 
> >  .../counter/microchip-tcb-capture.yaml        | 33 +++++++++++++++++++
> >  1 file changed, 33 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/counter/microchip-tcb-capture.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/counter/microchip-tcb-capture.yaml b/Documentation/devicetree/bindings/counter/microchip-tcb-capture.yaml
> > new file mode 100644
> > index 000000000000..183e9ee4c049
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/counter/microchip-tcb-capture.yaml
> > @@ -0,0 +1,33 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/counter/microchip-tcb-capture.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Microchip TCB Counter
> > +
> > +maintainers:
> > +  - Kamel Bouhara <kamel.bouhara@bootlin.com>
> > +
> > +properties:
> > +  compatible:
> > +    const: "microchip,tcb-capture"
> > +
> > +  reg:
> > +    description: TCB capture channel to register as counter device.
> > +      Each channel is independent therefore only one channel is
> > +      registered by default execpt for the QDEC mode where both TCB0's
> > +      channels <0> and  <1> are required.
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    tcb0: timer@f800c000 {
> > +        compatible = "microchip,tcb-capture";
> > +        reg = <0>, <1>;
> > +    };
> > -- 
> > 2.25.0
> >
Rob Herring (Arm) April 20, 2020, 10:21 p.m. UTC | #3
On Wed, Apr 15, 2020 at 03:04:54PM +0200, Kamel Bouhara wrote:
> Describe the devicetree binding for the Microchip TCB module.
> Each counter blocks exposes three independent counters.
> 
> However, when configured in quadrature decoder, both channel <0> and <1>
> are required for speed/position and rotation capture (yet only the
> position is captured).

This is a child of the TCB, right? If so, it needs to be merged with the 
TCB schema Alexandre is working on.

> 
> Signed-off-by: Kamel Bouhara <kamel.bouhara@bootlin.com>
> ---
> Changes from v3:
>  - Updated the brand name: s/atmel/microchip/.
> 
> Changes from v2:
>  - Fixed errors reported by dt_binding_check
> 
>  .../counter/microchip-tcb-capture.yaml        | 33 +++++++++++++++++++
>  1 file changed, 33 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/counter/microchip-tcb-capture.yaml
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/counter/microchip-tcb-capture.yaml b/Documentation/devicetree/bindings/counter/microchip-tcb-capture.yaml
new file mode 100644
index 000000000000..183e9ee4c049
--- /dev/null
+++ b/Documentation/devicetree/bindings/counter/microchip-tcb-capture.yaml
@@ -0,0 +1,33 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/counter/microchip-tcb-capture.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Microchip TCB Counter
+
+maintainers:
+  - Kamel Bouhara <kamel.bouhara@bootlin.com>
+
+properties:
+  compatible:
+    const: "microchip,tcb-capture"
+
+  reg:
+    description: TCB capture channel to register as counter device.
+      Each channel is independent therefore only one channel is
+      registered by default execpt for the QDEC mode where both TCB0's
+      channels <0> and  <1> are required.
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    tcb0: timer@f800c000 {
+        compatible = "microchip,tcb-capture";
+        reg = <0>, <1>;
+    };