| Message ID | 20200425022409.2093354-1-brian@tarricone.org (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 1383d42cffa68c03d886ae846b3e3f6e3bbd784c |
| Headers | show |
| Series | arm/dts: Add DT block for Netgear ReadyNAS NV+ v2 LCD panel | expand |
On Fri, Apr 24, 2020 at 07:24:09PM -0700, Brian J. Tarricone wrote: > The NV+ v2 has a WH1602 LCD panel (which is just a rebranded HD44780), > similar to the Netgear RN104, just with different GPIO assignments. > > Signed-off-by: Brian J. Tarricone <brian@tarricone.org> Hi Brian The change itself looks O.K. However, please could you change the subject to follow what other kirkwood DT patches use: arch/arm/boot/dts$ git log --oneline kirkwood-* 15382b7ea298 ARM: dts: kirkwood: synology: Fix rs5c372 RTC entry 644763224169 ARM: dts: kirkwood: ts219: disable the SoC's RTC 6a3b25173cd4 arch: arm: dts: kirkwood-rd88f6281: Remove disabled marvell,dsa reference cb92e40411ef arch: arm: dts: Remove disabled marvell,dsa properties b5f034845e70 ARM: dts: kirkwood: Fix polarity of GPIO fan lines eb59e0920331 arm: dts: kirkwood*.dts: use SPDX-License-Identifier for board using GPL-2.0+ b3820aa10c1b arm: dts: kirkwood*.dts: use SPDX-License-Identifier for boards using GPL-2.0+/MIT e7822263a7a5 arm: dts: kirkwood*.dts: use SPDX-License-Identifier for boards using GPL-2.0 5beaf4d7ce9e ARM: dts: kirkwood: Fix "debounce-interval" property misspelling Yes, there is a bit of variance, but something like ARM: dts: kirkwood: Readynas nv2: Add LCD panel Thanks Andrew
diff --git a/arch/arm/boot/dts/kirkwood-netgear_readynas_nv+_v2.dts b/arch/arm/boot/dts/kirkwood-netgear_readynas_nv+_v2.dts index 8cc8550242ef..b13aee570804 100644 --- a/arch/arm/boot/dts/kirkwood-netgear_readynas_nv+_v2.dts +++ b/arch/arm/boot/dts/kirkwood-netgear_readynas_nv+_v2.dts @@ -113,6 +113,20 @@ sata@80000 { /* Connected to Marvell 88SM4140 SATA port multiplier */ }; }; + auxdisplay { + compatible = "hit,hd44780"; + data-gpios = <&gpio0 17 GPIO_ACTIVE_HIGH>, + <&gpio1 1 GPIO_ACTIVE_HIGH>, + <&gpio1 3 GPIO_ACTIVE_HIGH>, + <&gpio1 17 GPIO_ACTIVE_HIGH>; + enable-gpios = <&gpio0 16 GPIO_ACTIVE_HIGH>; + rs-gpios = <&gpio0 14 GPIO_ACTIVE_HIGH>; + rw-gpios = <&gpio0 15 GPIO_ACTIVE_HIGH>; + backlight-gpios = <&gpio0 12 GPIO_ACTIVE_LOW>; + display-height-chars = <2>; + display-width-chars = <16>; + }; + gpio-leds { compatible = "gpio-leds"; pinctrl-0 = < &pmx_led_blue_power &pmx_led_blue_backup
The NV+ v2 has a WH1602 LCD panel (which is just a rebranded HD44780), similar to the Netgear RN104, just with different GPIO assignments. Signed-off-by: Brian J. Tarricone <brian@tarricone.org> --- .../boot/dts/kirkwood-netgear_readynas_nv+_v2.dts | 14 ++++++++++++++ 1 file changed, 14 insertions(+)