diff mbox series

ARM: dts: kirkwood: ReadyNAS NV+v2: Add LCD panel

Message ID 20200425192820.2499185-1-brian@tarricone.org (mailing list archive)
State Mainlined
Commit 1383d42cffa68c03d886ae846b3e3f6e3bbd784c
Headers show
Series ARM: dts: kirkwood: ReadyNAS NV+v2: Add LCD panel | expand

Commit Message

Brian J. Tarricone April 25, 2020, 7:28 p.m. UTC
The NV+ v2 has a WH1602 LCD panel (which is just a rebranded HD44780),
similar to the Netgear RN104, just with different GPIO assignments.

Signed-off-by: Brian J. Tarricone <brian@tarricone.org>
---
 .../boot/dts/kirkwood-netgear_readynas_nv+_v2.dts  | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

Comments

Andrew Lunn April 25, 2020, 8:14 p.m. UTC | #1
On Sat, Apr 25, 2020 at 12:28:20PM -0700, Brian J. Tarricone wrote:
> The NV+ v2 has a WH1602 LCD panel (which is just a rebranded HD44780),
> similar to the Netgear RN104, just with different GPIO assignments.
> 
> Signed-off-by: Brian J. Tarricone <brian@tarricone.org>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

Hi Brian

FYI: Since this is the second version, the Subject: should be:

[PATCH v2] ARM: dts: kirkwood: ReadyNAS NV+v2: Add LCD panel

It helps us keep track of which is the last version and so should be
merged. No need to repost, but please try to remember for future
patches you submit.

Thanks

    Andrew
Gregory CLEMENT May 17, 2020, 4:52 p.m. UTC | #2
Hi Brian,

> The NV+ v2 has a WH1602 LCD panel (which is just a rebranded HD44780),
> similar to the Netgear RN104, just with different GPIO assignments.
>
> Signed-off-by: Brian J. Tarricone <brian@tarricone.org>


Applied on mvebu/dt

Thanks,

Gregory

> ---
>  .../boot/dts/kirkwood-netgear_readynas_nv+_v2.dts  | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm/boot/dts/kirkwood-netgear_readynas_nv+_v2.dts b/arch/arm/boot/dts/kirkwood-netgear_readynas_nv+_v2.dts
> index 8cc8550242ef..b13aee570804 100644
> --- a/arch/arm/boot/dts/kirkwood-netgear_readynas_nv+_v2.dts
> +++ b/arch/arm/boot/dts/kirkwood-netgear_readynas_nv+_v2.dts
> @@ -113,6 +113,20 @@ sata@80000 { /* Connected to Marvell 88SM4140 SATA port multiplier */
>  		};
>  	};
>  
> +	auxdisplay {
> +		compatible = "hit,hd44780";
> +		data-gpios = <&gpio0 17 GPIO_ACTIVE_HIGH>,
> +				<&gpio1 1 GPIO_ACTIVE_HIGH>,
> +				<&gpio1 3 GPIO_ACTIVE_HIGH>,
> +				<&gpio1 17 GPIO_ACTIVE_HIGH>;
> +		enable-gpios = <&gpio0 16 GPIO_ACTIVE_HIGH>;
> +		rs-gpios = <&gpio0 14 GPIO_ACTIVE_HIGH>;
> +		rw-gpios = <&gpio0 15 GPIO_ACTIVE_HIGH>;
> +		backlight-gpios = <&gpio0 12 GPIO_ACTIVE_LOW>;
> +		display-height-chars = <2>;
> +		display-width-chars = <16>;
> +	};
> +
>  	gpio-leds {
>  		compatible = "gpio-leds";
>  		pinctrl-0 = < &pmx_led_blue_power &pmx_led_blue_backup
> -- 
> 2.26.2
>
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/kirkwood-netgear_readynas_nv+_v2.dts b/arch/arm/boot/dts/kirkwood-netgear_readynas_nv+_v2.dts
index 8cc8550242ef..b13aee570804 100644
--- a/arch/arm/boot/dts/kirkwood-netgear_readynas_nv+_v2.dts
+++ b/arch/arm/boot/dts/kirkwood-netgear_readynas_nv+_v2.dts
@@ -113,6 +113,20 @@  sata@80000 { /* Connected to Marvell 88SM4140 SATA port multiplier */
 		};
 	};
 
+	auxdisplay {
+		compatible = "hit,hd44780";
+		data-gpios = <&gpio0 17 GPIO_ACTIVE_HIGH>,
+				<&gpio1 1 GPIO_ACTIVE_HIGH>,
+				<&gpio1 3 GPIO_ACTIVE_HIGH>,
+				<&gpio1 17 GPIO_ACTIVE_HIGH>;
+		enable-gpios = <&gpio0 16 GPIO_ACTIVE_HIGH>;
+		rs-gpios = <&gpio0 14 GPIO_ACTIVE_HIGH>;
+		rw-gpios = <&gpio0 15 GPIO_ACTIVE_HIGH>;
+		backlight-gpios = <&gpio0 12 GPIO_ACTIVE_LOW>;
+		display-height-chars = <2>;
+		display-width-chars = <16>;
+	};
+
 	gpio-leds {
 		compatible = "gpio-leds";
 		pinctrl-0 = < &pmx_led_blue_power &pmx_led_blue_backup