| Message ID | 20200428115543.33379-1-yanaijie@huawei.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 0320d260a7e730f1a85c49764ad8d8c41a8512ec |
| Headers | show |
| Series | pinctrl: add pwm37 to bm1880_pctrl_groups | expand |
On Tue, Apr 28, 2020 at 07:55:43PM +0800, Jason Yan wrote: > The 'pwm37' is not added to bm1880_pctrl_groups, which triggers a gcc > build warning: > > drivers/pinctrl/pinctrl-bm1880.c:263:27: warning: ‘pwm37_pins’ defined > but not used [-Wunused-const-variable=] > static const unsigned int pwm37_pins[] = { 110 }; > > Signed-off-by: Jason Yan <yanaijie@huawei.com> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Thanks, Mani > --- > drivers/pinctrl/pinctrl-bm1880.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pinctrl/pinctrl-bm1880.c b/drivers/pinctrl/pinctrl-bm1880.c > index f7dff4f14101..d1a7d9836787 100644 > --- a/drivers/pinctrl/pinctrl-bm1880.c > +++ b/drivers/pinctrl/pinctrl-bm1880.c > @@ -408,6 +408,7 @@ static const struct bm1880_pctrl_group bm1880_pctrl_groups[] = { > BM1880_PINCTRL_GRP(pwm34), > BM1880_PINCTRL_GRP(pwm35), > BM1880_PINCTRL_GRP(pwm36), > + BM1880_PINCTRL_GRP(pwm37), > BM1880_PINCTRL_GRP(i2c0), > BM1880_PINCTRL_GRP(i2c1), > BM1880_PINCTRL_GRP(i2c2), > -- > 2.21.1 >
On Tue, Apr 28, 2020 at 1:56 PM Jason Yan <yanaijie@huawei.com> wrote: > The 'pwm37' is not added to bm1880_pctrl_groups, which triggers a gcc > build warning: > > drivers/pinctrl/pinctrl-bm1880.c:263:27: warning: ‘pwm37_pins’ defined > but not used [-Wunused-const-variable=] > static const unsigned int pwm37_pins[] = { 110 }; > > Signed-off-by: Jason Yan <yanaijie@huawei.com> Patch applied! Yours, Linus Walleij
diff --git a/drivers/pinctrl/pinctrl-bm1880.c b/drivers/pinctrl/pinctrl-bm1880.c index f7dff4f14101..d1a7d9836787 100644 --- a/drivers/pinctrl/pinctrl-bm1880.c +++ b/drivers/pinctrl/pinctrl-bm1880.c @@ -408,6 +408,7 @@ static const struct bm1880_pctrl_group bm1880_pctrl_groups[] = { BM1880_PINCTRL_GRP(pwm34), BM1880_PINCTRL_GRP(pwm35), BM1880_PINCTRL_GRP(pwm36), + BM1880_PINCTRL_GRP(pwm37), BM1880_PINCTRL_GRP(i2c0), BM1880_PINCTRL_GRP(i2c1), BM1880_PINCTRL_GRP(i2c2),
The 'pwm37' is not added to bm1880_pctrl_groups, which triggers a gcc build warning: drivers/pinctrl/pinctrl-bm1880.c:263:27: warning: ‘pwm37_pins’ defined but not used [-Wunused-const-variable=] static const unsigned int pwm37_pins[] = { 110 }; Signed-off-by: Jason Yan <yanaijie@huawei.com> --- drivers/pinctrl/pinctrl-bm1880.c | 1 + 1 file changed, 1 insertion(+)