| Message ID | 20200429205825.10604-6-robh@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Modularizing Versatile Express | expand |
On Wed, Apr 29, 2020 at 03:58:14PM -0500, Rob Herring wrote: > While 64-bit Arm reference platforms have SP810 for clocks for SP804 > timers, they are not needed since the arch timers are used instead. > > Cc: Catalin Marinas <catalin.marinas@arm.com> > Cc: Will Deacon <will@kernel.org> > Cc: Sudeep Holla <sudeep.holla@arm.com> With a note below for sake of information, Reviewed-by: Sudeep Holla <sudeep.holla@arm.com> > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Stephen Boyd <sboyd@kernel.org> > Cc: linux-clk@vger.kernel.org > Acked-by: Arnd Bergmann <arnd@arndb.de> > Acked-by: Liviu Dudau <liviu.dudau@arm.com> > Signed-off-by: Rob Herring <robh@kernel.org> > --- > drivers/clk/versatile/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/versatile/Kconfig b/drivers/clk/versatile/Kconfig > index df0d50bb846c..a47dd6c86d2e 100644 > --- a/drivers/clk/versatile/Kconfig > +++ b/drivers/clk/versatile/Kconfig > @@ -17,7 +17,7 @@ config ICST > > config CLK_SP810 > bool "Clock driver for ARM SP810 System Controller" > - default y if ARCH_VEXPRESS > + default y if (ARCH_VEXPRESS && ARM) Just note that SP804 is selected by ARCH_HISILICON and ARCH_BRCM or something for Raspberry Pi. So, this will result in the warnings on Juno like: sp804: timer clock not found: -517 sp804: arm,sp804 clock not found: -2 sp804: timer clock not found: -517 sp804: arm,sp804 clock not found: -2 This can be ignored as we rely on arch-timers and they are just there in DT for completion. We can disable them in DT if that's fine ?
Quoting Rob Herring (2020-04-29 13:58:14) > While 64-bit Arm reference platforms have SP810 for clocks for SP804 > timers, they are not needed since the arch timers are used instead. > > Cc: Catalin Marinas <catalin.marinas@arm.com> > Cc: Will Deacon <will@kernel.org> > Cc: Sudeep Holla <sudeep.holla@arm.com> > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Stephen Boyd <sboyd@kernel.org> > Cc: linux-clk@vger.kernel.org > Acked-by: Arnd Bergmann <arnd@arndb.de> > Acked-by: Liviu Dudau <liviu.dudau@arm.com> > Signed-off-by: Rob Herring <robh@kernel.org> > --- Reviewed-by: Stephen Boyd <sboyd@kernel.org>
diff --git a/drivers/clk/versatile/Kconfig b/drivers/clk/versatile/Kconfig index df0d50bb846c..a47dd6c86d2e 100644 --- a/drivers/clk/versatile/Kconfig +++ b/drivers/clk/versatile/Kconfig @@ -17,7 +17,7 @@ config ICST config CLK_SP810 bool "Clock driver for ARM SP810 System Controller" - default y if ARCH_VEXPRESS + default y if (ARCH_VEXPRESS && ARM) ---help--- Supports clock muxing (REFCLK/TIMCLK to TIMERCLKEN0-3) capabilities of the ARM SP810 System Controller cell.