| Message ID | 20200505073308.22914-3-benjamin.gaignard@st.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | STM32 ETZPC bus controller | expand |
On Tue, May 05, 2020 at 09:33:05AM +0200, Benjamin Gaignard wrote: > The goal of these helpers are to offer an interface for the > hardware blocks controlling bus accesses rights. > > Bus firewall controllers are typically used to control if a > hardware block can perform read or write operations on bus. > > Smarter firewall controllers could be able to define accesses > rights per hardware blocks to control where they can read > or write. > > Firewall controller configurations are provided in device node, > parsed by the helpers and send to the driver to apply them. > Each controller may need different number and type of inputs > to configure the firewall so device-tree properties size have to > be define by using "#firewall-cells". > Firewall configurations properties have to be named "firewall-X" > on device node. > "firewall-names" keyword can also be used to give a name to > a specific configuration. > > Example of device-tree: > ctrl0: firewall@0 { > #firewall-cells = <2>; > }; > > foo: foo@0 { > firewall-names = "default", "setting1"; > firewall-0 = <&ctrl0 1 2>; > firewall-1 = <&ctrl0 3 4>; > }; > > Configurations could be applied with functions like > firewall_set_config_by_index() or firewall_set_config_by_name(). > > firewall_set_default_config() function will apply the > configuration named "default" (if existing) or the configuration > with index 0 (i.e. firewall-0). > > Drivers could register/unregister themselves be calling > firewall_register/firewall_unregister functions. > > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com> > --- > drivers/bus/Kconfig | 2 + > drivers/bus/Makefile | 2 + > drivers/bus/stm32/Kconfig | 3 + > drivers/bus/stm32/Makefile | 1 + > drivers/bus/stm32/firewall.c | 266 +++++++++++++++++++++++++++++++++++++++++++ > drivers/bus/stm32/firewall.h | 75 ++++++++++++ > 6 files changed, 349 insertions(+) > create mode 100644 drivers/bus/stm32/Kconfig > create mode 100644 drivers/bus/stm32/Makefile > create mode 100644 drivers/bus/stm32/firewall.c > create mode 100644 drivers/bus/stm32/firewall.h > > diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig > index 6d4e4497b59b..843b356322d9 100644 > --- a/drivers/bus/Kconfig > +++ b/drivers/bus/Kconfig > @@ -203,4 +203,6 @@ config DA8XX_MSTPRI > source "drivers/bus/fsl-mc/Kconfig" > source "drivers/bus/mhi/Kconfig" > > +source "drivers/bus/stm32/Kconfig" > + > endmenu > diff --git a/drivers/bus/Makefile b/drivers/bus/Makefile > index 05f32cd694a4..5e0e34b10235 100644 > --- a/drivers/bus/Makefile > +++ b/drivers/bus/Makefile > @@ -37,3 +37,5 @@ obj-$(CONFIG_DA8XX_MSTPRI) += da8xx-mstpri.o > > # MHI > obj-$(CONFIG_MHI_BUS) += mhi/ > + > +obj-$(CONFIG_MACH_STM32MP157) += stm32/ > \ No newline at end of file > diff --git a/drivers/bus/stm32/Kconfig b/drivers/bus/stm32/Kconfig > new file mode 100644 > index 000000000000..57221e833e2d > --- /dev/null > +++ b/drivers/bus/stm32/Kconfig > @@ -0,0 +1,3 @@ > +config FIREWALL_CONTROLLERS > + bool "Support of bus firewall controllers" > + depends on OF > diff --git a/drivers/bus/stm32/Makefile b/drivers/bus/stm32/Makefile > new file mode 100644 > index 000000000000..eb6b978d6450 > --- /dev/null > +++ b/drivers/bus/stm32/Makefile > @@ -0,0 +1 @@ > +obj-$(CONFIG_FIREWALL_CONTROLLERS) += firewall.o > diff --git a/drivers/bus/stm32/firewall.c b/drivers/bus/stm32/firewall.c > new file mode 100644 > index 000000000000..95f716cf926f > --- /dev/null > +++ b/drivers/bus/stm32/firewall.c > @@ -0,0 +1,266 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (C) STMicroelectronics 2020 - All Rights Reserved > + * Author: Benjamin Gaignard <benjamin.gaignard@st.com> for STMicroelectronics. > + */ > + > +#include <linux/device.h> > +#include <linux/err.h> > +#include <linux/init.h> > +#include <linux/kernel.h> > +#include <linux/list.h> > +#include <linux/of.h> > +#include <linux/slab.h> > + > +#include "firewall.h" > + > +/* Mutex taken to protect firewall_list */ > +static DEFINE_MUTEX(firewall_list_mutex); > + > +/* Global list of firewall control devices */ > +static LIST_HEAD(firewall_list); Why is that needed? Why can't you just walk the list of devices on this "bus/class" if you really wanted to? Along those lines, why is this going around the driver model and ignoring it? Shouldn't this be a bus and you have devices attached to it of the specific type? greg k-h
On 5/5/20 4:40 PM, Greg KH wrote: > On Tue, May 05, 2020 at 09:33:05AM +0200, Benjamin Gaignard wrote: >> The goal of these helpers are to offer an interface for the >> hardware blocks controlling bus accesses rights. >> >> Bus firewall controllers are typically used to control if a >> hardware block can perform read or write operations on bus. >> >> Smarter firewall controllers could be able to define accesses >> rights per hardware blocks to control where they can read >> or write. >> >> Firewall controller configurations are provided in device node, >> parsed by the helpers and send to the driver to apply them. >> Each controller may need different number and type of inputs >> to configure the firewall so device-tree properties size have to >> be define by using "#firewall-cells". >> Firewall configurations properties have to be named "firewall-X" >> on device node. >> "firewall-names" keyword can also be used to give a name to >> a specific configuration. >> >> Example of device-tree: >> ctrl0: firewall@0 { >> #firewall-cells = <2>; >> }; >> >> foo: foo@0 { >> firewall-names = "default", "setting1"; >> firewall-0 = <&ctrl0 1 2>; >> firewall-1 = <&ctrl0 3 4>; >> }; >> >> Configurations could be applied with functions like >> firewall_set_config_by_index() or firewall_set_config_by_name(). >> >> firewall_set_default_config() function will apply the >> configuration named "default" (if existing) or the configuration >> with index 0 (i.e. firewall-0). >> >> Drivers could register/unregister themselves be calling >> firewall_register/firewall_unregister functions. >> >> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com> >> --- >> drivers/bus/Kconfig | 2 + >> drivers/bus/Makefile | 2 + >> drivers/bus/stm32/Kconfig | 3 + >> drivers/bus/stm32/Makefile | 1 + >> drivers/bus/stm32/firewall.c | 266 +++++++++++++++++++++++++++++++++++++++++++ >> drivers/bus/stm32/firewall.h | 75 ++++++++++++ >> 6 files changed, 349 insertions(+) >> create mode 100644 drivers/bus/stm32/Kconfig >> create mode 100644 drivers/bus/stm32/Makefile >> create mode 100644 drivers/bus/stm32/firewall.c >> create mode 100644 drivers/bus/stm32/firewall.h >> >> diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig >> index 6d4e4497b59b..843b356322d9 100644 >> --- a/drivers/bus/Kconfig >> +++ b/drivers/bus/Kconfig >> @@ -203,4 +203,6 @@ config DA8XX_MSTPRI >> source "drivers/bus/fsl-mc/Kconfig" >> source "drivers/bus/mhi/Kconfig" >> >> +source "drivers/bus/stm32/Kconfig" >> + >> endmenu >> diff --git a/drivers/bus/Makefile b/drivers/bus/Makefile >> index 05f32cd694a4..5e0e34b10235 100644 >> --- a/drivers/bus/Makefile >> +++ b/drivers/bus/Makefile >> @@ -37,3 +37,5 @@ obj-$(CONFIG_DA8XX_MSTPRI) += da8xx-mstpri.o >> >> # MHI >> obj-$(CONFIG_MHI_BUS) += mhi/ >> + >> +obj-$(CONFIG_MACH_STM32MP157) += stm32/ >> \ No newline at end of file >> diff --git a/drivers/bus/stm32/Kconfig b/drivers/bus/stm32/Kconfig >> new file mode 100644 >> index 000000000000..57221e833e2d >> --- /dev/null >> +++ b/drivers/bus/stm32/Kconfig >> @@ -0,0 +1,3 @@ >> +config FIREWALL_CONTROLLERS >> + bool "Support of bus firewall controllers" >> + depends on OF >> diff --git a/drivers/bus/stm32/Makefile b/drivers/bus/stm32/Makefile >> new file mode 100644 >> index 000000000000..eb6b978d6450 >> --- /dev/null >> +++ b/drivers/bus/stm32/Makefile >> @@ -0,0 +1 @@ >> +obj-$(CONFIG_FIREWALL_CONTROLLERS) += firewall.o >> diff --git a/drivers/bus/stm32/firewall.c b/drivers/bus/stm32/firewall.c >> new file mode 100644 >> index 000000000000..95f716cf926f >> --- /dev/null >> +++ b/drivers/bus/stm32/firewall.c >> @@ -0,0 +1,266 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +/* >> + * Copyright (C) STMicroelectronics 2020 - All Rights Reserved >> + * Author: Benjamin Gaignard <benjamin.gaignard@st.com> for STMicroelectronics. >> + */ >> + >> +#include <linux/device.h> >> +#include <linux/err.h> >> +#include <linux/init.h> >> +#include <linux/kernel.h> >> +#include <linux/list.h> >> +#include <linux/of.h> >> +#include <linux/slab.h> >> + >> +#include "firewall.h" >> + >> +/* Mutex taken to protect firewall_list */ >> +static DEFINE_MUTEX(firewall_list_mutex); >> + >> +/* Global list of firewall control devices */ >> +static LIST_HEAD(firewall_list); > Why is that needed? Why can't you just walk the list of devices on this > "bus/class" if you really wanted to? > > Along those lines, why is this going around the driver model and > ignoring it? Shouldn't this be a bus and you have devices attached to > it of the specific type? This part of the series is only a a set of common functions and bindings that I plan to reuse for futur STM32 SoCs. The 'real' bus implementation is in patch 4. Benjamin > > > greg k-h
On Tue, May 05, 2020 at 03:00:53PM +0000, Benjamin GAIGNARD wrote: > > > On 5/5/20 4:40 PM, Greg KH wrote: > > On Tue, May 05, 2020 at 09:33:05AM +0200, Benjamin Gaignard wrote: > >> The goal of these helpers are to offer an interface for the > >> hardware blocks controlling bus accesses rights. > >> > >> Bus firewall controllers are typically used to control if a > >> hardware block can perform read or write operations on bus. > >> > >> Smarter firewall controllers could be able to define accesses > >> rights per hardware blocks to control where they can read > >> or write. > >> > >> Firewall controller configurations are provided in device node, > >> parsed by the helpers and send to the driver to apply them. > >> Each controller may need different number and type of inputs > >> to configure the firewall so device-tree properties size have to > >> be define by using "#firewall-cells". > >> Firewall configurations properties have to be named "firewall-X" > >> on device node. > >> "firewall-names" keyword can also be used to give a name to > >> a specific configuration. > >> > >> Example of device-tree: > >> ctrl0: firewall@0 { > >> #firewall-cells = <2>; > >> }; > >> > >> foo: foo@0 { > >> firewall-names = "default", "setting1"; > >> firewall-0 = <&ctrl0 1 2>; > >> firewall-1 = <&ctrl0 3 4>; > >> }; > >> > >> Configurations could be applied with functions like > >> firewall_set_config_by_index() or firewall_set_config_by_name(). > >> > >> firewall_set_default_config() function will apply the > >> configuration named "default" (if existing) or the configuration > >> with index 0 (i.e. firewall-0). > >> > >> Drivers could register/unregister themselves be calling > >> firewall_register/firewall_unregister functions. > >> > >> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com> > >> --- > >> drivers/bus/Kconfig | 2 + > >> drivers/bus/Makefile | 2 + > >> drivers/bus/stm32/Kconfig | 3 + > >> drivers/bus/stm32/Makefile | 1 + > >> drivers/bus/stm32/firewall.c | 266 +++++++++++++++++++++++++++++++++++++++++++ > >> drivers/bus/stm32/firewall.h | 75 ++++++++++++ > >> 6 files changed, 349 insertions(+) > >> create mode 100644 drivers/bus/stm32/Kconfig > >> create mode 100644 drivers/bus/stm32/Makefile > >> create mode 100644 drivers/bus/stm32/firewall.c > >> create mode 100644 drivers/bus/stm32/firewall.h > >> > >> diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig > >> index 6d4e4497b59b..843b356322d9 100644 > >> --- a/drivers/bus/Kconfig > >> +++ b/drivers/bus/Kconfig > >> @@ -203,4 +203,6 @@ config DA8XX_MSTPRI > >> source "drivers/bus/fsl-mc/Kconfig" > >> source "drivers/bus/mhi/Kconfig" > >> > >> +source "drivers/bus/stm32/Kconfig" > >> + > >> endmenu > >> diff --git a/drivers/bus/Makefile b/drivers/bus/Makefile > >> index 05f32cd694a4..5e0e34b10235 100644 > >> --- a/drivers/bus/Makefile > >> +++ b/drivers/bus/Makefile > >> @@ -37,3 +37,5 @@ obj-$(CONFIG_DA8XX_MSTPRI) += da8xx-mstpri.o > >> > >> # MHI > >> obj-$(CONFIG_MHI_BUS) += mhi/ > >> + > >> +obj-$(CONFIG_MACH_STM32MP157) += stm32/ > >> \ No newline at end of file > >> diff --git a/drivers/bus/stm32/Kconfig b/drivers/bus/stm32/Kconfig > >> new file mode 100644 > >> index 000000000000..57221e833e2d > >> --- /dev/null > >> +++ b/drivers/bus/stm32/Kconfig > >> @@ -0,0 +1,3 @@ > >> +config FIREWALL_CONTROLLERS > >> + bool "Support of bus firewall controllers" > >> + depends on OF > >> diff --git a/drivers/bus/stm32/Makefile b/drivers/bus/stm32/Makefile > >> new file mode 100644 > >> index 000000000000..eb6b978d6450 > >> --- /dev/null > >> +++ b/drivers/bus/stm32/Makefile > >> @@ -0,0 +1 @@ > >> +obj-$(CONFIG_FIREWALL_CONTROLLERS) += firewall.o > >> diff --git a/drivers/bus/stm32/firewall.c b/drivers/bus/stm32/firewall.c > >> new file mode 100644 > >> index 000000000000..95f716cf926f > >> --- /dev/null > >> +++ b/drivers/bus/stm32/firewall.c > >> @@ -0,0 +1,266 @@ > >> +// SPDX-License-Identifier: GPL-2.0 > >> +/* > >> + * Copyright (C) STMicroelectronics 2020 - All Rights Reserved > >> + * Author: Benjamin Gaignard <benjamin.gaignard@st.com> for STMicroelectronics. > >> + */ > >> + > >> +#include <linux/device.h> > >> +#include <linux/err.h> > >> +#include <linux/init.h> > >> +#include <linux/kernel.h> > >> +#include <linux/list.h> > >> +#include <linux/of.h> > >> +#include <linux/slab.h> > >> + > >> +#include "firewall.h" > >> + > >> +/* Mutex taken to protect firewall_list */ > >> +static DEFINE_MUTEX(firewall_list_mutex); > >> + > >> +/* Global list of firewall control devices */ > >> +static LIST_HEAD(firewall_list); > > Why is that needed? Why can't you just walk the list of devices on this > > "bus/class" if you really wanted to? > > > > Along those lines, why is this going around the driver model and > > ignoring it? Shouldn't this be a bus and you have devices attached to > > it of the specific type? > This part of the series is only a a set of common functions and bindings > that I plan to reuse for futur STM32 SoCs. > The 'real' bus implementation is in patch 4. Then you don't need a "fake" list of devices in this patch, do you? Why not just create the real bus and then have people use it, otherwise this sequence of review is really complicated as you must be deleting this code. Right? :) Do it correct the first time please. thanks, greg k-h
diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig index 6d4e4497b59b..843b356322d9 100644 --- a/drivers/bus/Kconfig +++ b/drivers/bus/Kconfig @@ -203,4 +203,6 @@ config DA8XX_MSTPRI source "drivers/bus/fsl-mc/Kconfig" source "drivers/bus/mhi/Kconfig" +source "drivers/bus/stm32/Kconfig" + endmenu diff --git a/drivers/bus/Makefile b/drivers/bus/Makefile index 05f32cd694a4..5e0e34b10235 100644 --- a/drivers/bus/Makefile +++ b/drivers/bus/Makefile @@ -37,3 +37,5 @@ obj-$(CONFIG_DA8XX_MSTPRI) += da8xx-mstpri.o # MHI obj-$(CONFIG_MHI_BUS) += mhi/ + +obj-$(CONFIG_MACH_STM32MP157) += stm32/ \ No newline at end of file diff --git a/drivers/bus/stm32/Kconfig b/drivers/bus/stm32/Kconfig new file mode 100644 index 000000000000..57221e833e2d --- /dev/null +++ b/drivers/bus/stm32/Kconfig @@ -0,0 +1,3 @@ +config FIREWALL_CONTROLLERS + bool "Support of bus firewall controllers" + depends on OF diff --git a/drivers/bus/stm32/Makefile b/drivers/bus/stm32/Makefile new file mode 100644 index 000000000000..eb6b978d6450 --- /dev/null +++ b/drivers/bus/stm32/Makefile @@ -0,0 +1 @@ +obj-$(CONFIG_FIREWALL_CONTROLLERS) += firewall.o diff --git a/drivers/bus/stm32/firewall.c b/drivers/bus/stm32/firewall.c new file mode 100644 index 000000000000..95f716cf926f --- /dev/null +++ b/drivers/bus/stm32/firewall.c @@ -0,0 +1,266 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright (C) STMicroelectronics 2020 - All Rights Reserved + * Author: Benjamin Gaignard <benjamin.gaignard@st.com> for STMicroelectronics. + */ + +#include <linux/device.h> +#include <linux/err.h> +#include <linux/init.h> +#include <linux/kernel.h> +#include <linux/list.h> +#include <linux/of.h> +#include <linux/slab.h> + +#include "firewall.h" + +/* Mutex taken to protect firewall_list */ +static DEFINE_MUTEX(firewall_list_mutex); + +/* Global list of firewall control devices */ +static LIST_HEAD(firewall_list); + +struct firewall_ctrl { + struct list_head list; + struct firewall_ops *ops; + struct device_node *np; + void *priv; +}; + +static struct firewall_ctrl *get_firewallctrl_from_node(struct device_node *np) +{ + struct firewall_ctrl *ctrl; + + mutex_lock(&firewall_list_mutex); + + list_for_each_entry(ctrl, &firewall_list, list) { + if (ctrl->np == np) { + mutex_unlock(&firewall_list_mutex); + return ctrl; + } + } + + mutex_unlock(&firewall_list_mutex); + + return NULL; +} + +/** + * firewall_dt_has_default + * + * Check if the device node provide firewall configuration + * + * @np: device node with possible firewall configuration + * + * Return: true is firewall-0 property exist in the device node + */ +static bool firewall_dt_has_default(struct device_node *np) +{ + struct property *prop; + int size; + + if (!np) + return false; + + prop = of_find_property(np, "firewall-0", &size); + + return prop ? true : false; +} + +/** + * firewall_set_config_by_index + * + * Set a firewall controller configuration based on given index. + * + * @np: device node with firewall configuration to apply. + * @index: the index of the configuration in device node. + * + * Return: 0 if OK, -EPROBE_DEFER if waiting for firewall controller to be + * registered or negative value on other errors. + */ +int firewall_set_config_by_index(struct device_node *np, int index) +{ + char *propname; + int configs, i, err = 0; + + if (!np) + return 0; + + propname = kasprintf(GFP_KERNEL, "firewall-%d", index); + configs = of_count_phandle_with_args(np, propname, "#firewall-cells"); + if (configs < 0) { + err = -EINVAL; + goto error; + } + + for (i = 0; i < configs; i++) { + struct firewall_ctrl *ctrl; + struct of_phandle_args args; + + err = of_parse_phandle_with_args(np, propname, + "#firewall-cells", + i, &args); + if (err) + goto error; + + /* Test if the controller is (or will be) available */ + if (!of_device_is_available(args.np)) { + of_node_put(args.np); + continue; + } + + ctrl = get_firewallctrl_from_node(args.np); + of_node_put(args.np); + + /* Controller is not yet registered */ + if (!ctrl) { + err = -EPROBE_DEFER; + goto error; + } + + err = ctrl->ops->set_config(ctrl->priv, &args); + if (err) + goto error; + } + +error: + kfree(propname); + return err; +} +EXPORT_SYMBOL_GPL(firewall_set_config_by_index); + +/** + * firewall_set_config_by_name + * + * Set a firwall controller configuration based on given name. + * + * @np: device node with firewall configuration to apply. + * @name: the name of the configuration in device node. + * + * Return: 0 if OK, -EPROBE_DEFER if waiting for firewall controller to be + * registered or negative value on other errors. + */ +int firewall_set_config_by_name(struct device_node *np, char *name) +{ + const char *configname; + int count, i; + + count = of_property_count_strings(np, "firewall-names"); + for (i = 0; i < count; i++) { + int err; + + err = of_property_read_string_index(np, + "firewall-names", + i, &configname); + if (err) + return err; + + if (strcmp(name, configname)) + continue; + + return firewall_set_config_by_index(np, i); + } + + return -EINVAL; +} +EXPORT_SYMBOL_GPL(firewall_set_config_by_name); + +/** + * firewall_set_default_config + * + * Set the default configuration for device. + * First try to apply configuration named "default", if it fails + * or doesn't exist, try to apply firewall-0 configuration. + * + * @np: device node with firewall configuration to apply. + * + * Return: 0 if OK, -EPROBE_DEFER if waiting for firewall controller to be + * registered or negative value on other errors. + */ +int firewall_set_default_config(struct device_node *np) +{ + int ret; + + /* Nothing to do if device node doesn't contain at least + * one configuration + */ + if (!firewall_dt_has_default(np)) + return 0; + + ret = firewall_set_config_by_name(np, "default"); + if (!ret || (ret == -EPROBE_DEFER)) + return ret; + + return firewall_set_config_by_index(np, 0); +} +EXPORT_SYMBOL_GPL(firewall_set_default_config); + +/** + * firewall_register + * + * Register a firewall controller. + * + * @np: node implementing firewall controller. + * @ops: firewall controller operations. + * @priv: caller private data. + * + * Return: 0 if OK or negative value on error. + */ +int firewall_register(struct device_node *np, + struct firewall_ops *ops, + void *priv) +{ + struct firewall_ctrl *ctrl; + + if (!np || !ops || !ops->set_config) + return -EINVAL; + + ctrl = kzalloc(sizeof(*ctrl), GFP_KERNEL); + if (!ctrl) + return -ENOMEM; + + INIT_LIST_HEAD(&ctrl->list); + + ctrl->np = np; + ctrl->ops = ops; + ctrl->priv = priv; + + mutex_lock(&firewall_list_mutex); + list_add_tail(&ctrl->list, &firewall_list); + mutex_unlock(&firewall_list_mutex); + + return 0; +} +EXPORT_SYMBOL_GPL(firewall_register); + +/** + * firewall_unregister + * + * Unregister a firewall controller. + * + * @np: node implementing firewall controller. + */ +void firewall_unregister(struct device_node *np) +{ + struct firewall_ctrl *ctrl; + + ctrl = get_firewallctrl_from_node(np); + if (!ctrl) + return; + + mutex_lock(&firewall_list_mutex); + list_del(&ctrl->list); + mutex_unlock(&firewall_list_mutex); + + kfree(ctrl); +} +EXPORT_SYMBOL_GPL(firewall_unregister); + +static int __init firewall_init(void) +{ + pr_info("initialized bus firewall controller subsystem\n"); + return 0; +} + +/* Init early since drivers really need to configure firewall early */ +core_initcall(firewall_init); diff --git a/drivers/bus/stm32/firewall.h b/drivers/bus/stm32/firewall.h new file mode 100644 index 000000000000..d6fd720a229e --- /dev/null +++ b/drivers/bus/stm32/firewall.h @@ -0,0 +1,75 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * Copyright (C) STMicroelectronics 2020 - All Rights Reserved + * Author: Benjamin Gaignard <benjamin.gaignard@st.com> for STMicroelectronics. + */ + +#ifndef _FIREWALL_H_ +#define _FIREWALL_H_ + +#include <linux/device.h> +#include <linux/of.h> + +/** + * struct firewall_ops + * + * Firewall controller operations structure to be filled by drivers. + */ +struct firewall_ops { + /** + * @set_config: + * + * Driver callback to set a firewall configuration on a controller. + * Configuration arguments are provided in out_args parameter. + * + * Return: 0 on success, a negative error code on failure. + */ + int (*set_config)(void *priv, struct of_phandle_args *out_args); +}; + +#ifdef CONFIG_FIREWALL_CONTROLLERS + +int firewall_set_config_by_index(struct device_node *np, int index); +int firewall_set_config_by_name(struct device_node *np, char *name); +int firewall_set_default_config(struct device_node *np); + +int firewall_register(struct device_node *np, + struct firewall_ops *ops, + void *priv); + +void firewall_unregister(struct device_node *np); + +#else + +static inline int firewall_set_config_by_index(struct device_node *np, + int index) +{ + return 0; +} + +static inline int firewall_set_config_by_name(struct device_node *np, + char *name) +{ + return 0; +} + +static inline int firewall_set_default_config(struct device_node *np) +{ + return 0; +} + +static inline int firewall_register(struct device_node *np, + struct firewall_ops *ops, + void *priv) +{ + return 0; +} + +static inline void firewall_unregister(struct device_node *np) +{ + /* Empty */ +} + +#endif + +#endif /* _FIREWALL_H_ */
The goal of these helpers are to offer an interface for the hardware blocks controlling bus accesses rights. Bus firewall controllers are typically used to control if a hardware block can perform read or write operations on bus. Smarter firewall controllers could be able to define accesses rights per hardware blocks to control where they can read or write. Firewall controller configurations are provided in device node, parsed by the helpers and send to the driver to apply them. Each controller may need different number and type of inputs to configure the firewall so device-tree properties size have to be define by using "#firewall-cells". Firewall configurations properties have to be named "firewall-X" on device node. "firewall-names" keyword can also be used to give a name to a specific configuration. Example of device-tree: ctrl0: firewall@0 { #firewall-cells = <2>; }; foo: foo@0 { firewall-names = "default", "setting1"; firewall-0 = <&ctrl0 1 2>; firewall-1 = <&ctrl0 3 4>; }; Configurations could be applied with functions like firewall_set_config_by_index() or firewall_set_config_by_name(). firewall_set_default_config() function will apply the configuration named "default" (if existing) or the configuration with index 0 (i.e. firewall-0). Drivers could register/unregister themselves be calling firewall_register/firewall_unregister functions. Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com> --- drivers/bus/Kconfig | 2 + drivers/bus/Makefile | 2 + drivers/bus/stm32/Kconfig | 3 + drivers/bus/stm32/Makefile | 1 + drivers/bus/stm32/firewall.c | 266 +++++++++++++++++++++++++++++++++++++++++++ drivers/bus/stm32/firewall.h | 75 ++++++++++++ 6 files changed, 349 insertions(+) create mode 100644 drivers/bus/stm32/Kconfig create mode 100644 drivers/bus/stm32/Makefile create mode 100644 drivers/bus/stm32/firewall.c create mode 100644 drivers/bus/stm32/firewall.h