| Message ID | 20200507114205.24621-1-geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 0932969e0b1b6ba54028b35b80148302e8fe7db8 |
| Headers | show |
| Series | via-rhine: Add platform dependencies | expand |
On Thu, May 7, 2020 at 1:42 PM Geert Uytterhoeven <geert+renesas@glider.be> wrote: > > The VIA Rhine Ethernet interface is only present on PCI devices or > VIA/WonderMedia VT8500/WM85xx SoCs. Add platform dependencies to the > VIA_RHINE config symbol, to avoid asking the user about it when > configuring a kernel without PCI or VT8500/WM85xx support. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Acked-by: Arnd Bergmann <arnd@arndb.de> I suppose it might be used on VIA/Zhaoxin SoCs, but presumably those would always show it as a PCI device. Arnd
From: Geert Uytterhoeven <geert+renesas@glider.be> Date: Thu, 7 May 2020 13:42:05 +0200 > The VIA Rhine Ethernet interface is only present on PCI devices or > VIA/WonderMedia VT8500/WM85xx SoCs. Add platform dependencies to the > VIA_RHINE config symbol, to avoid asking the user about it when > configuring a kernel without PCI or VT8500/WM85xx support. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Applied to net-next. Although I hope that the COMPILE_TEST guard is not too loose and now we'll have randconfig build failures for some reason.
Hi David, On Thu, May 7, 2020 at 10:17 PM David Miller <davem@davemloft.net> wrote: > From: Geert Uytterhoeven <geert+renesas@glider.be> > Date: Thu, 7 May 2020 13:42:05 +0200 > > > The VIA Rhine Ethernet interface is only present on PCI devices or > > VIA/WonderMedia VT8500/WM85xx SoCs. Add platform dependencies to the > > VIA_RHINE config symbol, to avoid asking the user about it when > > configuring a kernel without PCI or VT8500/WM85xx support. > > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Applied to net-next. Thank you! > Although I hope that the COMPILE_TEST guard is not too loose and > now we'll have randconfig build failures for some reason. I only added a dependency line, and didn't replace the old one. The "depends on PCI || (OF_IRQ && GENERIC_PCI_IOMAP)" is still there. Gr{oetje,eeting}s, Geert
diff --git a/drivers/net/ethernet/via/Kconfig b/drivers/net/ethernet/via/Kconfig index a962097b58c66935..6cff5f7d57c47ba7 100644 --- a/drivers/net/ethernet/via/Kconfig +++ b/drivers/net/ethernet/via/Kconfig @@ -19,6 +19,7 @@ if NET_VENDOR_VIA config VIA_RHINE tristate "VIA Rhine support" depends on PCI || (OF_IRQ && GENERIC_PCI_IOMAP) + depends on PCI || ARCH_VT8500 || COMPILE_TEST depends on HAS_DMA select CRC32 select MII
The VIA Rhine Ethernet interface is only present on PCI devices or VIA/WonderMedia VT8500/WM85xx SoCs. Add platform dependencies to the VIA_RHINE config symbol, to avoid asking the user about it when configuring a kernel without PCI or VT8500/WM85xx support. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/net/ethernet/via/Kconfig | 1 + 1 file changed, 1 insertion(+)