[v2] spi: sun6i: Add support for GPIO chip select lines

Commit Message

Alistair Francis May 11, 2020, 4:53 a.m. UTC

Set use_gpio_descriptors as true to support using generic GPIO
lines for the chip select.

Signed-off-by: Alistair Francis <[e-mail]>
---
v2:
 - Use use_gpio_descriptors instead of spi_setup

 drivers/spi/spi-sun6i.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Mark Brown May 11, 2020, 11:25 a.m. UTC | #1

On Sun, 10 May 2020 21:53:30 -0700, Alistair Francis wrote:
> Set use_gpio_descriptors as true to support using generic GPIO
> lines for the chip select.

Applied to

   local tree asoc/for-5.7

Thanks!

[1/1] spi: sun6i: Add support for GPIO chip select lines
      (no commit info)

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

Maxime Ripard May 11, 2020, 12:42 p.m. UTC | #2

Hi Mark

On Mon, May 11, 2020 at 12:25:35PM +0100, Mark Brown wrote:
> On Sun, 10 May 2020 21:53:30 -0700, Alistair Francis wrote:
> > Set use_gpio_descriptors as true to support using generic GPIO
> > lines for the chip select.
> 
> Applied to
> 
>    local tree asoc/for-5.7

Are you sure this is the proper tree?

Maxime

Mark Brown May 11, 2020, 2:53 p.m. UTC | #3

On Mon, May 11, 2020 at 02:42:45PM +0200, Maxime Ripard wrote:
> On Mon, May 11, 2020 at 12:25:35PM +0100, Mark Brown wrote:

> >    local tree asoc/for-5.7

> Are you sure this is the proper tree?

b4 seems to have grown a bug :/

Mark Brown May 11, 2020, 5:21 p.m. UTC | #4

On Sun, 10 May 2020 21:53:30 -0700, Alistair Francis wrote:
> Set use_gpio_descriptors as true to support using generic GPIO
> lines for the chip select.

Applied to

   local tree spi/for-5.7

Thanks!

[1/1] spi: sun6i: Add support for GPIO chip select lines
      (no commit info)

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

Patch

diff --git a/drivers/spi/spi-sun6i.c b/drivers/spi/spi-sun6i.c
index ec7967be9e2f..ecea15534c42 100644
--- a/drivers/spi/spi-sun6i.c
+++ b/drivers/spi/spi-sun6i.c
@@ -470,6 +470,7 @@  static int sun6i_spi_probe(struct platform_device *pdev)
 
 	master->max_speed_hz = 100 * 1000 * 1000;
 	master->min_speed_hz = 3 * 1000;
+	master->use_gpio_descriptors = true;
 	master->set_cs = sun6i_spi_set_cs;
 	master->transfer_one = sun6i_spi_transfer_one;
 	master->num_chipselect = 4;