diff mbox series

ARM: dts: imx7d-pinfunc: add input mux for ENET2 mdio

Message ID 20200515114151.6516-1-s.trumtrar@pengutronix.de (mailing list archive)
State Mainlined
Commit fbf40f4e64ba7eb814aa02b6c4c76a032f877ad6
Headers show
Series ARM: dts: imx7d-pinfunc: add input mux for ENET2 mdio | expand

Commit Message

Steffen Trumtrar May 15, 2020, 11:41 a.m. UTC
Add the missing input mux for ENET2 mdio. Without this setting, it is not
possible to read the MDIO answers back from the PHY.

Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
---
 arch/arm/boot/dts/imx7d-pinfunc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Aisheng Dong May 18, 2020, 3:54 a.m. UTC | #1
> From: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> Sent: Friday, May 15, 2020 7:42 PM
> 
> Add the missing input mux for ENET2 mdio. Without this setting, it is not
> possible to read the MDIO answers back from the PHY.
> 
> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> ---
>  arch/arm/boot/dts/imx7d-pinfunc.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/imx7d-pinfunc.h
> b/arch/arm/boot/dts/imx7d-pinfunc.h
> index 08ca1608fdb1..69f2c1ec8254 100644
> --- a/arch/arm/boot/dts/imx7d-pinfunc.h
> +++ b/arch/arm/boot/dts/imx7d-pinfunc.h
> @@ -592,7 +592,7 @@
>  #define MX7D_PAD_UART2_RX_DATA__ECSPI1_SS3
> 0x0130 0x03A0 0x0000 0x3 0x0
>  #define MX7D_PAD_UART2_RX_DATA__ENET2_1588_EVENT1_IN
> 0x0130 0x03A0 0x0000 0x4 0x0
>  #define MX7D_PAD_UART2_RX_DATA__GPIO4_IO2
> 0x0130 0x03A0 0x0000 0x5 0x0
> -#define MX7D_PAD_UART2_RX_DATA__ENET2_MDIO
> 0x0130 0x03A0 0x0000 0x6 0x0
> +#define MX7D_PAD_UART2_RX_DATA__ENET2_MDIO
> 0x0130 0x03A0 0x0574 0x6 0x1

It's strange that I didn't find this select input setting from latest RM.
Anything I missed?

Also copy Andy to comment.

Regards
Aisheng

>  #define MX7D_PAD_UART2_TX_DATA__UART2_DCE_TX
> 0x0134 0x03A4 0x0000 0x0 0x0
>  #define MX7D_PAD_UART2_TX_DATA__UART2_DTE_RX
> 0x0134 0x03A4 0x06FC 0x0 0x3
>  #define MX7D_PAD_UART2_TX_DATA__I2C2_SDA
> 0x0134 0x03A4 0x05E0 0x1 0x0
> --
> 2.26.2
Andy Duan May 18, 2020, 4:35 a.m. UTC | #2
From: Aisheng Dong <aisheng.dong@nxp.com> Sent: Monday, May 18, 2020 11:55 AM
> > From: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> > Sent: Friday, May 15, 2020 7:42 PM
> >
> > Add the missing input mux for ENET2 mdio. Without this setting, it is
> > not possible to read the MDIO answers back from the PHY.
> >
> > Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> > ---
> >  arch/arm/boot/dts/imx7d-pinfunc.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/imx7d-pinfunc.h
> > b/arch/arm/boot/dts/imx7d-pinfunc.h
> > index 08ca1608fdb1..69f2c1ec8254 100644
> > --- a/arch/arm/boot/dts/imx7d-pinfunc.h
> > +++ b/arch/arm/boot/dts/imx7d-pinfunc.h
> > @@ -592,7 +592,7 @@
> >  #define MX7D_PAD_UART2_RX_DATA__ECSPI1_SS3
> > 0x0130 0x03A0 0x0000 0x3 0x0
> >  #define MX7D_PAD_UART2_RX_DATA__ENET2_1588_EVENT1_IN
> > 0x0130 0x03A0 0x0000 0x4 0x0
> >  #define MX7D_PAD_UART2_RX_DATA__GPIO4_IO2
> > 0x0130 0x03A0 0x0000 0x5 0x0
> > -#define MX7D_PAD_UART2_RX_DATA__ENET2_MDIO
> > 0x0130 0x03A0 0x0000 0x6 0x0
> > +#define MX7D_PAD_UART2_RX_DATA__ENET2_MDIO
> > 0x0130 0x03A0 0x0574 0x6 0x1
> 
> It's strange that I didn't find this select input setting from latest RM.
> Anything I missed?
> 
> Also copy Andy to comment.
> 
Check the RM in my local, it define the signal select input from UART2_RX_DATA,
it is correct with the change.

Aisheng, we can check together for our RM version.
> Regards
> Aisheng
> 
> >  #define MX7D_PAD_UART2_TX_DATA__UART2_DCE_TX
> > 0x0134 0x03A4 0x0000 0x0 0x0
> >  #define MX7D_PAD_UART2_TX_DATA__UART2_DTE_RX
> > 0x0134 0x03A4 0x06FC 0x0 0x3
> >  #define MX7D_PAD_UART2_TX_DATA__I2C2_SDA
> > 0x0134 0x03A4 0x05E0 0x1 0x0
> > --
> > 2.26.2
Aisheng Dong May 18, 2020, 6:08 a.m. UTC | #3
> From: Andy Duan <fugang.duan@nxp.com>
> Sent: Monday, May 18, 2020 12:36 PM
> 
> From: Aisheng Dong <aisheng.dong@nxp.com> Sent: Monday, May 18, 2020
> 11:55 AM
> > > From: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> > > Sent: Friday, May 15, 2020 7:42 PM
> > >
> > > Add the missing input mux for ENET2 mdio. Without this setting, it
> > > is not possible to read the MDIO answers back from the PHY.
> > >
> > > Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> > > ---
> > >  arch/arm/boot/dts/imx7d-pinfunc.h | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/arch/arm/boot/dts/imx7d-pinfunc.h
> > > b/arch/arm/boot/dts/imx7d-pinfunc.h
> > > index 08ca1608fdb1..69f2c1ec8254 100644
> > > --- a/arch/arm/boot/dts/imx7d-pinfunc.h
> > > +++ b/arch/arm/boot/dts/imx7d-pinfunc.h
> > > @@ -592,7 +592,7 @@
> > >  #define MX7D_PAD_UART2_RX_DATA__ECSPI1_SS3
> > > 0x0130 0x03A0 0x0000 0x3 0x0
> > >  #define MX7D_PAD_UART2_RX_DATA__ENET2_1588_EVENT1_IN
> > > 0x0130 0x03A0 0x0000 0x4 0x0
> > >  #define MX7D_PAD_UART2_RX_DATA__GPIO4_IO2
> > > 0x0130 0x03A0 0x0000 0x5 0x0
> > > -#define MX7D_PAD_UART2_RX_DATA__ENET2_MDIO
> > > 0x0130 0x03A0 0x0000 0x6 0x0
> > > +#define MX7D_PAD_UART2_RX_DATA__ENET2_MDIO
> > > 0x0130 0x03A0 0x0574 0x6 0x1
> >
> > It's strange that I didn't find this select input setting from latest RM.
> > Anything I missed?
> >
> > Also copy Andy to comment.
> >
> Check the RM in my local, it define the signal select input from UART2_RX_DATA,
> it is correct with the change.
> 
> Aisheng, we can check together for our RM version.

You're right. I checked the wrong place.
So for this patch:

Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>

Regards
Aisheng

> > Regards
> > Aisheng
> >
> > >  #define MX7D_PAD_UART2_TX_DATA__UART2_DCE_TX
> > > 0x0134 0x03A4 0x0000 0x0 0x0
> > >  #define MX7D_PAD_UART2_TX_DATA__UART2_DTE_RX
> > > 0x0134 0x03A4 0x06FC 0x0 0x3
> > >  #define MX7D_PAD_UART2_TX_DATA__I2C2_SDA
> > > 0x0134 0x03A4 0x05E0 0x1 0x0
> > > --
> > > 2.26.2
Shawn Guo May 20, 2020, 2:50 a.m. UTC | #4
On Fri, May 15, 2020 at 01:41:51PM +0200, Steffen Trumtrar wrote:
> Add the missing input mux for ENET2 mdio. Without this setting, it is not
> possible to read the MDIO answers back from the PHY.
> 
> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>

Applied, thanks.
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/imx7d-pinfunc.h b/arch/arm/boot/dts/imx7d-pinfunc.h
index 08ca1608fdb1..69f2c1ec8254 100644
--- a/arch/arm/boot/dts/imx7d-pinfunc.h
+++ b/arch/arm/boot/dts/imx7d-pinfunc.h
@@ -592,7 +592,7 @@ 
 #define MX7D_PAD_UART2_RX_DATA__ECSPI1_SS3                        0x0130 0x03A0 0x0000 0x3 0x0
 #define MX7D_PAD_UART2_RX_DATA__ENET2_1588_EVENT1_IN              0x0130 0x03A0 0x0000 0x4 0x0
 #define MX7D_PAD_UART2_RX_DATA__GPIO4_IO2                         0x0130 0x03A0 0x0000 0x5 0x0
-#define MX7D_PAD_UART2_RX_DATA__ENET2_MDIO                        0x0130 0x03A0 0x0000 0x6 0x0
+#define MX7D_PAD_UART2_RX_DATA__ENET2_MDIO                        0x0130 0x03A0 0x0574 0x6 0x1
 #define MX7D_PAD_UART2_TX_DATA__UART2_DCE_TX                      0x0134 0x03A4 0x0000 0x0 0x0
 #define MX7D_PAD_UART2_TX_DATA__UART2_DTE_RX                      0x0134 0x03A4 0x06FC 0x0 0x3
 #define MX7D_PAD_UART2_TX_DATA__I2C2_SDA                          0x0134 0x03A4 0x05E0 0x1 0x0