| Message ID | 20200520043042.7281-1-hamish.martin@alliedtelesis.co.nz (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | be0ec060b54f0481fb95d59086c1484a949c903c |
| Headers | show |
| Series | ARM: dts: bcm: HR2: Fix PPI interrupt types | expand |
On 5/19/2020 9:30 PM, Hamish Martin wrote: > These error messages are output when booting on a BCM HR2 system: > GIC: PPI11 is secure or misconfigured > GIC: PPI13 is secure or misconfigured > > Per ARM documentation these interrupts are triggered on a rising edge. > See ARM Cortex A-9 MPCore Technical Reference Manual, Revision r4p1, > Section 3.3.8 Interrupt Configuration Registers. > > The same issue was resolved for NSP systems in commit 5f1aa51c7a1e > ("ARM: dts: NSP: Fix PPI interrupt types"). > > Signed-off-by: Hamish Martin <hamish.martin@alliedtelesis.co.nz> Thanks Hamish, this should also have a: Fixes: b9099ec754b5 ("ARM: dts: Add Broadcom Hurricane 2 DTS include file") I will take care of adding it while applying, thanks! > --- > arch/arm/boot/dts/bcm-hr2.dtsi | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/boot/dts/bcm-hr2.dtsi b/arch/arm/boot/dts/bcm-hr2.dtsi > index 6142c672811e..5e5f5ca3c86f 100644 > --- a/arch/arm/boot/dts/bcm-hr2.dtsi > +++ b/arch/arm/boot/dts/bcm-hr2.dtsi > @@ -75,7 +75,7 @@ a9pll: arm_clk@0 { > timer@20200 { > compatible = "arm,cortex-a9-global-timer"; > reg = <0x20200 0x100>; > - interrupts = <GIC_PPI 11 IRQ_TYPE_LEVEL_HIGH>; > + interrupts = <GIC_PPI 11 IRQ_TYPE_EDGE_RISING>; > clocks = <&periph_clk>; > }; > > @@ -83,7 +83,7 @@ twd-timer@20600 { > compatible = "arm,cortex-a9-twd-timer"; > reg = <0x20600 0x20>; > interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(1) | > - IRQ_TYPE_LEVEL_HIGH)>; > + IRQ_TYPE_EDGE_RISING)>; > clocks = <&periph_clk>; > }; > > @@ -91,7 +91,7 @@ twd-watchdog@20620 { > compatible = "arm,cortex-a9-twd-wdt"; > reg = <0x20620 0x20>; > interrupts = <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(1) | > - IRQ_TYPE_LEVEL_HIGH)>; > + IRQ_TYPE_EDGE_RISING)>; > clocks = <&periph_clk>; > }; > >
On 5/19/2020 9:30 PM, Hamish Martin wrote: > These error messages are output when booting on a BCM HR2 system: > GIC: PPI11 is secure or misconfigured > GIC: PPI13 is secure or misconfigured > > Per ARM documentation these interrupts are triggered on a rising edge. > See ARM Cortex A-9 MPCore Technical Reference Manual, Revision r4p1, > Section 3.3.8 Interrupt Configuration Registers. > > The same issue was resolved for NSP systems in commit 5f1aa51c7a1e > ("ARM: dts: NSP: Fix PPI interrupt types"). > > Signed-off-by: Hamish Martin <hamish.martin@alliedtelesis.co.nz> > --- Applied to devicetree/fixes, please copy bcm-kernel-feedback-list@broadcom.com so we can have our CI pick up this patch. Thanks!
diff --git a/arch/arm/boot/dts/bcm-hr2.dtsi b/arch/arm/boot/dts/bcm-hr2.dtsi index 6142c672811e..5e5f5ca3c86f 100644 --- a/arch/arm/boot/dts/bcm-hr2.dtsi +++ b/arch/arm/boot/dts/bcm-hr2.dtsi @@ -75,7 +75,7 @@ a9pll: arm_clk@0 { timer@20200 { compatible = "arm,cortex-a9-global-timer"; reg = <0x20200 0x100>; - interrupts = <GIC_PPI 11 IRQ_TYPE_LEVEL_HIGH>; + interrupts = <GIC_PPI 11 IRQ_TYPE_EDGE_RISING>; clocks = <&periph_clk>; }; @@ -83,7 +83,7 @@ twd-timer@20600 { compatible = "arm,cortex-a9-twd-timer"; reg = <0x20600 0x20>; interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(1) | - IRQ_TYPE_LEVEL_HIGH)>; + IRQ_TYPE_EDGE_RISING)>; clocks = <&periph_clk>; }; @@ -91,7 +91,7 @@ twd-watchdog@20620 { compatible = "arm,cortex-a9-twd-wdt"; reg = <0x20620 0x20>; interrupts = <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(1) | - IRQ_TYPE_LEVEL_HIGH)>; + IRQ_TYPE_EDGE_RISING)>; clocks = <&periph_clk>; };
These error messages are output when booting on a BCM HR2 system: GIC: PPI11 is secure or misconfigured GIC: PPI13 is secure or misconfigured Per ARM documentation these interrupts are triggered on a rising edge. See ARM Cortex A-9 MPCore Technical Reference Manual, Revision r4p1, Section 3.3.8 Interrupt Configuration Registers. The same issue was resolved for NSP systems in commit 5f1aa51c7a1e ("ARM: dts: NSP: Fix PPI interrupt types"). Signed-off-by: Hamish Martin <hamish.martin@alliedtelesis.co.nz> --- arch/arm/boot/dts/bcm-hr2.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)